- User Since
- Feb 1 2022, 4:35 AM (51 w, 6 d)
Sun, Jan 15
Wed, Jan 11
Sat, Jan 7
Mon, Jan 2
Nov 28 2022
It is also completely irrelevant, because a new programmer will not understand that const T const * is actually T const* and not T const * const. An experienced programmer can understand it well either way.
not sure I follow the argument here, but surely I also agree that east consts are more readable and fool-proof. it's unfortunate that most of the C++ world is stuck with the west consts.
Applied clang-format QualifierAlignment: Left
Nov 25 2022
Nov 24 2022
Replaces match clauses with RecursiveASTVisistors
- doubled performance
- fixed also a bug in template spezialisations
Nov 20 2022
Improved fixit suggestion.
- No duplicated replacements.
Removed replacements for macros, since they could be wrong somehow.
Made some helperfunction non-trailing
Nov 19 2022
Nov 18 2022
Nov 15 2022
fixed lamda detection
Nov 14 2022
I have a problem with lambdas capturing by copy implicitly ([=]()...). It seems like, that child nodes are not reachable via a MatchFinder unless they are spelled in source. I actually don't know how to prevent a fix elegantly: My proposed idea is, to check the source location of the capture list for each lambda and check, if the declRefExpr is part of it... . This is bug prone, and possibly slow.
Nov 13 2022
Fixed some false positives:
- no move for no automatic storage duration
- no move for lambda captures
Nov 9 2022
Fixed segfaults due to asserts which were wrongly assumed to be always true
Nov 7 2022
Added some tests. Code cleanup.
Fixed lValueReference detection in matcher
Nov 6 2022
So I finally had time to apply your feedback.
- replaced some auto types with the actual type
- added IncludeStyle to the options list in the documentation
- Added "Limitations" paragraph, describing known limitations
Nov 2 2022
I applied the rest of your feedback.
There are other usages of auto like auto FoundUsage which is a Usage for example. ~Shall I also replace those obvious cases?~
Also added the documentation for the second option `BlockedFunctions`
Nov 1 2022
I also have to add the http://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-copy-on-last-use.html page, but I don't have any clue how, and where to start.
Feb 26 2022
@salman-javed-nz you're welcome, I only fixed it because I saw the bug in the trace directly. Normally, I would only fix C/C++ stuff :D.
@JonasToth yes, it would be nice, to test this and then push it for me. Also a backport to 14.0 would be good :).
Applied the feedback
Feb 10 2022
I don't think I have commit rights, so someone of you also have to commit this.
Currently, only tested on Windows.
This should also increase performance, since the path is canonicalized only once.
Feb 9 2022
Thank you for the review. I am done and you can commit the patch :) . I don't have the rights to commit.
Last batch of suggested changes
Can I still add a diff, or does this cause a revoke (apply the rest of the feedback)?
Also, is the commit added automatically to the repo, or do I / another one have to rebase it.
Feb 8 2022
Feb 7 2022
Push, would be nice to see this in the llvm-14 release. I can also do a review for someone else as a favor.
Feb 2 2022
Updated in https://reviews.llvm.org/D118847