This is an archive of the discontinued LLVM Phabricator instance.

Differential D123224

[x86] Replace getNodeIfExists to doesNodeExist when only check node exist
ClosedPublic

Authored by bcl5980 on Apr 6 2022, 8:27 AM.

Details

Reviewers
craig.topper
pengfei
spatel
RKSimon
Commits
rGf72b3a506b1d: [x86] Replace getNodeIfExists to doesNodeExist when only check node exist
Summary

getNodeIfExists will clear original node flags, so if we only check node exist or not we should use doesNodeExist

Diff Detail

Unit TestsFailed

TimeTest
60,100 msx64 debian > MLIR.Examples/standalone::test.toy
60,040 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp
60,060 msx64 debian > libFuzzer.libFuzzer::large.test

Event Timeline

bcl5980 created this revision.Apr 6 2022, 8:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2022, 8:27 AM
Herald added subscribers: StephenFan, hiraditya. · View Herald Transcript
bcl5980 requested review of this revision.Apr 6 2022, 8:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2022, 8:27 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
craig.topper accepted this revision.Apr 6 2022, 8:30 AM

LGTM. Though I'm not sure X86ISD::FRSQRT ever has node flags.

This revision is now accepted and ready to land.Apr 6 2022, 8:30 AM
Harbormaster completed remote builds in B158247: Diff 420876.Apr 6 2022, 10:06 AM
This revision was landed with ongoing or failed builds.Apr 7 2022, 9:34 AM
Closed by commit rGf72b3a506b1d: [x86] Replace getNodeIfExists to doesNodeExist when only check node exist (authored by bcl5980). · Explain Why
This revision was automatically updated to reflect the committed changes.
bcl5980 added a commit: rGf72b3a506b1d: [x86] Replace getNodeIfExists to doesNodeExist when only check node exist.

Revision Contents

PathSize
llvm/
lib/
Target/
X86/
2 lines

Diff 420876

llvm/lib/Target/X86/X86ISelLowering.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 23,391 Lines • ▼ Show 20 Lines
bool X86TargetLowering::isFsqrtCheap(SDValue Op, SelectionDAG &DAG) const { bool X86TargetLowering::isFsqrtCheap(SDValue Op, SelectionDAG &DAG) const {
EVT VT = Op.getValueType(); EVT VT = Op.getValueType();
// We don't need to replace SQRT with RSQRT for half type. // We don't need to replace SQRT with RSQRT for half type.
if (VT.getScalarType() == MVT::f16) if (VT.getScalarType() == MVT::f16)
return true; return true;
// We never want to use both SQRT and RSQRT instructions for the same input. // We never want to use both SQRT and RSQRT instructions for the same input.
if (DAG.getNodeIfExists(X86ISD::FRSQRT, DAG.getVTList(VT), Op)) if (DAG.doesNodeExist(X86ISD::FRSQRT, DAG.getVTList(VT), Op))
return false; return false;
if (VT.isVector()) if (VT.isVector())
return Subtarget.hasFastVectorFSQRT(); return Subtarget.hasFastVectorFSQRT();
return Subtarget.hasFastScalarFSQRT(); return Subtarget.hasFastScalarFSQRT();
} }
/// The minimum architected relative accuracy is 2^-12. We need one /// The minimum architected relative accuracy is 2^-12. We need one
▲ Show 20 Lines • Show All 32,363 Lines • Show Last 20 Lines