This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][test] Fix X86 cross-platform tests
ClosedPublic

Authored by maksfb on Apr 4 2022, 1:27 PM.

Details

Summary

Use target-specific flags for building X86 non-runnable tests.

Diff Detail

Event Timeline

maksfb created this revision.Apr 4 2022, 1:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 1:27 PM
Herald added a subscriber: pengfei. · View Herald Transcript
maksfb requested review of this revision.Apr 4 2022, 1:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 1:27 PM
maksfb added a comment.Apr 4 2022, 2:34 PM

@Amir, I cannot repro locally. Could you please investigate since you've added the failing test?

Amir added a comment.Apr 4 2022, 5:58 PM

@Amir, I cannot repro locally. Could you please investigate since you've added the failing test?

Please add the following to bolt/test/X86/split-func-jump-table-fragment-reverse.s:

 # CHECK: BOLT-INFO: marking main.cold as a fragment of main
   .text
+  .globl _start
+  .type _start, %function
+_start:
+  callq main.cold
+  call exit
+.size _start, .-_start
+
   .globl main.cold
maksfb updated this revision to Diff 420360.Apr 4 2022, 6:03 PM

Fix test failing pre-merge checks.

Amir accepted this revision.Apr 4 2022, 6:24 PM
This revision is now accepted and ready to land.Apr 4 2022, 6:24 PM
This revision was automatically updated to reflect the committed changes.