This is an archive of the discontinued LLVM Phabricator instance.

Differential D123046

[OpenMP] libomp: cleanup - remove duplicate check
ClosedPublic

Authored by AndreyChurbanov on Apr 4 2022, 9:23 AM.

Details

Reviewers
hbae
jlpeyton
tlwilmar
jdoerfert
Commits
rG4a64bed2160c: [OpenMP] libomp: cleanup - remove duplicate check
Summary

The identical check remains 20 lines above in the code.

Diff Detail

Event Timeline

AndreyChurbanov created this revision.Apr 4 2022, 9:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 9:23 AM
Herald added subscribers: guansong, yaxunl. · View Herald Transcript
AndreyChurbanov requested review of this revision.Apr 4 2022, 9:23 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptApr 4 2022, 9:23 AM
Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B157753: Diff 420206.Apr 4 2022, 9:29 AM
jlpeyton accepted this revision.May 5 2022, 8:59 AM

LGTM

This revision is now accepted and ready to land.May 5 2022, 8:59 AM
Closed by commit rG4a64bed2160c: [OpenMP] libomp: cleanup - remove duplicate check (authored by AndreyChurbanov, committed by jlpeyton). · Explain WhyMay 5 2022, 9:01 AM
This revision was automatically updated to reflect the committed changes.
jlpeyton added a commit: rG4a64bed2160c: [OpenMP] libomp: cleanup - remove duplicate check.

Revision Contents

PathSize
openmp/
runtime/
src/
4 lines

Diff 420206

openmp/runtime/src/kmp_wait_release.h

Show First 20 Lines • Show All 619 Lines • ▼ Show 20 Lines#else
if (KMP_BLOCKING(hibernate_goal, poll_count++)) if (KMP_BLOCKING(hibernate_goal, poll_count++))
continue; continue;
#endif #endif
// Don't suspend if wait loop designated non-sleepable // Don't suspend if wait loop designated non-sleepable
// in template parameters // in template parameters
if (!Sleepable) if (!Sleepable)
continue; continue;
if (__kmp_dflt_blocktime == KMP_MAX_BLOCKTIME &&
__kmp_pause_status != kmp_soft_paused)
continue;
#if KMP_HAVE_MWAIT || KMP_HAVE_UMWAIT #if KMP_HAVE_MWAIT || KMP_HAVE_UMWAIT
if (__kmp_mwait_enabled || __kmp_umwait_enabled) { if (__kmp_mwait_enabled || __kmp_umwait_enabled) {
KF_TRACE(50, ("__kmp_wait_sleep: T#%d using monitor/mwait\n", th_gtid)); KF_TRACE(50, ("__kmp_wait_sleep: T#%d using monitor/mwait\n", th_gtid));
flag->mwait(th_gtid); flag->mwait(th_gtid);
} else { } else {
#endif #endif
KF_TRACE(50, ("__kmp_wait_sleep: T#%d suspend time reached\n", th_gtid)); KF_TRACE(50, ("__kmp_wait_sleep: T#%d suspend time reached\n", th_gtid));
#if KMP_OS_UNIX #if KMP_OS_UNIX
▲ Show 20 Lines • Show All 421 Lines • Show Last 20 Lines