This commit adds pooling_nchw_sum as a yaml op.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/python/mlir/dialects/linalg/opdsl/ops/core_named_ops.py | ||
---|---|---|
546 | Can you add comments for layout similarly to the conv ops here https://github.com/llvm/llvm-project/blob/8361c5da30588d3d4a48eae648f53be1feb5cfad/mlir/python/mlir/dialects/linalg/opdsl/ops/core_named_ops.py#L333-L335? Also, for the existing pooling_nhwc_sum op |
mlir/include/mlir/Dialect/Linalg/IR/LinalgNamedStructuredOps.yaml | ||
---|---|---|
2265 | I think the yaml file need to be updated after the change in doc. |
LGTM!
There is also the option to make the reduction function / casting function used configurable to have one pooling operation that does max, min, and sum pooling. We have an example in the tests:
This is not relevant for this revision since none of the operations are using this! Just wanted to advertise the feature :).
I think the yaml file need to be updated after the change in doc.