Page MenuHomePhabricator

cathyzhyi (Yi Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 21 2021, 3:58 PM (25 w, 6 d)

Recent Activity

Jul 30 2021

cathyzhyi closed D106818: [mlir][linalg] Fix pad tensor cast folding with changed type.
Jul 30 2021, 11:38 AM · Restricted Project

Jul 29 2021

cathyzhyi committed rG9a8248231316: [mlir][linalg] Fix pad tensor cast folding with changed type (authored by cathyzhyi).
[mlir][linalg] Fix pad tensor cast folding with changed type
Jul 29 2021, 2:52 PM
cathyzhyi updated the diff for D106818: [mlir][linalg] Fix pad tensor cast folding with changed type.

address comments

Jul 29 2021, 2:16 PM · Restricted Project

Jul 26 2021

cathyzhyi retitled D106818: [mlir][linalg] Fix pad tensor cast folding with changed type from [mlir][linalg][WIP] Fix pad tensor cast folding with changed type to [mlir][linalg] Fix pad tensor cast folding with changed type.
Jul 26 2021, 1:52 PM · Restricted Project
cathyzhyi updated the diff for D106818: [mlir][linalg] Fix pad tensor cast folding with changed type.

minor fix

Jul 26 2021, 1:52 PM · Restricted Project
cathyzhyi retitled D106818: [mlir][linalg] Fix pad tensor cast folding with changed type from [mlir][linalg] Fix pad tensor cast folding with changed type to [mlir][linalg][WIP] Fix pad tensor cast folding with changed type.
Jul 26 2021, 12:39 PM · Restricted Project
cathyzhyi updated the diff for D106818: [mlir][linalg] Fix pad tensor cast folding with changed type.

remove redundant argument

Jul 26 2021, 12:25 PM · Restricted Project
cathyzhyi abandoned D106819: [mlir][linalg] Fix pad tensor cast folding with changed type.
Jul 26 2021, 12:24 PM · Restricted Project
cathyzhyi requested review of D106819: [mlir][linalg] Fix pad tensor cast folding with changed type.
Jul 26 2021, 12:23 PM · Restricted Project
cathyzhyi requested review of D106818: [mlir][linalg] Fix pad tensor cast folding with changed type.
Jul 26 2021, 12:19 PM · Restricted Project
cathyzhyi updated the diff for D106670: [mlir][memref] Fix collapsed shape ops memref.cast folding with changed type.

minor changes to commit title

Jul 26 2021, 10:52 AM · Restricted Project
cathyzhyi updated the summary of D106670: [mlir][memref] Fix collapsed shape ops memref.cast folding with changed type.
Jul 26 2021, 9:49 AM · Restricted Project
cathyzhyi updated the diff for D106670: [mlir][memref] Fix collapsed shape ops memref.cast folding with changed type.

fix with canonicalizer pattern instead of folder

Jul 26 2021, 9:47 AM · Restricted Project

Jul 25 2021

cathyzhyi added a comment to D106670: [mlir][memref] Fix collapsed shape ops memref.cast folding with changed type.

I think a better way to fix this is to use a canonicalizing pattern. Will modify the patch to do that.

Jul 25 2021, 7:52 PM · Restricted Project
cathyzhyi retitled D106670: [mlir][memref] Fix collapsed shape ops memref.cast folding with changed type from [MLIR][MEMREF] Limit cast folding for memref.collapse_shape to [WIP][MLIR][MEMREF] Limit cast folding for memref.collapse_shape.
Jul 25 2021, 7:50 PM · Restricted Project

Jul 23 2021

cathyzhyi retitled D106670: [mlir][memref] Fix collapsed shape ops memref.cast folding with changed type from Limit cast folding for memref.collapse_shape to [MLIR][MEMREF] Limit cast folding for memref.collapse_shape.
Jul 23 2021, 3:49 PM · Restricted Project
cathyzhyi abandoned D106719: Limit cast folding for memref.collapse_shape.
Jul 23 2021, 3:48 PM · Restricted Project
cathyzhyi requested review of D106719: Limit cast folding for memref.collapse_shape.
Jul 23 2021, 3:47 PM · Restricted Project
cathyzhyi abandoned D106698: Adding expandTanhPattern to StdExpandOpsPass.
Jul 23 2021, 1:26 PM · Restricted Project
cathyzhyi added a comment to D106670: [mlir][memref] Fix collapsed shape ops memref.cast folding with changed type.

@mravishankar Thanks a lot for reviewing! I don't have commit permission. Could you please also help me to land the change?

Jul 23 2021, 1:02 PM · Restricted Project
cathyzhyi requested review of D106698: Adding expandTanhPattern to StdExpandOpsPass.
Jul 23 2021, 12:18 PM · Restricted Project
cathyzhyi added a comment to D106658: [mlir][linalg] Add pooling_nchw_max, conv_2d_nchw as yaml ops..

Will do that!

Btw, the commit message should usually contain some tags, e.g. "[mlir][linalg] Add pooling_nchw_max, conv_2d_nchw as yaml ops." to clarify which parts of llvm it is touching.

Will do it before landing.

Jul 23 2021, 9:16 AM · Restricted Project
cathyzhyi added a comment to D106658: [mlir][linalg] Add pooling_nchw_max, conv_2d_nchw as yaml ops..

@gysit Hey Tobias, thanks a lot for reviewing! Could you please also help me land the change? I don't have commit access yet.

Jul 23 2021, 8:54 AM · Restricted Project
cathyzhyi added a reviewer for D106670: [mlir][memref] Fix collapsed shape ops memref.cast folding with changed type: mravishankar.
Jul 23 2021, 8:16 AM · Restricted Project
cathyzhyi updated the diff for D106670: [mlir][memref] Fix collapsed shape ops memref.cast folding with changed type.

update description

Jul 23 2021, 8:15 AM · Restricted Project
cathyzhyi updated the summary of D106670: [mlir][memref] Fix collapsed shape ops memref.cast folding with changed type.
Jul 23 2021, 8:10 AM · Restricted Project
cathyzhyi requested review of D106670: [mlir][memref] Fix collapsed shape ops memref.cast folding with changed type.
Jul 23 2021, 8:06 AM · Restricted Project
cathyzhyi updated the diff for D106658: [mlir][linalg] Add pooling_nchw_max, conv_2d_nchw as yaml ops..

clean up format

Jul 23 2021, 6:49 AM · Restricted Project
cathyzhyi requested review of D106658: [mlir][linalg] Add pooling_nchw_max, conv_2d_nchw as yaml ops..
Jul 23 2021, 5:55 AM · Restricted Project

Jul 16 2021

cathyzhyi added a reviewer for D106180: Dyanamic shape support for memref reassociation reshape ops: mravishankar.
Jul 16 2021, 12:57 PM · Restricted Project
cathyzhyi updated the diff for D106180: Dyanamic shape support for memref reassociation reshape ops.

minor changes

Jul 16 2021, 12:34 PM · Restricted Project
cathyzhyi requested review of D106180: Dyanamic shape support for memref reassociation reshape ops.
Jul 16 2021, 12:27 PM · Restricted Project

Jul 13 2021

cathyzhyi accepted D105852: [mlir][Tensor] Implement `reifyReturnTypeShapesPerResultDim` for `tensor.insert_slice`..

LGTM

Jul 13 2021, 9:28 AM · Restricted Project

Jul 8 2021

cathyzhyi updated the diff for D105642: Mark TensorDialect legal and PadTensor op illegal.

remove the integration test and add IR unit test instead

Jul 8 2021, 1:39 PM · Restricted Project
cathyzhyi updated the summary of D105642: Mark TensorDialect legal and PadTensor op illegal.
Jul 8 2021, 12:14 PM · Restricted Project
cathyzhyi updated the diff for D105642: Mark TensorDialect legal and PadTensor op illegal.

Add an integration test for dynamic shape case when testing padtensor
lowering. Add comments to be more descriptive.

Jul 8 2021, 12:12 PM · Restricted Project
cathyzhyi added a comment to D105642: Mark TensorDialect legal and PadTensor op illegal.

Do you know why previous tests didn't need this? Should we add a new test?

Jul 8 2021, 11:13 AM · Restricted Project
cathyzhyi requested review of D105642: Mark TensorDialect legal and PadTensor op illegal.
Jul 8 2021, 10:39 AM · Restricted Project

Jul 2 2021

cathyzhyi updated the diff for D105293: Refactor GenericPadTensorOpVectorizationPattern.

delete redundant comments as suggested

Jul 2 2021, 7:38 PM · Restricted Project
cathyzhyi updated the diff for D105293: Refactor GenericPadTensorOpVectorizationPattern.

move the new pattern's source code next to PadTensorOpTransformationPattern for
consistency

Jul 2 2021, 1:39 PM · Restricted Project
cathyzhyi updated the diff for D105293: Refactor GenericPadTensorOpVectorizationPattern.

add the pattern into linalg bufferization pass

Jul 2 2021, 12:26 PM · Restricted Project
cathyzhyi added a comment to D105293: Refactor GenericPadTensorOpVectorizationPattern.

@silvas @nicolasvasilache @springerm Any suggestion on which pass to put this pattern in? There is a LinalgGeneralizationPass which currently only applies to patterns lowering to Linalg.generic.

Jul 2 2021, 11:45 AM · Restricted Project
cathyzhyi updated the diff for D105293: Refactor GenericPadTensorOpVectorizationPattern.

update comments that's no longer relevant.

Jul 2 2021, 11:28 AM · Restricted Project
cathyzhyi updated the diff for D105293: Refactor GenericPadTensorOpVectorizationPattern.

refactor and reuse existing code as suggested.

Jul 2 2021, 11:18 AM · Restricted Project

Jul 1 2021

cathyzhyi added a comment to D105293: Refactor GenericPadTensorOpVectorizationPattern.

@nicolasvasilache seems with the rewrite pattern version the integration test passed but there are some failures in the unit test. Will need to take a closer look tmr. Here is the unit test.

func @pad_tensor(%arg0: tensor<4x?x2x?xf32>, %arg1: index) -> tensor<4x?x?x?xf32> {
  %cst = constant 0.0 : f32
  %out = linalg.pad_tensor %arg0 low[0, 0, %arg1, 0] high[0, 0, 0, %arg1]  {
  ^bb0(%gen_arg1: index, %gen_arg2: index, %gen_arg3: index, %gen_arg4: index):  // no predecessors
    linalg.yield %cst : f32
  } : tensor<4x?x2x?xf32> to tensor<4x?x?x?xf32>
  return %out : tensor<4x?x?x?xf32>
}
Jul 1 2021, 7:18 PM · Restricted Project
cathyzhyi updated the diff for D105293: Refactor GenericPadTensorOpVectorizationPattern.

use rewrite pattern instead

Jul 1 2021, 7:13 PM · Restricted Project
cathyzhyi added a comment to D105293: Refactor GenericPadTensorOpVectorizationPattern.

Note that I asked for a similar rewrite in https://reviews.llvm.org/D102804 but it was eventually not done.
I am wondering whether the pattern you add here should be more generally be the rewrite on tensors I mentioned and then just let existing bufferization kick in?

That makes sense to me!

Jul 1 2021, 2:17 PM · Restricted Project
cathyzhyi updated the diff for D105293: Refactor GenericPadTensorOpVectorizationPattern.

address comments

Jul 1 2021, 2:00 PM · Restricted Project
cathyzhyi updated the diff for D105293: Refactor GenericPadTensorOpVectorizationPattern.

remove redundant type check

Jul 1 2021, 9:53 AM · Restricted Project
cathyzhyi updated the diff for D105293: Refactor GenericPadTensorOpVectorizationPattern.

delete redundant comments

Jul 1 2021, 9:39 AM · Restricted Project
cathyzhyi requested review of D105293: Refactor GenericPadTensorOpVectorizationPattern.
Jul 1 2021, 9:35 AM · Restricted Project

Mar 22 2021

cathyzhyi abandoned D99047: Fix toy language example.

didn't see https://github.com/llvm/llvm-project/commit/113baa2b9fd3c8db30d33ecc3f068af48dcce52d. closing this one.

Mar 22 2021, 8:54 AM · Restricted Project

Mar 21 2021

cathyzhyi requested review of D99047: Fix toy language example.
Mar 21 2021, 5:58 PM · Restricted Project