[MLIR][Presburger][NFC] Rename getCompatibleSpace to getSpaceWithoutLocals

[arjunp]

Can you write a line explaining that these functions are primarily intended for use by the derived classes?(At least for getSpace)

[Groverkss]

In D122973#3424494, @arjunp wrote:

Can you write a line explaining that these functions are primarily intended for use by the derived classes?(At least for getSpace)

I don't think that is true. Do you mean "These functions are primarily intended to be used from derived classes?".

[arjunp]

In D122973#3424504, @Groverkss wrote:

In D122973#3424494, @arjunp wrote:

Can you write a line explaining that these functions are primarily intended for use by the derived classes?(At least for getSpace)

I don't think that is true. Do you mean "These functions are primarily intended to be used from derived classes?".

Yes, that's what I meant, sorry.

[Groverkss]

• Address Arjun's comments

mlir/include/mlir/Analysis/Presburger/PresburgerSpace.h

public:
 
   static PresburgerSpace getSetSpace(unsigned numDims = 0,
                                      unsigned numSymbols = 0,
                                      unsigned numLocals = 0) {
     return PresburgerSpace(/*numDomain=*/0, /*numRange=*/numDims, numSymbols,
                            numLocals);
   }
 
+  /// Returns the space. This function is primarily intended to be used from
+  /// derived classes.
   PresburgerSpace getSpace() const { return *this; }
-  PresburgerSpace getCompatibleSpace() const {
+
+  /// Returns the space without locals. This function is primarily intended to
+  /// be used from derived classes.
+  PresburgerSpace getSpaceWithoutLocals() const {
     return PresburgerSpace(numDomain, numRange, numSymbols);
   }
 
   virtual ~PresburgerSpace() = default;
 
   unsigned getNumDomainIds() const { return numDomain; }
   unsigned getNumRangeIds() const { return numRange; }
   unsigned getNumSetDimIds() const { return numRange; }

mlir/lib/Analysis/Presburger/PresburgerRelation.cpp

 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/ScopeExit.h"
 #include "llvm/ADT/SmallBitVector.h"
 
 using namespace mlir;
 using namespace presburger;
 
 PresburgerRelation::PresburgerRelation(const IntegerRelation &disjunct)
-    : PresburgerSpace(disjunct.getCompatibleSpace()) {
+    : PresburgerSpace(disjunct.getSpaceWithoutLocals()) {
   unionInPlace(disjunct);
 }
 
 unsigned PresburgerRelation::getNumDisjuncts() const {
   return disjuncts.size();
 }
 
 ArrayRef<IntegerRelation> PresburgerRelation::getAllDisjuncts() const {

 ///
 /// The disjunct here is modified in subtractRecursively, so it cannot be a
 /// const reference even though it is restored to its original state before
 /// returning from that function.
 static PresburgerRelation getSetDifference(IntegerRelation disjunct,
                                            const PresburgerRelation &set) {
   assert(disjunct.isSpaceCompatible(set) && "Spaces should match");
   if (disjunct.isEmptyByGCDTest())
-    return PresburgerRelation::getEmpty(disjunct.getCompatibleSpace());
+    return PresburgerRelation::getEmpty(disjunct.getSpaceWithoutLocals());
 
   // Remove duplicate divs up front here as subtractRecursively does not support
   // this set having duplicate divs.
   disjunct.removeDuplicateDivs();
 
   PresburgerRelation result =
-      PresburgerRelation::getEmpty(disjunct.getCompatibleSpace());
+      PresburgerRelation::getEmpty(disjunct.getSpaceWithoutLocals());
   Simplex simplex(disjunct);
   subtractRecursively(disjunct, simplex, set, 0, result);
   return result;
 }
 
 /// Return the complement of this set.
 PresburgerRelation PresburgerRelation::complement() const {
   return getSetDifference(IntegerRelation::getUniverse(getSpace()), *this);