This is an archive of the discontinued LLVM Phabricator instance.

Differential D122947

[cmake] Remove LLVM_USE_NEWPM option
ClosedPublic

Authored by aeubanks on Apr 1 2022, 4:42 PM.

Details

Reviewers
ctetreau
xur
MaskRay
phosek
Commits
rGbca96760f758: [cmake] Remove LLVM_USE_NEWPM option
Summary

This option tells the host clang to use the new pass manager.
Given that it's been the default for a while, this seems unnecessary.

This was added in D57068.

(this does not affect any LLVM/Clang functionality)

Diff Detail

Event Timeline

aeubanks created this revision.Apr 1 2022, 4:42 PM
Herald added a reviewer: ctetreau. · View Herald TranscriptApr 1 2022, 4:42 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: mgorny. · View Herald Transcript
aeubanks requested review of this revision.Apr 1 2022, 4:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2022, 4:42 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks added reviewers: xur, MaskRay.Apr 1 2022, 4:42 PM
Herald added a subscriber: StephenFan. · View Herald TranscriptApr 1 2022, 4:42 PM
aeubanks edited the summary of this revision. (Show Details)Apr 1 2022, 4:43 PM
aeubanks added a reviewer: phosek.
MaskRay accepted this revision.Apr 1 2022, 5:03 PM

LGTM. Users should just specify LLVM_ENABLE_NEW_PASS_MANAGER.

This revision is now accepted and ready to land.Apr 1 2022, 5:03 PM
Harbormaster completed remote builds in B157525: Diff 419890.Apr 1 2022, 7:46 PM
This revision was landed with ongoing or failed builds.Apr 1 2022, 8:25 PM
Closed by commit rGbca96760f758: [cmake] Remove LLVM_USE_NEWPM option (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rGbca96760f758: [cmake] Remove LLVM_USE_NEWPM option.

Revision Contents

PathSize
llvm/
cmake/
modules/
10 lines
docs/
3 lines

Diff 419924

llvm/cmake/modules/HandleLLVMOptions.cmake

Show First 20 Lines • Show All 968 Lines • ▼ Show 20 Lines
# Provide public options to globally control RTTI and EH # Provide public options to globally control RTTI and EH
option(LLVM_ENABLE_EH "Enable Exception handling" OFF) option(LLVM_ENABLE_EH "Enable Exception handling" OFF)
option(LLVM_ENABLE_RTTI "Enable run time type information" OFF) option(LLVM_ENABLE_RTTI "Enable run time type information" OFF)
if(LLVM_ENABLE_EH AND NOT LLVM_ENABLE_RTTI) if(LLVM_ENABLE_EH AND NOT LLVM_ENABLE_RTTI)
message(FATAL_ERROR "Exception handling requires RTTI. You must set LLVM_ENABLE_RTTI to ON") message(FATAL_ERROR "Exception handling requires RTTI. You must set LLVM_ENABLE_RTTI to ON")
endif() endif()
option(LLVM_USE_NEWPM "Build LLVM using the experimental new pass manager" Off)
mark_as_advanced(LLVM_USE_NEWPM)
if (LLVM_USE_NEWPM)
append("-fexperimental-new-pass-manager"
CMAKE_CXX_FLAGS
CMAKE_C_FLAGS
CMAKE_EXE_LINKER_FLAGS
CMAKE_SHARED_LINKER_FLAGS)
endif()
option(LLVM_ENABLE_IR_PGO "Build LLVM and tools with IR PGO instrumentation (deprecated)" Off) option(LLVM_ENABLE_IR_PGO "Build LLVM and tools with IR PGO instrumentation (deprecated)" Off)
mark_as_advanced(LLVM_ENABLE_IR_PGO) mark_as_advanced(LLVM_ENABLE_IR_PGO)
set(LLVM_BUILD_INSTRUMENTED OFF CACHE STRING "Build LLVM and tools with PGO instrumentation. May be specified as IR or Frontend") set(LLVM_BUILD_INSTRUMENTED OFF CACHE STRING "Build LLVM and tools with PGO instrumentation. May be specified as IR or Frontend")
set(LLVM_VP_COUNTERS_PER_SITE "1.5" CACHE STRING "Value profile counters to use per site for IR PGO with Clang") set(LLVM_VP_COUNTERS_PER_SITE "1.5" CACHE STRING "Value profile counters to use per site for IR PGO with Clang")
mark_as_advanced(LLVM_BUILD_INSTRUMENTED LLVM_VP_COUNTERS_PER_SITE) mark_as_advanced(LLVM_BUILD_INSTRUMENTED LLVM_VP_COUNTERS_PER_SITE)
string(TOUPPER "${LLVM_BUILD_INSTRUMENTED}" uppercase_LLVM_BUILD_INSTRUMENTED) string(TOUPPER "${LLVM_BUILD_INSTRUMENTED}" uppercase_LLVM_BUILD_INSTRUMENTED)
▲ Show 20 Lines • Show All 250 Lines • Show Last 20 Lines

llvm/docs/CMake.rst

Show First 20 Lines • Show All 732 Lines • ▼ Show 20 Lines
**LLVM_USE_LINKER**:STRING **LLVM_USE_LINKER**:STRING
Add ``-fuse-ld={name}`` to the link invocation. The possible value depend on Add ``-fuse-ld={name}`` to the link invocation. The possible value depend on
your compiler, for clang the value can be an absolute path to your custom your compiler, for clang the value can be an absolute path to your custom
linker, otherwise clang will prefix the name with ``ld.`` and apply its usual linker, otherwise clang will prefix the name with ``ld.`` and apply its usual
search. For example to link LLVM with the Gold linker, cmake can be invoked search. For example to link LLVM with the Gold linker, cmake can be invoked
with ``-DLLVM_USE_LINKER=gold``. with ``-DLLVM_USE_LINKER=gold``.
**LLVM_USE_NEWPM**:BOOL
If enabled, use the experimental new pass manager.
**LLVM_USE_OPROFILE**:BOOL **LLVM_USE_OPROFILE**:BOOL
Enable building OProfile JIT support. Defaults to OFF. Enable building OProfile JIT support. Defaults to OFF.
**LLVM_USE_PERF**:BOOL **LLVM_USE_PERF**:BOOL
Enable building support for Perf (linux profiling tool) JIT support. Defaults to OFF. Enable building support for Perf (linux profiling tool) JIT support. Defaults to OFF.
**LLVM_USE_RELATIVE_PATHS_IN_FILES**:BOOL **LLVM_USE_RELATIVE_PATHS_IN_FILES**:BOOL
Rewrite absolute source paths in sources and debug info to relative ones. The Rewrite absolute source paths in sources and debug info to relative ones. The
▲ Show 20 Lines • Show All 301 Lines • Show Last 20 Lines