[mlir][OpenMP] Fix memory leak by deleting unused value

[shraiysh]

Using eraseFromParent instead of deleteValue.

[rriddle]

mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp

1221–1222

Can you also sink this variable into the if? It isn't used anywhere else.

mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp

auto updateFn = [&](llvm::Value *atomicx,
     }
     omp::YieldOp yieldop = dyn_cast<omp::YieldOp>(bb.getTerminator());
     assert(yieldop && yieldop.results().size() == 1 &&
            "terminator must be omp.yield op and it must have exactly one "
            "argument");
     return moduleTranslation.lookupValue(yieldop.results()[0]);
   };
   // Handle ambiguous alloca, if any.
   auto allocaIP = findAllocaInsertPoint(builder, moduleTranslation);
-  llvm::UnreachableInst *unreachableInst;
   if (allocaIP.getPoint() == ompLoc.IP.getPoint()) {
     // Same point => split basic block and make them unambigous.
-    unreachableInst = builder.CreateUnreachable();
+    llvm::UnreachableInst *unreachableInst = builder.CreateUnreachable();
     builder.SetInsertPoint(builder.GetInsertBlock()->splitBasicBlock(
         unreachableInst, "alloca_split"));
     ompLoc.IP = builder.saveIP();
-    unreachableInst->removeFromParent();
+    unreachableInst->eraseFromParent();
   }
   builder.restoreIP(ompBuilder->createAtomicCapture(
       ompLoc, findAllocaInsertPoint(builder, moduleTranslation), llvmAtomicX,
       llvmAtomicV, llvmExpr, atomicOrdering, binop, updateFn, atomicUpdateOp,
       isPostfixUpdate, isXBinopExpr));
   return updateGenStatus;
 }