Page MenuHomePhabricator

[mlir][OpenMP] Fix memory leak by deleting unused value
ClosedPublic

Authored by shraiysh on Mar 28 2022, 10:09 PM.

Diff Detail

Event Timeline

shraiysh created this revision.Mar 28 2022, 10:09 PM
Herald added a project: Restricted Project. · View Herald Transcript
shraiysh requested review of this revision.Mar 28 2022, 10:09 PM
shraiysh updated this revision to Diff 418792.Mar 28 2022, 10:51 PM

Using eraseFromParent instead of deleteValue.

ftynse accepted this revision.Mar 29 2022, 1:26 AM
This revision is now accepted and ready to land.Mar 29 2022, 1:26 AM
rriddle accepted this revision.Mar 29 2022, 7:59 AM
rriddle added inline comments.
mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
1221–1222

Can you also sink this variable into the if? It isn't used anywhere else.

This revision was landed with ongoing or failed builds.Mar 29 2022, 2:56 PM
This revision was automatically updated to reflect the committed changes.