This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][test] Fix AArch64 cross-platform tests
ClosedPublic

Authored by maksfb on Mar 25 2022, 7:11 PM.

Details

Summary

Use target-specific flags for building AArch64 non-runnable tests.

Diff Detail

Event Timeline

maksfb created this revision.Mar 25 2022, 7:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 7:11 PM
maksfb requested review of this revision.Mar 25 2022, 7:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 7:11 PM
yota9 added a comment.Mar 26 2022, 6:27 AM

Overall LGTM, but the same changes must be applied to x86 folder of course

bolt/test/AArch64/double_jump.cpp
55

Although it will probably built, but I sugget _start here

yota9 added a comment.Mar 26 2022, 6:33 AM

BTW we may want to use -Wl,--unresolved-symbols=ignore-all option to minimize the test changes and overcome problem with stdlib/starfiles. It might be more problematic to change all x86 test to use these flags

maksfb updated this revision to Diff 418427.Mar 26 2022, 4:10 PM

Address feedback.

maksfb marked an inline comment as done.Mar 26 2022, 4:15 PM

Overall LGTM, but the same changes must be applied to x86 folder of course

Yes, this one is AArch64-only.

yota9 accepted this revision.Mar 27 2022, 12:19 PM

LGTM Thank you!

This revision is now accepted and ready to land.Mar 27 2022, 12:19 PM
maksfb updated this revision to Diff 419894.Apr 1 2022, 5:02 PM

Rebase.

This revision was automatically updated to reflect the committed changes.