This is an archive of the discontinued LLVM Phabricator instance.

Differential D122449

[X86][test] Add encoding/decoding tests for VEX instruction w/ address-size prefix
ClosedPublic

Authored by skan on Mar 24 2022, 7:01 PM.

Details

Reviewers
craig.topper
hvdijk
pengfei
RKSimon
Commits
rGfcade8e91eae: [X86][test] Add encoding/decoding tests for VEX instruction w/ address-size…
Summary

This patch also contains a regression test for D122448

Diff Detail

Event Timeline

skan created this revision.Mar 24 2022, 7:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2022, 7:01 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
skan requested review of this revision.Mar 24 2022, 7:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2022, 7:01 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B156194: Diff 418106.Mar 24 2022, 8:04 PM
hvdijk mentioned this in D122540: [X86] Fix handling of maskmovdqu in x32 differently.Mar 26 2022, 10:26 PM
RKSimon added a subscriber: RKSimon.Mar 30 2022, 2:48 AM
RKSimon added inline comments.
llvm/test/MC/Disassembler/X86/x86-64-avx.txt
10

I realise vphsubd isn't but these should be sorted in alpha order, so move vpsubq to the bottom

RKSimon mentioned this in rG4a33b9ece076: [MC][X86] Ensure all opcode tests are sorted by instruction name.Mar 30 2022, 3:08 AM
skan added a reviewer: RKSimon.Mar 30 2022, 6:52 PM
skan updated this revision to Diff 419311.Mar 30 2022, 7:12 PM
skan marked an inline comment as done.

move vpsubq to the bottom in disasm test

RKSimon accepted this revision.Mar 31 2022, 1:49 AM

LGTM

This revision is now accepted and ready to land.Mar 31 2022, 1:49 AM
Harbormaster completed remote builds in B157085: Diff 419311.Mar 31 2022, 6:26 AM
hvdijk mentioned this in rG3337f50625a3: [X86] Fix handling of maskmovdqu in x32 differently.Apr 12 2022, 10:32 AM
hvdijk accepted this revision.Apr 12 2022, 10:34 AM

I've pushed D122540, would you like me to push this as well or would you rather do that yourself?

skan added a comment.Apr 12 2022, 9:48 PM
In D122449#3446215, @hvdijk wrote:

I've pushed D122540, would you like me to push this as well or would you rather do that yourself?

Thanks for the inform. I can do it myself.

This revision was landed with ongoing or failed builds.Apr 12 2022, 9:50 PM
Closed by commit rGfcade8e91eae: [X86][test] Add encoding/decoding tests for VEX instruction w/ address-size… (authored by skan). · Explain Why
This revision was automatically updated to reflect the committed changes.
skan added a commit: rGfcade8e91eae: [X86][test] Add encoding/decoding tests for VEX instruction w/ address-size….

Revision Contents

PathSize
llvm/
test/
MC/
Disassembler/
X86/
3 lines
X86/
4 lines

Diff 422395

llvm/test/MC/Disassembler/X86/x86-64-avx.txt

# RUN: llvm-mc --disassemble %s -triple=x86_64-apple-darwin9 | FileCheck %s # RUN: llvm-mc --disassemble %s -triple=x86_64-apple-darwin9 | FileCheck %s
# CHECK: vpackusdw (%rax), %xmm2, %xmm1 # CHECK: vpackusdw (%rax), %xmm2, %xmm1
0xc4 0xe2 0x69 0x2b 0x08 0xc4 0xe2 0x69 0x2b 0x08
# CHECK: vpackusdw (%rax), %xmm2, %xmm1 # CHECK: vpackusdw (%rax), %xmm2, %xmm1
0xc4 0xe2 0xe9 0x2b 0x08 0xc4 0xe2 0xe9 0x2b 0x08
# CHECK: vpcmpestri $100, %xmm3, %xmm11 # CHECK: vpcmpestri $100, %xmm3, %xmm11
0xc4 0x63 0x79 0x61 0xdb 0x64 0xc4 0x63 0x79 0x61 0xdb 0x64
RKSimonUnsubmitted
Done
ReplyInline Actions

I realise vphsubd isn't but these should be sorted in alpha order, so move vpsubq to the bottom

RKSimon: I realise vphsubd isn't but these should be sorted in alpha order, so move vpsubq to the bottom
# CHECK: vpcmpestri $100, %xmm3, %xmm11 # CHECK: vpcmpestri $100, %xmm3, %xmm11
0xc4 0x63 0xf9 0x61 0xdb 0x64 0xc4 0x63 0xf9 0x61 0xdb 0x64
# CHECK: vpcmpestrm $100, %xmm3, %xmm11 # CHECK: vpcmpestrm $100, %xmm3, %xmm11
0xc4 0x63 0x79 0x60 0xdb 0x64 0xc4 0x63 0x79 0x60 0xdb 0x64
# CHECK: vpcmpestrm $100, %xmm3, %xmm11 # CHECK: vpcmpestrm $100, %xmm3, %xmm11
Show All 11 Lines
# CHECK: vpcmpistrm $100, %xmm3, %xmm11 # CHECK: vpcmpistrm $100, %xmm3, %xmm11
0xc4 0x63 0xf9 0x62 0xdb 0x64 0xc4 0x63 0xf9 0x62 0xdb 0x64
# CHECK: vphsubd %xmm3, %xmm2, %xmm11 # CHECK: vphsubd %xmm3, %xmm2, %xmm11
0xc4 0x62 0x69 0x06 0xdb 0xc4 0x62 0x69 0x06 0xdb
# CHECK: vphsubd %xmm3, %xmm2, %xmm11 # CHECK: vphsubd %xmm3, %xmm2, %xmm11
0xc4 0x62 0xe9 0x06 0xdb 0xc4 0x62 0xe9 0x06 0xdb
# CHECK: vpsubq (%esp), %xmm1, %xmm2
0x67 0xc5 0xf1 0xfb 0x14 0x24

llvm/test/MC/X86/x86_64-avx-encoding.s

Show First 20 Lines • Show All 1,690 Lines • ▼ Show 20 Lines
// CHECK: vpsubq %xmm11, %xmm12, %xmm13 // CHECK: vpsubq %xmm11, %xmm12, %xmm13
// CHECK: encoding: [0xc4,0x41,0x19,0xfb,0xeb] // CHECK: encoding: [0xc4,0x41,0x19,0xfb,0xeb]
vpsubq %xmm11, %xmm12, %xmm13 vpsubq %xmm11, %xmm12, %xmm13
// CHECK: vpsubq (%rax), %xmm12, %xmm13 // CHECK: vpsubq (%rax), %xmm12, %xmm13
// CHECK: encoding: [0xc5,0x19,0xfb,0x28] // CHECK: encoding: [0xc5,0x19,0xfb,0x28]
vpsubq (%rax), %xmm12, %xmm13 vpsubq (%rax), %xmm12, %xmm13
// CHECK: vpsubq (%esp), %xmm1, %xmm2
// CHECK: encoding: [0x67,0xc5,0xf1,0xfb,0x14,0x24]
vpsubq (%esp), %xmm1, %xmm2
// CHECK: vpsubsb %xmm11, %xmm12, %xmm13 // CHECK: vpsubsb %xmm11, %xmm12, %xmm13
// CHECK: encoding: [0xc4,0x41,0x19,0xe8,0xeb] // CHECK: encoding: [0xc4,0x41,0x19,0xe8,0xeb]
vpsubsb %xmm11, %xmm12, %xmm13 vpsubsb %xmm11, %xmm12, %xmm13
// CHECK: vpsubsb (%rax), %xmm12, %xmm13 // CHECK: vpsubsb (%rax), %xmm12, %xmm13
// CHECK: encoding: [0xc5,0x19,0xe8,0x28] // CHECK: encoding: [0xc5,0x19,0xe8,0x28]
vpsubsb (%rax), %xmm12, %xmm13 vpsubsb (%rax), %xmm12, %xmm13
▲ Show 20 Lines • Show All 2,703 Lines • Show Last 20 Lines