This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Allow v_accvgpr_write to use SGPR on gfx90a
ClosedPublic

Authored by rampitec on Mar 22 2022, 12:12 PM.

Details

Summary

This is undocumented, but it should work.

Diff Detail

Event Timeline

rampitec created this revision.Mar 22 2022, 12:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 12:12 PM
rampitec requested review of this revision.Mar 22 2022, 12:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 12:12 PM
Herald added a subscriber: wdng. · View Herald Transcript

Can you add the testcase where this was failing to compile from introduced S->A copies?

Can you add the testcase where this was failing to compile from introduced S->A copies?

I do not have this testcase. Maybe @cdevadas has?

Can you add the testcase where this was failing to compile from introduced S->A copies?

I do not have this testcase. Maybe @cdevadas has?

I think @hsmhsm had one

rampitec updated this revision to Diff 417374.Mar 22 2022, 12:58 PM

Rebased to the upstreamed gfx940 llvm.amdgcn.mfma.ll test.

arsenm accepted this revision.Mar 22 2022, 1:30 PM
This revision is now accepted and ready to land.Mar 22 2022, 1:30 PM
This revision was landed with ongoing or failed builds.Mar 22 2022, 1:52 PM
This revision was automatically updated to reflect the committed changes.