[libc++][ranges] Implement ranges::max

[Mordante]

In general looks good, but several small issues.

libcxx/include/__algorithm/ranges_max.h

51

I don't like the name __comp2 has no meaning. How about __comp_lhs_rhs_swapped.
That name give a hint what's about to happen and it makes easier to understand why __min_element_impl is used.

51

Why are you using auto&& without std::forward?

libcxx/test/std/algorithms/alg.sorting/alg.min.max/ranges.max.pass.cpp

38

There are other occurrences of Min in this file.

91

IMO This is clearer.

97

I'm not convinced this is valid. Taking the address of one beyond i when i isn't an array.
Are you sure this is valid? If not we should fix this also in the original min test.

libcxx/test/std/algorithms/alg.sorting/alg.min.max/ranges.min.pass.cpp

12

I noticed this line on other files too, it will be removed in D122099

[philnik]

• Address comments

[philnik]

libcxx/include/__algorithm/ranges_max.h

51

It's not 100% clear to me if cv qualifications have to stay. I'm pretty sure that __comp has to be callable with lvalues. If cv-qualifications don't have to be kept, the I can use const auto&.

libcxx/test/std/algorithms/alg.sorting/alg.min.max/ranges.max.pass.cpp

97

https://compiler-explorer.com/z/rTTce8YKh At least clang and MSVC only complain if I try to get a two-past-the-end pointer. GCC doesn't complain for some reason.

[Mordante]

libcxx/include/__algorithm/ranges_max.h

51

I'm also not 100% sure I know that ranges does some "interesting" things with &&. Maybe @var-const or @ldionne knows for sure.

libcxx/test/std/algorithms/alg.sorting/alg.min.max/ranges.max.pass.cpp

97

Based on [expr.add].4 (http://eel.is/c++draft/expr.add#4), my conclusion is that 4.3 applies and the behaviour is undefined.
But it's odd that Clang and MSVC accept it. Still I'm not convinced it's not a compiler bug since GCC accepts every value, including 42 and -42.
(Changing int i; to int i[1]; makes the code valid.

[var-const]

libcxx/docs/Status/RangesAlgorithms.csv

19

Nit: can you add a link to this patch as well?

libcxx/include/__algorithm/ranges_max.h

51

Very optional nit: personally, I usually prefer to separate any initial error handling from the main body of the function by a blank line (so in this case, I would add a blank line after the assertion). However, it's really a personal preference thing, so feel free to ignore if you don't feel it makes a difference.

51

Do we have tests to make sure a comparator that takes the argument by lvalue works? (if not, please add them)

I think ranges often use forwarding references simply to avoid providing several overloads for different types of references (sort of similar in spirit to how the "take-by-value-and-move" idiom allows not writing two overloads for rvalue and const lvalue). This seems to apply here, but @ldionne would know better.

52

I think there's an important nuance in how equivalent elements are handled. IIUC, min_element returns the rightmost of equivalent elements, whereas max needs to return the leftmost -- therefore, with the arguments swapped, we will get the correct behavior for max. Can you please add a comment to that effect (assuming my reasoning is correct)?

68

Nit: move __first and __last?

libcxx/test/std/algorithms/alg.sorting/alg.min.max/ranges.max.pass.cpp

97

+1 for using int i[1], which is clearly valid and adds very little boilerplate.

215–216

Hmm, I don't see the equivalent test for the initializer_list overload, but perhaps I'm just not seeing it?

[philnik]

• Address comments

libcxx/include/__algorithm/ranges_max.h

51

I think the && part is only interesting for returning ranges::dangling. A comparator that only takes the arguments by lvalue isn't allowed. See std::indirect_strict_weak_order for details.

52

Both should return the leftmost element. I'm not sure how you got to the rightmost element by swapping the arguments. Did you think of less-or-equal maybe?

[var-const]

libcxx/include/__algorithm/ranges_max.h

52

Never mind, I misread that.

[philnik]

• Fix modules build

[Mordante]

LGTM!

[ldionne]

libcxx/include/__algorithm/ranges_max_element.h

39

I just stumbled upon this, but this is not ADL-safe. Can you please fix and add a test? It is probably worth checking in other algorithms too if there is the same problem, while we're at it.

libcxx/docs/Status/RangesAlgorithms.csv

 Category,Algorithm,Assignee,CL,Complete
 Search,any_of,Christopher Di Bella,`D105793 <https://llvm.org/D105793>`_
 Search,all_of,Christopher Di Bella,`D105793 <https://llvm.org/D105793>`_
 Search,none_of,Christopher Di Bella,`D105793 <https://llvm.org/D105793>`_
 Search,find,Nikolas Klauser,`D121248 <https://reviews.llvm.org/D121248>`_,✅
 Search,find_if,Nikolas Klauser,`D121248 <https://reviews.llvm.org/D121248>`_,✅
 Search,find_if_not,Nikolas Klauser,`D121248 <https://reviews.llvm.org/D121248>`_,✅
 Search,find_first_of,Not assigned,n/a,Not started
 Search,adjacent_find,Not assigned,n/a,Not started
-Search,mismatch,Nikolas Klauser,`D117817 <https://llvm.org/D117817>`,Complete
+Search,mismatch,Nikolas Klauser,`D117817 <https://llvm.org/D117817>`_,✅
 Search,equal,Not assigned,n/a,Not started
 Search,lexicographical_compare,Not assigned,n/a,Not started
 Search,partition_point,Christopher Di Bella,`D105794 <https://llvm.org/D105794>`_,Under review
 Search,lower_bound,Christopher Di Bella,`D105795 <https://llvm.org/D105795>`_,Under review
 Search,upper_bound,Christopher Di Bella,`D105795 <https://llvm.org/D105795>`_,Under review
 Search,equal_range,Christopher Di Bella,n/a,Not started
 Search,binary_search,Christopher Di Bella,n/a,Not started
 Search,min,Nikolas Klauser,`D119589 <https://llvm.org/D119589>`_,✅
-Search,max,Not assigned,n/a,Not started
+Search,max,Nikolas Klauser,n/a,✅
 Search,minmax,Not assigned,n/a,Not started
 Search,min_element,Nikolas Klauser,`D117025 <https://llvm.org/D117025>`_,✅
 Search,max_element,Nikolas Klauser,`D117523 <https://llvm.org/D117523>`_,✅
 Search,minmax_element,Not assigned,n/a,Not started
 Search,count,Not assigned,n/a,Not started
 Search,count_if,Not assigned,n/a,Not started
 Search,search,Not assigned,n/a,Not started
 Search,search_n,Not assigned,n/a,Not started

libcxx/include/CMakeLists.txt

set(files
   __algorithm/partition_copy.h
   __algorithm/partition_point.h
   __algorithm/pop_heap.h
   __algorithm/prev_permutation.h
   __algorithm/push_heap.h
   __algorithm/ranges_find.h
   __algorithm/ranges_find_if.h
   __algorithm/ranges_find_if_not.h
+  __algorithm/ranges_max.h
   __algorithm/ranges_max_element.h
   __algorithm/ranges_min.h
   __algorithm/ranges_min_element.h
   __algorithm/ranges_mismatch.h
   __algorithm/ranges_swap_ranges.h
   __algorithm/remove.h
   __algorithm/remove_copy.h
   __algorithm/remove_copy_if.h

libcxx/include/__algorithm/ranges_max.h

+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef _LIBCPP___ALGORITHM_RANGES_MAX_H
+#define _LIBCPP___ALGORITHM_RANGES_MAX_H
+
+#include <__algorithm/ranges_min_element.h>
+#include <__assert>
+#include <__concepts/copyable.h>
+#include <__config>
+#include <__functional/identity.h>
+#include <__functional/invoke.h>
+#include <__functional/ranges_operations.h>
+#include <__iterator/concepts.h>
+#include <__iterator/projected.h>
+#include <__ranges/access.h>
+#include <__ranges/concepts.h>
+#include <initializer_list>
+
+#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
+#  pragma GCC system_header
+#endif
+
+#if _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES)
+
+_LIBCPP_PUSH_MACROS
+#include <__undef_macros>
+
+_LIBCPP_BEGIN_NAMESPACE_STD
+
+namespace ranges {
+namespace __max {
+struct __fn {
+  template <class _Tp, class _Proj = identity,
+            indirect_strict_weak_order<projected<const _Tp*, _Proj>> _Comp = ranges::less>
+  _LIBCPP_HIDE_FROM_ABI constexpr
+  const _Tp& operator()(const _Tp& __a, const _Tp& __b, _Comp __comp = {}, _Proj __proj = {}) const {
+    return std::invoke(__comp, std::invoke(__proj, __a), std::invoke(__proj, __b)) ? __b : __a;
+  }
+
+  template <copyable _Tp, class _Proj = identity,
+            indirect_strict_weak_order<projected<const _Tp*, _Proj>> _Comp = ranges::less>
+  _LIBCPP_HIDE_FROM_ABI constexpr
+  _Tp operator()(initializer_list<_Tp> __il, _Comp __comp = {}, _Proj __proj = {}) const {
+    _LIBCPP_ASSERT(__il.begin() != __il.end(), "initializer_list must contain at least one element");
+    auto __comp2 = [&](auto&& __lhs, auto&& __rhs) { return std::invoke(__comp, __rhs, __lhs); };
+    return *ranges::__min_element_impl(__il.begin(), __il.end(), __comp2, __proj);
+  }
+
+  template <input_range _Rp, class _Proj = identity,
+            indirect_strict_weak_order<projected<iterator_t<_Rp>, _Proj>> _Comp = ranges::less>
+    requires indirectly_copyable_storable<iterator_t<_Rp>, range_value_t<_Rp>*>
+  _LIBCPP_HIDE_FROM_ABI constexpr
+  range_value_t<_Rp> operator()(_Rp&& __r, _Comp __comp = {}, _Proj __proj = {}) const {
+    auto __first = ranges::begin(__r);
+    auto __last = ranges::end(__r);
+
+    _LIBCPP_ASSERT(__first != __last, "range must contain at least one element");
+
+    if constexpr (forward_range<_Rp>) {
+      auto __comp2 = [&](auto&& __lhs, auto&& __rhs) { return std::invoke(__comp, __rhs, __lhs); };
+      return *ranges::__min_element_impl(__first, __last, __comp2, __proj);
+    } else {
+      range_value_t<_Rp> __result = *__first;
+      while (++__first != __last) {
+        if (std::invoke(__comp, std::invoke(__proj, __result), std::invoke(__proj, *__first)))
+          __result = *__first;
+      }
+      return __result;
+    }
+  }
+};
+} // namespace __max
+
+inline namespace __cpo {
+  inline constexpr auto max = __max::__fn{};
+} // namespace __cpo
+} // namespace ranges
+
+_LIBCPP_END_NAMESPACE_STD
+
+_LIBCPP_POP_MACROS
+
+#endif // _LIBCPP_STD_VER > 17 && && !defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES)
+
+#endif // _LIBCPP___ALGORITHM_RANGES_MAX_H

libcxx/include/__algorithm/ranges_max_element.h

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef _LIBCPP___ALGORITHM_RANGES_MAX_ELEMENT_H
 #define _LIBCPP___ALGORITHM_RANGES_MAX_ELEMENT_H
 
+#include <__algorithm/ranges_min_element.h>
 #include <__config>
 #include <__functional/identity.h>
 #include <__functional/invoke.h>
 #include <__functional/ranges_operations.h>
 #include <__iterator/concepts.h>
 #include <__iterator/projected.h>
 #include <__ranges/access.h>
 #include <__ranges/concepts.h>
 #include <__ranges/dangling.h>
 
 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
 #  pragma GCC system_header
 #endif
 
 #if _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES)
 
 _LIBCPP_BEGIN_NAMESPACE_STD
 
 namespace ranges {
 namespace __max_element {
 struct __fn {
-  template <class _Ip, class _Sp, class _Proj, class _Comp>
-  _LIBCPP_HIDE_FROM_ABI static constexpr
-  _Ip __go(_Ip __first, _Sp __last, _Comp& __comp, _Proj& __proj) {
-    if (__first == __last)
-      return __first;
-
-    _Ip __i = __first;
-    while (++__i != __last)
-      if (std::invoke(__comp, std::invoke(__proj, *__first), std::invoke(__proj, *__i)))
-        __first = __i;
-    return __first;
-  }
-
   template <forward_iterator _Ip, sentinel_for<_Ip> _Sp, class _Proj = identity,
             indirect_strict_weak_order<projected<_Ip, _Proj>> _Comp = ranges::less>
   _LIBCPP_HIDE_FROM_ABI constexpr
   _Ip operator()(_Ip __first, _Sp __last, _Comp __comp = {}, _Proj __proj = {}) const {
-    return __go(__first, __last, __comp, __proj);
+    auto __comp2 = [&](auto&& __lhs, auto&& __rhs) { return std::invoke(__comp, __rhs, __lhs); };
+    return __min_element_impl(__first, __last, __comp2, __proj);
   }
 
   template <forward_range _Rp, class _Proj = identity,
             indirect_strict_weak_order<projected<iterator_t<_Rp>, _Proj>> _Comp = ranges::less>
   _LIBCPP_HIDE_FROM_ABI constexpr
   borrowed_iterator_t<_Rp> operator()(_Rp&& __r, _Comp __comp = {}, _Proj __proj = {}) const {
-    return __go(ranges::begin(__r), ranges::end(__r), __comp, __proj);
+    auto __comp2 = [&](auto&& __lhs, auto&& __rhs) { return std::invoke(__comp, __rhs, __lhs); };
+    return __min_element_impl(ranges::begin(__r), ranges::end(__r), __comp2, __proj);
   }
 };
 } // namespace __max_element
 
 inline namespace __cpo {
   inline constexpr auto max_element = __max_element::__fn{};
 } // namespace __cpo
 } // namespace ranges
 
 _LIBCPP_END_NAMESPACE_STD
 
 #endif // _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES)
 
 #endif // _LIBCPP___ALGORITHM_RANGES_MAX_ELEMENT_H

libcxx/include/algorithm

template<input_iterator I, sentinel_for<I> S, class Proj = identity,
            indirect_unary_predicate<projected<I, Proj>> Pred>
     constexpr I find_if_not(I first, S last, Pred pred, Proj proj = {});            // since C++20
 
   template<input_range R, class Proj = identity,
            indirect_unary_predicate<projected<iterator_t<R>, Proj>> Pred>
     constexpr borrowed_iterator_t<R>
       find_if_not(R&& r, Pred pred, Proj proj = {});                                // since C++20
 
   template<class T, class Proj = identity,
            indirect_strict_weak_order<projected<const T*, Proj>> Comp = ranges::less>
-   constexpr const T& min(const T& a, const T& b, Comp comp = {}, Proj proj = {});  // since C++20
+    constexpr const T& min(const T& a, const T& b, Comp comp = {}, Proj proj = {}); // since C++20
 
   template<copyable T, class Proj = identity,
            indirect_strict_weak_order<projected<const T*, Proj>> Comp = ranges::less>
-   constexpr T min(initializer_list<T> r, Comp comp = {}, Proj proj = {});          // since C++20
+    constexpr T min(initializer_list<T> r, Comp comp = {}, Proj proj = {});         // since C++20
 
  template<input_range R, class Proj = identity,
           indirect_strict_weak_order<projected<iterator_t<R>, Proj>> Comp = ranges::less>
    requires indirectly_copyable_storable<iterator_t<R>, range_value_t<R>*>
    constexpr range_value_t<R>
      min(R&& r, Comp comp = {}, Proj proj = {});                                    // since C++20
+
+  template<class T, class Proj = identity,
+           indirect_strict_weak_order<projected<const T*, Proj>> Comp = ranges::less>
+    constexpr const T& max(const T& a, const T& b, Comp comp = {}, Proj proj = {}); // since C++20
+
+  template<copyable T, class Proj = identity,
+           indirect_strict_weak_order<projected<const T*, Proj>> Comp = ranges::less>
+    constexpr T max(initializer_list<T> r, Comp comp = {}, Proj proj = {});         // since C++20
+
+  template<input_range R, class Proj = identity,
+           indirect_strict_weak_order<projected<iterator_t<R>, Proj>> Comp = ranges::less>
+    requires indirectly_copyable_storable<iterator_t<R>, range_value_t<R>*>
+    constexpr range_value_t<R>
+      max(R&& r, Comp comp = {}, Proj proj = {});                                   // since C++20
 }
 
     constexpr bool     // constexpr in C++20
     all_of(InputIterator first, InputIterator last, Predicate pred);
 
 template <class InputIterator, class Predicate>
     constexpr bool     // constexpr in C++20
     any_of(InputIterator first, InputIterator last, Predicate pred);

 #include <__algorithm/partition_copy.h>
 #include <__algorithm/partition_point.h>
 #include <__algorithm/pop_heap.h>
 #include <__algorithm/prev_permutation.h>
 #include <__algorithm/push_heap.h>
 #include <__algorithm/ranges_find.h>
 #include <__algorithm/ranges_find_if.h>
 #include <__algorithm/ranges_find_if_not.h>
+#include <__algorithm/ranges_max.h>
 #include <__algorithm/ranges_max_element.h>
 #include <__algorithm/ranges_min.h>
 #include <__algorithm/ranges_min_element.h>
 #include <__algorithm/ranges_mismatch.h>
 #include <__algorithm/ranges_swap_ranges.h>
 #include <__algorithm/remove.h>
 #include <__algorithm/remove_copy.h>
 #include <__algorithm/remove_copy_if.h>

libcxx/include/module.modulemap

module __algorithm {
       module partition_copy           { private header "__algorithm/partition_copy.h" }
       module partition_point          { private header "__algorithm/partition_point.h" }
       module pop_heap                 { private header "__algorithm/pop_heap.h" }
       module prev_permutation         { private header "__algorithm/prev_permutation.h" }
       module push_heap                { private header "__algorithm/push_heap.h" }
       module ranges_find              { private header "__algorithm/ranges_find.h" }
       module ranges_find_if           { private header "__algorithm/ranges_find_if.h" }
       module ranges_find_if_not       { private header "__algorithm/ranges_find_if_not.h" }
+      module ranges_max               { private header "__algorithm/ranges_max.h" }
       module ranges_max_element       { private header "__algorithm/ranges_max_element.h" }
       module ranges_min               { private header "__algorithm/ranges_min.h" }
       module ranges_min_element       { private header "__algorithm/ranges_min_element.h" }
       module ranges_mismatch          { private header "__algorithm/ranges_mismatch.h" }
       module ranges_swap_ranges       { private header "__algorithm/ranges_swap_ranges.h" }
       module remove                   { private header "__algorithm/remove.h" }
       module remove_copy              { private header "__algorithm/remove_copy.h" }
       module remove_copy_if           { private header "__algorithm/remove_copy_if.h" }

libcxx/test/libcxx/diagnostics/detail.headers/algorithm/ranges_max.module.verify.cpp

+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// REQUIRES: modules-build
+
+// WARNING: This test was generated by 'generate_private_header_tests.py'
+// and should not be edited manually.
+
+// expected-error@*:* {{use of private header from outside its module: '__algorithm/ranges_max.h'}}
+#include <__algorithm/ranges_max.h>

libcxx/test/std/algorithms/alg.sorting/alg.min.max/ranges.max.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // <algorithm>
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17
-// UNSUPPORTED: libcpp-no-concepts
 // UNSUPPORTED: libcpp-has-no-incomplete-ranges
 
 // template<class T, class Proj = identity,
 //          indirect_strict_weak_order<projected<const T*, Proj>> Comp = ranges::less>
-//   constexpr const T& ranges::min(const T& a, const T& b, Comp comp = {}, Proj proj = {});
+//   constexpr const T& ranges::max(const T& a, const T& b, Comp comp = {}, Proj proj = {});
+//
 // template<copyable T, class Proj = identity,
 //          indirect_strict_weak_order<projected<const T*, Proj>> Comp = ranges::less>
-//   constexpr T ranges::min(initializer_list<T> r, Comp comp = {}, Proj proj = {});
+//   constexpr T ranges::max(initializer_list<T> r, Comp comp = {}, Proj proj = {});
+//
 // template<input_range R, class Proj = identity,
 //          indirect_strict_weak_order<projected<iterator_t<R>, Proj>> Comp = ranges::less>
 //   requires indirectly_copyable_storable<iterator_t<R>, range_value_t<R>*>
 //   constexpr range_value_t<R>
-//     ranges::min(R&& r, Comp comp = {}, Proj proj = {});
+//     ranges::max(R&& r, Comp comp = {}, Proj proj = {});
 
 #include <algorithm>
 #include <array>
 #include <cassert>
 #include <ranges>
 
 #include "almost_satisfies_types.h"
 #include "test_iterators.h"
 #include "test_macros.h"
 
 template <class T>
-concept HasMinR = requires { std::ranges::min(std::declval<T>()); };
+concept HasMinR = requires { std::ranges::max(std::declval<T>()); };
 
 struct NoLessThanOp {};
 struct NotTotallyOrdered {
   int i;
   bool operator<(const NotTotallyOrdered& o) const { return i < o.i; }
 };
 
 struct Movable {

 static_assert(!HasMinR<std::initializer_list<Movable>>);
 static_assert(!HasMinR<InputRangeNotDerivedFrom>);
 static_assert(!HasMinR<InputRangeNotIndirectlyReadable>);
 static_assert(!HasMinR<InputRangeNotInputOrOutputIterator>);
 static_assert(!HasMinR<InputRangeNotSentinelSemiregular>);
 static_assert(!HasMinR<InputRangeNotSentinelEqualityComparableWith>);
 
 template <class T, class U = T>
-concept HasMin2 = requires { std::ranges::min(std::declval<T>(), std::declval<U>()); };
+concept HasMin2 = requires { std::ranges::max(std::declval<T>(), std::declval<U>()); };
 
 static_assert(HasMin2<int>);
 static_assert(!HasMin2<int, long>);
 
-static_assert(std::is_same_v<decltype(std::ranges::min(1, 2)), const int&>);
+static_assert(std::is_same_v<decltype(std::ranges::max(1, 2)), const int&>);
 
 constexpr void test_2_arguments() {
-  assert(std::ranges::min(1, 2) == 1);
-  assert(std::ranges::min(2, 1) == 1);
+  assert(std::ranges::max(1, 2) == 2);
+  assert(std::ranges::max(2, 1) == 2);
   // test comparator
-  assert(std::ranges::min(1, 2, std::ranges::greater{}) == 2);
+  assert(std::ranges::max(1, 2, std::ranges::greater{}) == 1);
   // test projection
-  assert(std::ranges::min(1, 2, std::ranges::less{}, [](int i){ return i == 1 ? 10 : i; }) == 2);
+  assert(std::ranges::max(1, 2, std::ranges::less{}, [](int i){ return i == 1 ? 10 : i; }) == 1);
 
   { // check that std::invoke is used
     struct S { int i; };
     S a[3] = { S{2}, S{1}, S{3} };
-    decltype(auto) ret = std::ranges::min(a[0], a[1], {}, &S::i);
+    decltype(auto) ret = std::ranges::max(a[0], a[1], {}, &S::i);
     ASSERT_SAME_TYPE(decltype(ret), const S&);
-    assert(&ret == &a[1]);
-    assert(ret.i == 1);
+    assert(&ret == a + 0);
+    assert(ret.i == 2);
   }
 
   { // check that pointers are compared and not a range
     int i;
     int* a[] = {&i, &i + 1};
-    auto ret = std::ranges::min(a[0], a[1]);
-    assert(ret == &i);
+    auto ret = std::ranges::max(a[0], a[1]);
+    assert(ret == &i + 1);
   }
 
   { // test predicate and projection count
     int compares = 0;
     int projections = 0;
     auto comparator = [&](int x, int y) {
       ++compares;
       return x < y;
     };
     auto projection = [&](int x) {
       ++projections;
       return x;
     };
-    auto ret = std::ranges::min(1, 2, comparator, projection);
-    assert(ret == 1);
+    auto ret = std::ranges::max(1, 2, comparator, projection);
+    assert(ret == 2);
     assert(compares == 1);
     assert(projections == 2);
   }
 
   { // check that the first argument is returned
     struct S { int check; int other; };
-    auto ret = std::ranges::min(S {0, 1}, S {0, 2}, {}, &S::check);
+    auto ret = std::ranges::max(S {0, 1}, S {0, 2}, {}, &S::check);
     assert(ret.other == 1);
   }
 }
 
 constexpr void test_initializer_list() {
-  {
-    // test projection
-    auto proj = [](int i) { return i == 5 ? -100 : i; };
-    int ret = std::ranges::min({7, 6, 9, 3, 5, 1, 2, 4}, std::ranges::less{}, proj);
+  { // test projection
+    auto proj = [](int i) { return i == 5 ? 100 : i; };
+    int ret = std::ranges::max({7, 6, 9, 3, 5, 1, 2, 4}, {}, proj);
     assert(ret == 5);
   }
 
-  {
-    // test comparator
-    int ret = std::ranges::min({7, 6, 9, 3, 5, 1, 2, 4}, std::ranges::greater{});
-    assert(ret == 9);
+  { // test comparator
+    int ret = std::ranges::max({7, 6, 9, 3, 5, 1, 2, 4}, std::ranges::greater{});
+    assert(ret == 1);
   }
 
-  {
+  { // check that complexity requirements are met
     int compares = 0;
     int projections = 0;
     auto comparator = [&](int a, int b) {
       ++compares;
       return a < b;
     };
     auto projection = [&](int a) {
       ++projections;
       return a;
     };
-    std::same_as<int> decltype(auto) ret = std::ranges::min({1, 2, 3}, comparator, projection);
-    assert(ret == 1);
+    std::same_as<int> decltype(auto) ret = std::ranges::max({1, 2, 3}, comparator, projection);
+    assert(ret == 3);
     assert(compares == 2);
     assert(projections == 4);
   }
 
-  {
+  { // check that std::invoke is used
     struct S { int i; };
-    decltype(auto) ret = std::ranges::min({ S{2}, S{1}, S{3} }, {}, &S::i);
-    ASSERT_SAME_TYPE(decltype(ret), S);
-    assert(ret.i == 1);
-  }
-
-  {
-    int a[] = {7, 6, 9, 3, 5, 1, 2, 4};
-    using It = cpp20_input_iterator<int*>;
-    using Sent = sentinel_wrapper<It>;
-    auto range = std::ranges::subrange(It(a), Sent(It(a + 8)));
-    auto ret = std::ranges::min(range);
-    assert(ret == 1);
+    std::same_as<S> decltype(auto) ret = std::ranges::max({ S{2}, S{1}, S{3} }, {}, &S::i);
+    assert(ret.i == 3);
   }
 }
 
 template <class It, class Sent = It>
 constexpr void test_range_types() {
   int a[] = {7, 6, 9, 3, 5, 1, 2, 4};
   auto range = std::ranges::subrange(It(a), Sent(It(a + 8)));
-  int ret = std::ranges::min(range);
-  assert(ret == 1);
+  int ret = std::ranges::max(range);
+  assert(ret == 9);
 }
 
 constexpr void test_range() {
   { // check that all range types work
     test_range_types<cpp20_input_iterator<int*>, sentinel_wrapper<cpp20_input_iterator<int*>>>();
     test_range_types<forward_iterator<int*>>();
     test_range_types<bidirectional_iterator<int*>>();
     test_range_types<random_access_iterator<int*>>();
     test_range_types<contiguous_iterator<int*>>();
   }
 
   int a[] = {7, 6, 9, 3, 5, 1, 2, 4};
-  {
-    // test projection
-    auto proj = [](int& i) { return i == 5 ? -100 : i; };
-    int ret = std::ranges::min(a, std::ranges::less{}, proj);
+  { // test projection
+    auto proj = [](int& i) { return i == 5 ? 100 : i; };
+    int ret = std::ranges::max(a, std::ranges::less{}, proj);
     assert(ret == 5);
   }
 
-  {
-    // test comparator
-    int ret = std::ranges::min(a, std::ranges::greater{});
-    assert(ret == 9);
+  { // test comparator
+    int ret = std::ranges::max(a, std::ranges::greater{});
+    assert(ret == 1);
   }
 
   { // check that predicate and projection call counts are correct
     int compares = 0;
     int projections = 0;
     auto comparator = [&](int x, int y) {
       ++compares;
       return x < y;
     };
     auto projection = [&](int x) {
       ++projections;
       return x;
     };
-    std::same_as<int> decltype(auto) ret = std::ranges::min(std::array{1, 2, 3}, comparator, projection);
-    assert(ret == 1);
+    std::same_as<int> decltype(auto) ret = std::ranges::max(std::array{1, 2, 3}, comparator, projection);
+    assert(ret == 3);
     assert(compares == 2);
     assert(projections == 4);
   }
 
   { // check that std::invoke is used
     struct S { int i; };
     S b[3] = { S{2}, S{1}, S{3} };
-    std::same_as<S> decltype(auto) ret = std::ranges::min(b, {}, &S::i);
-    assert(ret.i == 1);
+    std::same_as<S> decltype(auto) ret = std::ranges::max(b, {}, &S::i);
+    assert(ret.i == 3);
   }
 
-  { // check that the first smallest element is returned
-    { // where the first element is the smallest
+  { // check that the first largest element is returned
+    { // where the first element is the largest
       struct S { int check; int other; };
-      S b[] = { S{0, 1}, S{1, 2}, S{0, 3} };
-      auto ret = std::ranges::min(b, {}, &S::check);
-      assert(ret.check == 0);
+      S b[] = { S{1, 1}, S{0, 2}, S{1, 3} };
+      auto ret = std::ranges::max(b, {}, &S::check);
+      assert(ret.check == 1);
       assert(ret.other == 1);
     }
-    { // where the first element isn't the smallest
+    { // where the first element isn't the largest
       struct S { int check; int other; };
-      S b[] = { S{2, 1}, S{0, 2}, S{0, 3} };
-      auto ret = std::ranges::min(b, {}, &S::check);
-      assert(ret.check == 0);
+      S b[] = { S{0, 1}, S{1, 2}, S{1, 3} };
+      auto ret = std::ranges::max(b, {}, &S::check);
+      assert(ret.check == 1);
       assert(ret.other == 2);
     }
   }
 }
 
 constexpr bool test() {
   test_2_arguments();
   test_initializer_list();

libcxx/test/std/algorithms/alg.sorting/alg.min.max/ranges.min.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // <algorithm>
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17
-// UNSUPPORTED: libcpp-no-concepts
 // UNSUPPORTED: libcpp-has-no-incomplete-ranges
 
 // template<class T, class Proj = identity,
 //          indirect_strict_weak_order<projected<const T*, Proj>> Comp = ranges::less>
 //   constexpr const T& ranges::min(const T& a, const T& b, Comp comp = {}, Proj proj = {});
 // template<copyable T, class Proj = identity,
 //          indirect_strict_weak_order<projected<const T*, Proj>> Comp = ranges::less>
 //   constexpr T ranges::min(initializer_list<T> r, Comp comp = {}, Proj proj = {});