This is an archive of the discontinued LLVM Phabricator instance.

Differential D121986

[mlir][NFC] Remove redundant check.
AbandonedPublic

Authored by jacquesguan on Mar 18 2022, 2:05 AM.

Details

Reviewers
bondhugula
wsmoses
rriddle
mehdi_amini
ftynse

Diff Detail

Event Timeline

jacquesguan created this revision.Mar 18 2022, 2:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2022, 2:05 AM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 17 others. · View Herald Transcript
jacquesguan requested review of this revision.Mar 18 2022, 2:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2022, 2:05 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
jacquesguan mentioned this in D121980: [mlir][Math] Add constant folder for sqrt..Mar 18 2022, 2:08 AM
Harbormaster completed remote builds in B154998: Diff 416431.Mar 18 2022, 2:28 AM
ftynse requested changes to this revision.Mar 18 2022, 2:30 AM

It actually is not redundant. These operations can be used on vectors on tensors of floats, so the result type is not necessarily a FloatType and the folded attribute is not necessarily a FloatAttr.

This revision now requires changes to proceed.Mar 18 2022, 2:30 AM
jacquesguan abandoned this revision.Mar 20 2022, 6:53 PM

Revision Contents

PathSize
mlir/
lib/
Dialect/
Math/
IR/
10 lines

Diff 416431

mlir/lib/Dialect/Math/IR/MathOps.cpp

Show All 24 Lines
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
OpFoldResult math::CeilOp::fold(ArrayRef<Attribute> operands) { OpFoldResult math::CeilOp::fold(ArrayRef<Attribute> operands) {
auto constOperand = operands.front(); auto constOperand = operands.front();
if (!constOperand) if (!constOperand)
return {}; return {};
auto attr = constOperand.dyn_cast<FloatAttr>(); auto attr = constOperand.dyn_cast<FloatAttr>();
if (!attr)
return {};
APFloat sourceVal = attr.getValue(); APFloat sourceVal = attr.getValue();
sourceVal.roundToIntegral(llvm::RoundingMode::TowardPositive); sourceVal.roundToIntegral(llvm::RoundingMode::TowardPositive);
return FloatAttr::get(getType(), sourceVal); return FloatAttr::get(getType(), sourceVal);
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Log2Op folder // Log2Op folder
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
OpFoldResult math::Log2Op::fold(ArrayRef<Attribute> operands) { OpFoldResult math::Log2Op::fold(ArrayRef<Attribute> operands) {
auto constOperand = operands.front(); auto constOperand = operands.front();
if (!constOperand) if (!constOperand)
return {}; return {};
auto attr = constOperand.dyn_cast<FloatAttr>(); auto attr = constOperand.dyn_cast<FloatAttr>();
if (!attr)
return {};
auto ft = getType().cast<FloatType>(); auto ft = getType().cast<FloatType>();
APFloat apf = attr.getValue(); APFloat apf = attr.getValue();
if (apf.isNegative()) if (apf.isNegative())
return {}; return {};
if (ft.getWidth() == 64) if (ft.getWidth() == 64)
return FloatAttr::get(getType(), log2(apf.convertToDouble())); return FloatAttr::get(getType(), log2(apf.convertToDouble()));
if (ft.getWidth() == 32) if (ft.getWidth() == 32)
return FloatAttr::get(getType(), log2f(apf.convertToFloat())); return FloatAttr::get(getType(), log2f(apf.convertToFloat()));
return {}; return {};
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// PowFOp folder // PowFOp folder
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
OpFoldResult math::PowFOp::fold(ArrayRef<Attribute> operands) { OpFoldResult math::PowFOp::fold(ArrayRef<Attribute> operands) {
auto ft = getType().dyn_cast<FloatType>(); auto ft = getType().dyn_cast<FloatType>();
if (!ft)
return {};
APFloat vals[2]{APFloat(ft.getFloatSemantics()), APFloat vals[2]{APFloat(ft.getFloatSemantics()),
APFloat(ft.getFloatSemantics())}; APFloat(ft.getFloatSemantics())};
for (int i = 0; i < 2; ++i) { for (int i = 0; i < 2; ++i) {
if (!operands[i]) if (!operands[i])
return {}; return {};
auto attr = operands[i].dyn_cast<FloatAttr>(); auto attr = operands[i].dyn_cast<FloatAttr>();
if (!attr)
return {};
vals[i] = attr.getValue(); vals[i] = attr.getValue();
} }
if (ft.getWidth() == 64) if (ft.getWidth() == 64)
return FloatAttr::get( return FloatAttr::get(
getType(), pow(vals[0].convertToDouble(), vals[1].convertToDouble())); getType(), pow(vals[0].convertToDouble(), vals[1].convertToDouble()));
if (ft.getWidth() == 32) if (ft.getWidth() == 32)
return FloatAttr::get( return FloatAttr::get(
getType(), powf(vals[0].convertToFloat(), vals[1].convertToFloat())); getType(), powf(vals[0].convertToFloat(), vals[1].convertToFloat()));
return {}; return {};
} }
OpFoldResult math::SqrtOp::fold(ArrayRef<Attribute> operands) { OpFoldResult math::SqrtOp::fold(ArrayRef<Attribute> operands) {
auto constOperand = operands.front(); auto constOperand = operands.front();
if (!constOperand) if (!constOperand)
return {}; return {};
auto attr = constOperand.dyn_cast<FloatAttr>(); auto attr = constOperand.dyn_cast<FloatAttr>();
if (!attr)
return {};
auto ft = getType().cast<FloatType>(); auto ft = getType().cast<FloatType>();
APFloat apf = attr.getValue(); APFloat apf = attr.getValue();
if (apf.isNegative()) if (apf.isNegative())
return {}; return {};
Show All 15 Lines