This is an archive of the discontinued LLVM Phabricator instance.

[clang][test] Add using-lld feature variable
AbandonedPublic

Authored by abrachet on Mar 15 2022, 11:28 AM.

Details

Summary

Useful for testing driver specific behavior that relies on an lld built in tree.

Also adds a lit substitution for build/bin

Diff Detail

Event Timeline

abrachet created this revision.Mar 15 2022, 11:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2022, 11:28 AM
Herald added a subscriber: mgorny. · View Herald Transcript

I think it actually becomes a bit unfortunate to add quite a bit of infrastructure to test the diagnostic change.
I am also unsure about D121724, which adds an environment variable just so that the crash can be testable. Personally I am not feeling very comfortable with such an environment variable.

I think it actually becomes a bit unfortunate to add quite a bit of infrastructure to test the diagnostic change.
I am also unsure about D121724, which adds an environment variable just so that the crash can be testable. Personally I am not feeling very comfortable with such an environment variable.

FWIW, After D120201 lands I plan to add a way to cause these reproducers on errors and not just crashes. That might be enough testing that we don't need to explicitly test the crashing scenario.

Seems reasonable having an integration with LLD, but maybe others would like to chime in?

clang/test/lit.cfg.py
136

Any reason why its not plain 'lld'? REQUIRES: lld seems more natural.

abrachet abandoned this revision.Jun 17 2022, 10:34 AM

No longer needed for D120175, This is already possible with llvm_config.use_lld