This is an archive of the discontinued LLVM Phabricator instance.

Differential D121659

[CMake][Fuchsia] Use correct architecture for iossim
ClosedPublic

Authored by phosek on Mar 14 2022, 7:03 PM.

Details

Reviewers
abrachet
haowei
leonardchan
Commits
rG1b6ff3f4f89e: [CMake][Fuchsia] Use correct architecture for iossim
Summary

We should be building iossim for x86_64, not arm64.

Diff Detail

Event Timeline

phosek created this revision.Mar 14 2022, 7:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2022, 7:03 PM
Herald added subscribers: pengfei, kristof.beyls, mgorny. · View Herald Transcript
phosek requested review of this revision.Mar 14 2022, 7:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2022, 7:03 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
abrachet accepted this revision.Mar 14 2022, 7:13 PM
This revision is now accepted and ready to land.Mar 14 2022, 7:13 PM
This revision was landed with ongoing or failed builds.Mar 14 2022, 7:21 PM
Closed by commit rG1b6ff3f4f89e: [CMake][Fuchsia] Use correct architecture for iossim (authored by phosek). · Explain Why
This revision was automatically updated to reflect the committed changes.
phosek added a commit: rG1b6ff3f4f89e: [CMake][Fuchsia] Use correct architecture for iossim.
Harbormaster completed remote builds in B154237: Diff 415296.Mar 14 2022, 8:09 PM
phosek added a reverting change: rG67f53708b273: Revert "[CMake][Fuchsia] Use correct architecture for iossim".Mar 16 2022, 10:10 AM

Revision Contents

PathSize
clang/
cmake/
caches/
2 lines

Diff 415301

clang/cmake/caches/Fuchsia-stage2.cmake

Show First 20 Lines • Show All 65 Lines • ▼ Show 20 Linesif(APPLE)
set(LIBCXXABI_INSTALL_LIBRARY OFF CACHE BOOL "") set(LIBCXXABI_INSTALL_LIBRARY OFF CACHE BOOL "")
set(LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "") set(LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "")
set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "") set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
set(LIBCXX_USE_COMPILER_RT ON CACHE BOOL "") set(LIBCXX_USE_COMPILER_RT ON CACHE BOOL "")
set(LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") set(LIBCXX_ENABLE_SHARED OFF CACHE BOOL "")
set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "")
set(LIBCXX_ABI_VERSION 2 CACHE STRING "") set(LIBCXX_ABI_VERSION 2 CACHE STRING "")
set(DARWIN_ios_ARCHS arm64 CACHE STRING "") set(DARWIN_ios_ARCHS arm64 CACHE STRING "")
set(DARWIN_iossim_ARCHS arm64 CACHE STRING "") set(DARWIN_iossim_ARCHS x86_64 CACHE STRING "")
set(DARWIN_osx_ARCHS arm64;x86_64 CACHE STRING "") set(DARWIN_osx_ARCHS arm64;x86_64 CACHE STRING "")
endif() endif()
if(WIN32) if(WIN32)
set(target "x86_64-pc-windows-msvc") set(target "x86_64-pc-windows-msvc")
list(APPEND BUILTIN_TARGETS "${target}") list(APPEND BUILTIN_TARGETS "${target}")
set(BUILTINS_${target}_CMAKE_SYSTEM_NAME Windows CACHE STRING "") set(BUILTINS_${target}_CMAKE_SYSTEM_NAME Windows CACHE STRING "")
▲ Show 20 Lines • Show All 229 Lines • Show Last 20 Lines