This is an archive of the discontinued LLVM Phabricator instance.

Differential D121636

[ASAN] Fix darwin-interface test
ClosedPublic

Authored by steven_wu on Mar 14 2022, 1:40 PM.

Details

Reviewers
kstoimenov
delcypher
Commits
rGe168513aed8f: [ASAN] Fix darwin-interface test
Summary

Fix darwin interface test after D121464. asan_rtl_x86_64.S is not
available on Darwin.

Diff Detail

Event Timeline

steven_wu created this revision.Mar 14 2022, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2022, 1:40 PM
Herald added subscribers: ributzka, pengfei. · View Herald Transcript
steven_wu requested review of this revision.Mar 14 2022, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2022, 1:40 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
steven_wu added a comment.Mar 14 2022, 1:41 PM

Not sure about win32 situation as it is also guarded in compiler-rt/lib/asan/CMakeLists.txt:

if (NOT WIN32 AND NOT APPLE)
   list(APPEND ASAN_SOURCES
     asan_rtl_x86_64.S
     asan_interceptors_vfork.S
     )
 endif()
Harbormaster completed remote builds in B154174: Diff 415205.Mar 14 2022, 2:31 PM
steven_wu updated this revision to Diff 415255.Mar 14 2022, 3:50 PM

Add win32.

Harbormaster completed remote builds in B154207: Diff 415255.Mar 14 2022, 4:15 PM
kstoimenov accepted this revision.Mar 14 2022, 4:40 PM

LGTM

This revision is now accepted and ready to land.Mar 14 2022, 4:40 PM
Closed by commit rGe168513aed8f: [ASAN] Fix darwin-interface test (authored by steven_wu). · Explain WhyMar 15 2022, 6:14 AM
This revision was automatically updated to reflect the committed changes.
steven_wu added a commit: rGe168513aed8f: [ASAN] Fix darwin-interface test.

Revision Contents

PathSize
compiler-rt/
lib/
asan/
2 lines

Diff 415205

compiler-rt/lib/asan/asan_interface.inc

Show First 20 Lines • Show All 175 Lines • ▼ Show 20 Lines
INTERFACE_FUNCTION(__sanitizer_unaligned_store16) INTERFACE_FUNCTION(__sanitizer_unaligned_store16)
INTERFACE_FUNCTION(__sanitizer_unaligned_store32) INTERFACE_FUNCTION(__sanitizer_unaligned_store32)
INTERFACE_FUNCTION(__sanitizer_unaligned_store64) INTERFACE_FUNCTION(__sanitizer_unaligned_store64)
INTERFACE_FUNCTION(__asan_update_allocation_context) INTERFACE_FUNCTION(__asan_update_allocation_context)
INTERFACE_WEAK_FUNCTION(__asan_default_options) INTERFACE_WEAK_FUNCTION(__asan_default_options)
INTERFACE_WEAK_FUNCTION(__asan_default_suppressions) INTERFACE_WEAK_FUNCTION(__asan_default_suppressions)
INTERFACE_WEAK_FUNCTION(__asan_on_error) INTERFACE_WEAK_FUNCTION(__asan_on_error)
#if defined(__x86_64__) #if defined(__x86_64__) && !defined(__APPLE__)
# define ASAN_MEMORY_ACCESS_CALLBACK_ADD(s, reg, op) \ # define ASAN_MEMORY_ACCESS_CALLBACK_ADD(s, reg, op) \
INTERFACE_FUNCTION(__asan_check_##op##_add_##s##_##reg) INTERFACE_FUNCTION(__asan_check_##op##_add_##s##_##reg)
# define ASAN_MEMORY_ACCESS_CALLBACKS_ADD(reg) \ # define ASAN_MEMORY_ACCESS_CALLBACKS_ADD(reg) \
ASAN_MEMORY_ACCESS_CALLBACK_ADD(1, reg, load) \ ASAN_MEMORY_ACCESS_CALLBACK_ADD(1, reg, load) \
ASAN_MEMORY_ACCESS_CALLBACK_ADD(1, reg, store) \ ASAN_MEMORY_ACCESS_CALLBACK_ADD(1, reg, store) \
ASAN_MEMORY_ACCESS_CALLBACK_ADD(2, reg, load) \ ASAN_MEMORY_ACCESS_CALLBACK_ADD(2, reg, load) \
Show All 24 Lines