[PowerPC][NFC] Add atomic alignments and ops tests for powerpc

[lkail]

Summary

PowerPC is lacking tests checking _Atomic alignment in cfe. Adding these tests since we're going to make change to align with gcc on Linux.

[lkail]

Add -verify.

[jsji]

LGTM. Thanks.

[hubert.reinterpretcast]

clang/test/CodeGen/PowerPC/atomic-alignment.c

3–7

Fix typos: "unkonwn"

[hubert.reinterpretcast]

clang/test/CodeGen/PowerPC/atomic-alignment.c

2

I am not sure about having a CodeGen test for this when a -fsyntax-only Layout test would do. I believe that also removes the need for powerpc-registered-target.

clang/test/Sema/atomic-ops.c

7–8

Consider testing across the -mcpu=power7 and -mcpu=power8 boundary.

[lkail]

Fix typo; Add pwr7 and pwr8 as -target-cpu.

[hubert.reinterpretcast]

LGTM with comment (not blocking).

clang/test/CodeGen/PowerPC/atomic-alignment.c

2

I will note that there is a concept of "preferred alignment" or "complete object alignment" that may differ from "required alignment". A CodeGen test like this can miss issues if the "required alignment" is wrong but the "preferred alignment" or "complete object alignment" matches what is expected.

[lkail]

clang/test/CodeGen/PowerPC/atomic-alignment.c

2

That's a good point. However currently, I haven't found any tests in test/Sema performing such check and I have't figure out a way to add such check. Maybe checking __alignof__() % (expected_align) == 0 is more practical.

[hubert.reinterpretcast]

clang/test/CodeGen/PowerPC/atomic-alignment.c

2

There are tests in test/Layout that might be closer.

clang/test/CodeGen/PowerPC/atomic-alignment.c

+// RUN: %clang_cc1 -verify -triple powerpc-unknown-unknown -emit-llvm -o - %s | \
+// RUN:   FileCheck %s --check-prefixes=PPC,PPC32
+// RUN: %clang_cc1 -verify -triple powerpc64le-unknown-linux -emit-llvm -o - %s | \
+// RUN:   FileCheck %s --check-prefixes=PPC,PPC64
+// RUN: %clang_cc1 -verify -triple powerpc64-unknown-aix -emit-llvm -o - %s | \
+// RUN:   FileCheck %s --check-prefixes=PPC,PPC64
+
+// PPC: @c = global i8 0, align 1{{$}}
+_Atomic(char) c; // expected-no-diagnostics
+
+// PPC: @s = global i16 0, align 2{{$}}
+_Atomic(short) s; // expected-no-diagnostics
+
+// PPC: @i = global i32 0, align 4{{$}}
+_Atomic(int) i; // expected-no-diagnostics
+
+// PPC32: @l = global i32 0, align 4{{$}}
+// PPC64: @l = global i64 0, align 8{{$}}
+_Atomic(long) l; // expected-no-diagnostics
+
+// PPC: @ll = global i64 0, align 8{{$}}
+_Atomic(long long) ll; // expected-no-diagnostics
+
+typedef struct {
+  char x[8];
+} O;
+
+// PPC32: @o = global %struct.O zeroinitializer, align 1{{$}}
+// PPC64: @o = global %struct.O zeroinitializer, align 8{{$}}
+_Atomic(O) o; // expected-no-diagnostics
+
+typedef struct {
+  char x[16];
+} Q;
+
+// PPC: @q = global %struct.Q zeroinitializer, align 1{{$}}
+_Atomic(Q) q; // expected-no-diagnostics

clang/test/Sema/atomic-ops.c

 // RUN: %clang_cc1 %s -verify=expected,fp80,noi128 -fgnuc-version=4.2.1 -ffreestanding \
 // RUN:   -fsyntax-only -triple=i686-linux-gnu -std=c11
 // RUN: %clang_cc1 %s -verify=expected,noi128 -fgnuc-version=4.2.1 -ffreestanding \
 // RUN:   -fsyntax-only -triple=i686-linux-android -std=c11
 // RUN: %clang_cc1 %s -verify -fgnuc-version=4.2.1 -ffreestanding \
 // RUN:   -fsyntax-only -triple=powerpc64-linux-gnu -std=c11
+// RUN: %clang_cc1 %s -verify -fgnuc-version=4.2.1 -ffreestanding \
+// RUN:   -fsyntax-only -triple=powerpc64-linux-gnu -std=c11 \
+// RUN:   -target-cpu pwr7
+// RUN: %clang_cc1 %s -verify -fgnuc-version=4.2.1 -ffreestanding \
+// RUN:   -fsyntax-only -triple=powerpc64le-linux-gnu -std=c11 \
+// RUN:   -target-cpu pwr8
 
 // Basic parsing/Sema tests for __c11_atomic_*
 
 #include <stdatomic.h>
 
 struct S { char c[3]; };
 
 _Static_assert(__GCC_ATOMIC_BOOL_LOCK_FREE == 2, "");