This is an archive of the discontinued LLVM Phabricator instance.

Differential D121261

[BOLT] Move some of the tests to common directory
ClosedPublic

Authored by yota9 on Mar 8 2022, 3:18 PM.

Details

Reviewers
maksfb
rafauler
Amir
alexander-shaposhnikov
Commits
rG506a91c0890f: [BOLT] Move some of the tests to common directory
Summary

Some of the tests are not x86-specific, move them to common directory.

Diff Detail

Event Timeline

yota9 created this revision.Mar 8 2022, 3:18 PM
Herald added a reviewer: alexander-shaposhnikov. · View Herald TranscriptMar 8 2022, 3:18 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: ayermolo, pengfei. · View Herald Transcript
yota9 requested review of this revision.Mar 8 2022, 3:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2022, 3:18 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B153256: Diff 413957.Mar 8 2022, 3:28 PM
yota9 updated this revision to Diff 413973.Mar 8 2022, 4:39 PM

Add 2 more tests

Harbormaster completed remote builds in B153269: Diff 413973.Mar 8 2022, 4:45 PM
Amir accepted this revision.Mar 8 2022, 9:57 PM

LGTM assuming these tests pass on AArch64

This revision is now accepted and ready to land.Mar 8 2022, 9:57 PM
Closed by commit rG506a91c0890f: [BOLT] Move some of the tests to common directory (authored by yota9). · Explain WhyMar 9 2022, 3:56 AM
This revision was automatically updated to reflect the committed changes.
yota9 added a commit: rG506a91c0890f: [BOLT] Move some of the tests to common directory.

Revision Contents

Diff 414056

bolt/test/Inputs/icf-jump-tables.c

  • This file was moved from bolt/test/X86/Inputs/icf-jump-tables.c.
The contents of this file were not changed.

bolt/test/Inputs/jump_table_icp.cpp

  • This file was moved from bolt/test/X86/Inputs/jump_table_icp.cpp.
The contents of this file were not changed.

bolt/test/R_ABS.pic.lld.cpp

  • This file was moved from bolt/test/X86/R_X86_64_64.pic.lld.cpp.
The contents of this file were not changed.

bolt/test/X86/Inputs/icf-jump-tables.c

  • This file was moved to bolt/test/Inputs/icf-jump-tables.c.

bolt/test/X86/Inputs/jump_table_icp.cpp

  • This file was moved to bolt/test/Inputs/jump_table_icp.cpp.

bolt/test/X86/R_X86_64_64.pic.lld.cpp

  • This file was moved to bolt/test/R_ABS.pic.lld.cpp.

bolt/test/X86/bad-exe.test

  • This file was moved to bolt/test/bad-exe.test.

bolt/test/X86/bolt-info.test

  • This file was moved to bolt/test/bolt-info.test.

bolt/test/X86/icf-jump-tables.test

## Check that BOLT folds functions with jump tables and does not report ## Check that BOLT folds functions with jump tables and does not report
## undefined symbols. ## undefined symbols.
# REQUIRES: system-linux # REQUIRES: system-linux
# RUN: %clang %cflags -O1 -g %p/Inputs/icf-jump-tables.c -o %t.exe -Wl,-q # RUN: %clang %cflags -O1 -g %p/../Inputs/icf-jump-tables.c -o %t.exe -Wl,-q
# RUN: llvm-bolt %t.exe -icf -o %t.bolt |& FileCheck %s # RUN: llvm-bolt %t.exe -icf -o %t.bolt |& FileCheck %s
## Check that BOLT successfully folded a function with jump table: ## Check that BOLT successfully folded a function with jump table:
# CHECK: ICF folded {{.*}}. {{[^0]}} functions had jump tables. # CHECK: ICF folded {{.*}}. {{[^0]}} functions had jump tables.
## Check that no relocations against undefined symbols were emitted: ## Check that no relocations against undefined symbols were emitted:
# CHECK-NOT: Undefined temporary symbol # CHECK-NOT: Undefined temporary symbol

bolt/test/X86/invalid-profile.test

  • This file was moved to bolt/test/invalid-profile.test.

bolt/test/X86/no-relocs.test

  • This file was moved to bolt/test/no-relocs.test.

bolt/test/X86/pie.test

  • This file was moved to bolt/test/pie.test.

bolt/test/X86/re-optimize.test

  • This file was moved to bolt/test/re-optimize.test.

bolt/test/X86/shared-object.test

  • This file was moved to bolt/test/shared-object.test.

bolt/test/bad-exe.test

  • This file was moved from bolt/test/X86/bad-exe.test.
The contents of this file were not changed.

bolt/test/bolt-info.test

  • This file was moved from bolt/test/X86/bolt-info.test.
The contents of this file were not changed.

bolt/test/invalid-profile.test

  • This file was moved from bolt/test/X86/invalid-profile.test.
The contents of this file were not changed.

bolt/test/no-relocs.test

  • This file was moved from bolt/test/X86/no-relocs.test.
The contents of this file were not changed.

bolt/test/pie.test

  • This file was moved from bolt/test/X86/pie.test.
The contents of this file were not changed.

bolt/test/re-optimize.test

  • This file was moved from bolt/test/X86/re-optimize.test.
The contents of this file were not changed.

bolt/test/shared-object.test

  • This file was moved from bolt/test/X86/shared-object.test.
The contents of this file were not changed.