Page MenuHomePhabricator

[compiler-rt][mips] Fix the condition to include sanitizer_atomic_clang_mips.h
ClosedPublic

Authored by xry111 on Mar 8 2022, 3:49 AM.

Details

Summary

The Glibc header [1] define _ABIO32 unconditionally on MIPS. So we need
to compare _MIPS_SIM and _ABIO32 to know if we are actually building for
MIPS32. Using sanitizer_atomic_clang_mips.h can cause test failures and
hangs on MIPS64.

[1]:https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/mips/sgidefs.h

Diff Detail

Event Timeline

xry111 created this revision.Mar 8 2022, 3:49 AM
xry111 requested review of this revision.Mar 8 2022, 3:49 AM
Herald added a subscriber: Restricted Project. · View Herald TranscriptMar 8 2022, 3:49 AM
xry111 updated this revision to Diff 413768.Mar 8 2022, 4:51 AM

Satisify clang-format.

xry111 updated this revision to Diff 413773.Mar 8 2022, 5:20 AM
xry111 added a comment.Mar 8 2022, 5:50 AM

clang-format is doing strange things, if I removed those two spaces for indent it will then tell me to add them back...

xry111 updated this revision to Diff 414001.Mar 8 2022, 8:31 PM
dvyukov accepted this revision.Mar 8 2022, 11:36 PM
This revision is now accepted and ready to land.Mar 8 2022, 11:36 PM
xry111 added a comment.Mar 9 2022, 3:11 AM

@dvyukov Thanks for the review. But I don't have a commit access to llvm-project.

vitalybuka accepted this revision.Mar 9 2022, 10:15 AM
MaskRay accepted this revision.Mar 9 2022, 10:19 AM