This is an archive of the discontinued LLVM Phabricator instance.

Differential D121048

[MLIR] [LangRef] Clarify parsing of dense<...>
ClosedPublic

Authored by bollu on Mar 5 2022, 8:47 AM.

Details

Reviewers
mehdi_amini
rriddle
silvas
stephenneuendorffer
kiszk
ftynse
Commits
rGe83c6aa91e0e: [MLIR] [LangRef] Clarify parsing of dense<...>
Summary

dense<...> expects ... to be a tensor-literal.
Define this in the grammar in BuiltinAttributes.td,
and reflect this in the reference grammar written in
AttributeParser.cpp.

Diff Detail

Event Timeline

bollu created this revision.Mar 5 2022, 8:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2022, 8:47 AM
Herald added subscribers: arjunp, sdasgup3, wenzhicui and 19 others. · View Herald Transcript
bollu requested review of this revision.Mar 5 2022, 8:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2022, 8:47 AM
Herald added a subscriber: nicolasvasilache. · View Herald Transcript
bollu edited the summary of this revision. (Show Details)Mar 5 2022, 8:49 AM
rriddle accepted this revision.Mar 10 2022, 12:42 PM

Thanks!

This revision is now accepted and ready to land.Mar 10 2022, 12:42 PM
This revision was landed with ongoing or failed builds.Mar 16 2022, 9:57 AM
Closed by commit rGe83c6aa91e0e: [MLIR] [LangRef] Clarify parsing of dense<...> (authored by bollu, committed by Groverkss). · Explain Why
This revision was automatically updated to reflect the committed changes.
Groverkss added a commit: rGe83c6aa91e0e: [MLIR] [LangRef] Clarify parsing of dense<...>.

Revision Contents

PathSize
mlir/
include/
mlir/
IR/
3 lines
lib/
Parser/
2 lines

Diff 415885

mlir/include/mlir/IR/BuiltinAttributes.td

Show First 20 Lines • Show All 147 Lines • ▼ Show 20 Linesdef Builtin_DenseIntOrFPElementsAttr : Builtin_Attr<
"DenseIntOrFPElements", [ElementsAttrInterface], "DenseElementsAttr" "DenseIntOrFPElements", [ElementsAttrInterface], "DenseElementsAttr"
> { > {
let summary = "An Attribute containing a dense multi-dimensional array of " let summary = "An Attribute containing a dense multi-dimensional array of "
"integer or floating-point values"; "integer or floating-point values";
let description = [{ let description = [{
Syntax: Syntax:
``` ```
dense-intorfloat-elements-attribute ::= `dense` `<` attribute-value `>` `:` tensor-literal ::= integer-literal | float-literal | [] | [tensor-literal (, tensor-literal)* ]
dense-intorfloat-elements-attribute ::= `dense` `<` tensor-literal `>` `:`
( tensor-type | vector-type ) ( tensor-type | vector-type )
``` ```
A dense int-or-float elements attribute is an elements attribute containing A dense int-or-float elements attribute is an elements attribute containing
a densely packed vector or tensor of integer or floating-point values. The a densely packed vector or tensor of integer or floating-point values. The
element type of this attribute is required to be either an `IntegerType` or element type of this attribute is required to be either an `IntegerType` or
a `FloatType`. a `FloatType`.
▲ Show 20 Lines • Show All 950 Lines • Show Last 20 Lines

mlir/lib/Parser/AttributeParser.cpp

Show All 27 Lines
/// | bool-literal /// | bool-literal
/// | integer-literal (`:` (index-type | integer-type))? /// | integer-literal (`:` (index-type | integer-type))?
/// | float-literal (`:` float-type)? /// | float-literal (`:` float-type)?
/// | string-literal (`:` type)? /// | string-literal (`:` type)?
/// | type /// | type
/// | `[` (attribute-value (`,` attribute-value)*)? `]` /// | `[` (attribute-value (`,` attribute-value)*)? `]`
/// | `{` (attribute-entry (`,` attribute-entry)*)? `}` /// | `{` (attribute-entry (`,` attribute-entry)*)? `}`
/// | symbol-ref-id (`::` symbol-ref-id)* /// | symbol-ref-id (`::` symbol-ref-id)*
/// | `dense` `<` attribute-value `>` `:` /// | `dense` `<` tensor-literal `>` `:`
/// (tensor-type | vector-type) /// (tensor-type | vector-type)
/// | `sparse` `<` attribute-value `,` attribute-value `>` /// | `sparse` `<` attribute-value `,` attribute-value `>`
/// `:` (tensor-type | vector-type) /// `:` (tensor-type | vector-type)
/// | `opaque` `<` dialect-namespace `,` hex-string-literal /// | `opaque` `<` dialect-namespace `,` hex-string-literal
/// `>` `:` (tensor-type | vector-type) /// `>` `:` (tensor-type | vector-type)
/// | extended-attribute /// | extended-attribute
/// ///
Attribute Parser::parseAttribute(Type type) { Attribute Parser::parseAttribute(Type type) {
▲ Show 20 Lines • Show All 922 Lines • Show Last 20 Lines