It was requested here (https://reviews.llvm.org/D120398#3353053) to make
the underlying type of all enums in FormatStyle an int8_t.
Originally the type was changed in https://reviews.llvm.org/D93758.
Paths
| Differential D120884
[format] Use int8_t as the underlying type of all enums in FormatStyle ClosedPublic Authored by kwk on Mar 3 2022, 2:58 AM.
Details Summary It was requested here (https://reviews.llvm.org/D120398#3353053) to make Originally the type was changed in https://reviews.llvm.org/D93758.
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Mar 3 2022, 3:07 AM Comment Actions
Yes, sorry that I forgot it again. And thank you for approving. Shall I wait for the others to approve this or land the patch? Comment Actions
I myself give patches always some time. Others commit nearly as soon as possible. Comment Actions Fixup my work after interruption by screaming children wanting dinner ;) This is how I've tested this patch: ninja clang-format && ninja FormatTests && ./tools/clang/unittests/Format/FormatTests Comment Actions @HazardyKnusperkeks @owenpan can you please have a quick look again. All I did was rebasing my changes and in the meantime I was interrupted... This patch has been sitting for some time and I'd like to land it as soon one of you approves it. Comment Actions Should we also simplify the regex https://github.com/llvm/llvm-project/blob/a3248e4b28ce09c3a749ecae5378dd0b3a8d42b1/clang/docs/tools/dump_format_style.py#L263? Closed by commit rG063bd3b886b2: [format] Use int8_t as the underlying type of all enums in FormatStyle (authored by kwk). · Explain WhyMar 21 2022, 2:28 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 416971 clang/include/clang/Format/Format.h
|