This is an archive of the discontinued LLVM Phabricator instance.

Differential D120789

[cmake] Prefix gtest and gtest_main with "llvm_".
ClosedPublic

Authored by stellaraccident on Mar 1 2022, 8:40 PM.

Details

Reviewers
tstellar
mehdi_amini
Commits
rG9f37775472b4: [cmake] Prefix gtest and gtest_main with "llvm_".
Summary

The upstream project ships CMake rules for building vanilla gtest/gmock which conflict with the names chosen by LLVM. Since LLVM's build rules here are quite specific to LLVM, prefixing them to avoid collision is the right thing (i.e. there does not appear to be a path to letting someone *replace* LLVM's googletest with one they bring, so co-existence should be the goal).

This allows LLVM to be included with testing enabled within projects that themselves have a dependency on an official gtest release.

Diff Detail

Event Timeline

stellaraccident created this revision.Mar 1 2022, 8:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2022, 8:40 PM
Herald added a subscriber: mgorny. · View Herald Transcript
stellaraccident requested review of this revision.Mar 1 2022, 8:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2022, 8:40 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
stellaraccident added reviewers: tstellar, mehdi_amini.Mar 1 2022, 8:41 PM
Harbormaster completed remote builds in B152095: Diff 412314.Mar 1 2022, 8:51 PM
stellaraccident updated this revision to Diff 412315.Mar 1 2022, 9:10 PM

Add more instances of gtest.

Herald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptMar 1 2022, 9:10 PM
Herald added subscribers: libc-commits, lldb-commits, Restricted Project and 2 others. · View Herald Transcript
Harbormaster completed remote builds in B152096: Diff 412315.Mar 1 2022, 9:43 PM
Herald added subscribers: JDevlieghere, jdoerfert. · View Herald TranscriptMar 1 2022, 9:43 PM
mehdi_amini accepted this revision.Mar 2 2022, 1:31 AM
This revision is now accepted and ready to land.Mar 2 2022, 1:31 AM
stellaraccident updated this revision to Diff 412481.Mar 2 2022, 10:17 AM

Rebase.

Harbormaster completed remote builds in B152204: Diff 412481.Mar 2 2022, 10:51 AM
stellaraccident added a comment.Mar 2 2022, 10:53 AM

Landing. Windows test failure seems unrelated with the current rebase (passed on previous).

This revision was landed with ongoing or failed builds.Mar 2 2022, 10:53 AM
Closed by commit rG9f37775472b4: [cmake] Prefix gtest and gtest_main with "llvm_". (authored by stellaraccident). · Explain Why
This revision was automatically updated to reflect the committed changes.
stellaraccident added a commit: rG9f37775472b4: [cmake] Prefix gtest and gtest_main with "llvm_"..
stellaraccident added a comment.Mar 2 2022, 11:11 AM

Looks like there is an lldb buildbot failure: https://lab.llvm.org/buildbot/#/builders/68/builds/28116

I'm not sure why this didn't fail on presubmit. The fix should be to find the missing rename in lldb cmake files and update to llvm_gtest.

stellaraccident added a reverting change: rG7cdda6b8ce49: Revert "[cmake] Prefix gtest and gtest_main with "llvm_".".Mar 2 2022, 11:14 AM
stellaraccident added a comment.Mar 2 2022, 11:15 AM
In D120789#3355138, @stellaraccident wrote:

Looks like there is an lldb buildbot failure: https://lab.llvm.org/buildbot/#/builders/68/builds/28116

I'm not sure why this didn't fail on presubmit. The fix should be to find the missing rename in lldb cmake files and update to llvm_gtest.

Fix was non-obvious. Reverted in 7cdda6b8ce49ae3c90c068cff4dc355bba5d77f2 and will followup.

Revision Contents

PathSize
compiler-rt/
lib/
asan/
tests/
2 lines
fuzzer/
tests/
4 lines
gwp_asan/
tests/
2 lines
interception/
tests/
2 lines
msan/
tests/
2 lines
orc/
unittests/
2 lines
sanitizer_common/
tests/
2 lines
scudo/
standalone/
tests/
2 lines
tsan/
tests/
2 lines
xray/
tests/
2 lines
flang/
14 lines
libc/
benchmarks/
4 lines
test/
utils/
tools/
6 lines
lldb/
unittests/
2 lines
llvm/
cmake/
modules/
2 lines
lib/
Testing/
Support/
2 lines
runtimes/
4 lines
unittests/
Support/
CommandLineInit/
2 lines
utils/
unittest/
12 lines
UnitTestMain/
4 lines

Diff 412481

compiler-rt/lib/asan/tests/CMakeLists.txt

Show First 20 Lines • Show All 166 Lines • ▼ Show 20 Linesfunction(add_asan_tests arch test_runtime)
string(TOUPPER ${arch} ARCH_UPPER_CASE) string(TOUPPER ${arch} ARCH_UPPER_CASE)
set(CONFIG_NAME ${ARCH_UPPER_CASE}${OS_NAME}Config) set(CONFIG_NAME ${ARCH_UPPER_CASE}${OS_NAME}Config)
set(CONFIG_NAME_DYNAMIC ${ARCH_UPPER_CASE}${OS_NAME}DynamicConfig) set(CONFIG_NAME_DYNAMIC ${ARCH_UPPER_CASE}${OS_NAME}DynamicConfig)
# Closure to keep the values. # Closure to keep the values.
function(generate_asan_tests test_objects test_suite testname) function(generate_asan_tests test_objects test_suite testname)
generate_compiler_rt_tests(${test_objects} ${test_suite} ${testname} ${arch} generate_compiler_rt_tests(${test_objects} ${test_suite} ${testname} ${arch}
COMPILE_DEPS ${ASAN_UNITTEST_HEADERS} ${ASAN_IGNORELIST_FILE} COMPILE_DEPS ${ASAN_UNITTEST_HEADERS} ${ASAN_IGNORELIST_FILE}
DEPS gtest asan DEPS llvm_gtest asan
KIND ${TEST_KIND} KIND ${TEST_KIND}
${ARGN} ${ARGN}
) )
set("${test_objects}" "${${test_objects}}" PARENT_SCOPE) set("${test_objects}" "${${test_objects}}" PARENT_SCOPE)
endfunction() endfunction()
set(TARGET_LINK_FLAGS) set(TARGET_LINK_FLAGS)
get_target_link_flags_for_arch(${arch} TARGET_LINK_FLAGS) get_target_link_flags_for_arch(${arch} TARGET_LINK_FLAGS)
▲ Show 20 Lines • Show All 139 Lines • Show Last 20 Lines

compiler-rt/lib/fuzzer/tests/CMakeLists.txt

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines if(CMAKE_SYSTEM_NAME STREQUAL "Linux" AND
set(LIBFUZZER_TEST_RUNTIME_LINK_FLAGS ${LIBCXX_${arch}_PREFIX}/lib/libc++.a) set(LIBFUZZER_TEST_RUNTIME_LINK_FLAGS ${LIBCXX_${arch}_PREFIX}/lib/libc++.a)
endif() endif()
set(FuzzerTestObjects) set(FuzzerTestObjects)
generate_compiler_rt_tests(FuzzerTestObjects generate_compiler_rt_tests(FuzzerTestObjects
FuzzerUnitTests "Fuzzer-${arch}-Test" ${arch} FuzzerUnitTests "Fuzzer-${arch}-Test" ${arch}
SOURCES FuzzerUnittest.cpp ${COMPILER_RT_GTEST_SOURCE} SOURCES FuzzerUnittest.cpp ${COMPILER_RT_GTEST_SOURCE}
RUNTIME ${LIBFUZZER_TEST_RUNTIME} RUNTIME ${LIBFUZZER_TEST_RUNTIME}
DEPS gtest ${LIBFUZZER_TEST_RUNTIME_DEPS} DEPS llvm_gtest ${LIBFUZZER_TEST_RUNTIME_DEPS}
CFLAGS ${LIBFUZZER_UNITTEST_CFLAGS} ${LIBFUZZER_TEST_RUNTIME_CFLAGS} CFLAGS ${LIBFUZZER_UNITTEST_CFLAGS} ${LIBFUZZER_TEST_RUNTIME_CFLAGS}
LINK_FLAGS ${LIBFUZZER_UNITTEST_LINK_FLAGS} ${LIBFUZZER_TEST_RUNTIME_LINK_FLAGS}) LINK_FLAGS ${LIBFUZZER_UNITTEST_LINK_FLAGS} ${LIBFUZZER_TEST_RUNTIME_LINK_FLAGS})
set_target_properties(FuzzerUnitTests PROPERTIES set_target_properties(FuzzerUnitTests PROPERTIES
RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}) RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
set(FuzzedDataProviderTestObjects) set(FuzzedDataProviderTestObjects)
generate_compiler_rt_tests(FuzzedDataProviderTestObjects generate_compiler_rt_tests(FuzzedDataProviderTestObjects
FuzzedDataProviderUnitTests "FuzzerUtils-${arch}-Test" ${arch} FuzzedDataProviderUnitTests "FuzzerUtils-${arch}-Test" ${arch}
SOURCES FuzzedDataProviderUnittest.cpp ${COMPILER_RT_GTEST_SOURCE} SOURCES FuzzedDataProviderUnittest.cpp ${COMPILER_RT_GTEST_SOURCE}
DEPS gtest ${LIBFUZZER_TEST_RUNTIME_DEPS} ${COMPILER_RT_SOURCE_DIR}/include/fuzzer/FuzzedDataProvider.h DEPS llvm_gtest ${LIBFUZZER_TEST_RUNTIME_DEPS} ${COMPILER_RT_SOURCE_DIR}/include/fuzzer/FuzzedDataProvider.h
CFLAGS ${LIBFUZZER_UNITTEST_CFLAGS} ${LIBFUZZER_TEST_RUNTIME_CFLAGS} CFLAGS ${LIBFUZZER_UNITTEST_CFLAGS} ${LIBFUZZER_TEST_RUNTIME_CFLAGS}
LINK_FLAGS ${LIBFUZZER_UNITTEST_LINK_FLAGS} ${LIBFUZZER_TEST_RUNTIME_LINK_FLAGS}) LINK_FLAGS ${LIBFUZZER_UNITTEST_LINK_FLAGS} ${LIBFUZZER_TEST_RUNTIME_LINK_FLAGS})
set_target_properties(FuzzedDataProviderUnitTests PROPERTIES set_target_properties(FuzzedDataProviderUnitTests PROPERTIES
RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}) RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
endif() endif()

compiler-rt/lib/gwp_asan/tests/CMakeLists.txt

Show First 20 Lines • Show All 60 Lines • ▼ Show 20 Lines set_target_properties(${GWP_ASAN_TEST_RUNTIME} PROPERTIES
ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
FOLDER "Compiler-RT Runtime tests") FOLDER "Compiler-RT Runtime tests")
set(GwpAsanTestObjects) set(GwpAsanTestObjects)
generate_compiler_rt_tests(GwpAsanTestObjects generate_compiler_rt_tests(GwpAsanTestObjects
GwpAsanUnitTests "GwpAsan-${arch}-Test" ${arch} GwpAsanUnitTests "GwpAsan-${arch}-Test" ${arch}
SOURCES ${GWP_ASAN_UNITTESTS} ${COMPILER_RT_GTEST_SOURCE} SOURCES ${GWP_ASAN_UNITTESTS} ${COMPILER_RT_GTEST_SOURCE}
RUNTIME ${GWP_ASAN_TEST_RUNTIME} RUNTIME ${GWP_ASAN_TEST_RUNTIME}
DEPS gtest ${GWP_ASAN_UNIT_TEST_HEADERS} DEPS llvm_gtest ${GWP_ASAN_UNIT_TEST_HEADERS}
CFLAGS ${GWP_ASAN_UNITTEST_CFLAGS} CFLAGS ${GWP_ASAN_UNITTEST_CFLAGS}
LINK_FLAGS ${GWP_ASAN_UNITTEST_LINK_FLAGS}) LINK_FLAGS ${GWP_ASAN_UNITTEST_LINK_FLAGS})
set_target_properties(GwpAsanUnitTests PROPERTIES set_target_properties(GwpAsanUnitTests PROPERTIES
RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}) RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
endif() endif()

compiler-rt/lib/interception/tests/CMakeLists.txt

Show First 20 Lines • Show All 89 Lines • ▼ Show 20 Lines
macro(add_interception_tests_for_arch arch) macro(add_interception_tests_for_arch arch)
set(INTERCEPTION_TEST_OBJECTS) set(INTERCEPTION_TEST_OBJECTS)
get_interception_lib_for_arch(${arch} INTERCEPTION_COMMON_LIB) get_interception_lib_for_arch(${arch} INTERCEPTION_COMMON_LIB)
generate_compiler_rt_tests(INTERCEPTION_TEST_OBJECTS generate_compiler_rt_tests(INTERCEPTION_TEST_OBJECTS
InterceptionUnitTests "Interception-${arch}-Test" ${arch} InterceptionUnitTests "Interception-${arch}-Test" ${arch}
RUNTIME ${INTERCEPTION_COMMON_LIB} RUNTIME ${INTERCEPTION_COMMON_LIB}
SOURCES ${INTERCEPTION_UNITTESTS} ${COMPILER_RT_GTEST_SOURCE} SOURCES ${INTERCEPTION_UNITTESTS} ${COMPILER_RT_GTEST_SOURCE}
COMPILE_DEPS ${INTERCEPTION_TEST_HEADERS} COMPILE_DEPS ${INTERCEPTION_TEST_HEADERS}
DEPS gtest DEPS llvm_gtest
CFLAGS ${INTERCEPTION_TEST_CFLAGS_COMMON} CFLAGS ${INTERCEPTION_TEST_CFLAGS_COMMON}
LINK_FLAGS ${INTERCEPTION_TEST_LINK_FLAGS_COMMON}) LINK_FLAGS ${INTERCEPTION_TEST_LINK_FLAGS_COMMON})
endmacro() endmacro()
if(COMPILER_RT_CAN_EXECUTE_TESTS AND NOT ANDROID AND NOT APPLE) if(COMPILER_RT_CAN_EXECUTE_TESTS AND NOT ANDROID AND NOT APPLE)
# We use just-built clang to build interception unittests, so we must # We use just-built clang to build interception unittests, so we must
# be sure that produced binaries would work. # be sure that produced binaries would work.
if(APPLE) if(APPLE)
Show All 12 Lines

compiler-rt/lib/msan/tests/CMakeLists.txt

Show First 20 Lines • Show All 60 Lines • ▼ Show 20 Lines
append_list_if(COMPILER_RT_HAS_LIBDL -ldl MSAN_UNITTEST_LINK_FLAGS) append_list_if(COMPILER_RT_HAS_LIBDL -ldl MSAN_UNITTEST_LINK_FLAGS)
macro(msan_compile obj_list source arch kind cflags) macro(msan_compile obj_list source arch kind cflags)
sanitizer_test_compile( sanitizer_test_compile(
${obj_list} ${source} ${arch} ${obj_list} ${source} ${arch}
KIND ${kind} KIND ${kind}
COMPILE_DEPS ${MSAN_UNITTEST_HEADERS} COMPILE_DEPS ${MSAN_UNITTEST_HEADERS}
DEPS gtest msan DEPS llvm_gtest msan
CFLAGS -isystem ${CMAKE_CURRENT_BINARY_DIR}/../libcxx_msan_${arch}/include/c++/v1 CFLAGS -isystem ${CMAKE_CURRENT_BINARY_DIR}/../libcxx_msan_${arch}/include/c++/v1
${MSAN_UNITTEST_INSTRUMENTED_CFLAGS} ${cflags} ${MSAN_UNITTEST_INSTRUMENTED_CFLAGS} ${cflags}
) )
endmacro() endmacro()
macro(msan_link_shared so_list so_name arch kind) macro(msan_link_shared so_list so_name arch kind)
cmake_parse_arguments(SOURCE "" "" "OBJECTS;LINK_FLAGS;DEPS" ${ARGN}) cmake_parse_arguments(SOURCE "" "" "OBJECTS;LINK_FLAGS;DEPS" ${ARGN})
set(output_so "${CMAKE_CURRENT_BINARY_DIR}/${so_name}.${arch}${kind}.so") set(output_so "${CMAKE_CURRENT_BINARY_DIR}/${so_name}.${arch}${kind}.so")
▲ Show 20 Lines • Show All 72 Lines • Show Last 20 Lines

compiler-rt/lib/orc/unittests/CMakeLists.txt

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
else() else()
append_list_if(COMPILER_RT_HAS_LIBM -lm ORC_UNITTEST_LINK_FLAGS) append_list_if(COMPILER_RT_HAS_LIBM -lm ORC_UNITTEST_LINK_FLAGS)
append_list_if(COMPILER_RT_HAS_LIBRT -lrt ORC_UNITTEST_LINK_FLAGS) append_list_if(COMPILER_RT_HAS_LIBRT -lrt ORC_UNITTEST_LINK_FLAGS)
append_list_if(COMPILER_RT_HAS_LIBDL -ldl ORC_UNITTEST_LINK_FLAGS) append_list_if(COMPILER_RT_HAS_LIBDL -ldl ORC_UNITTEST_LINK_FLAGS)
append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread ORC_UNITTEST_LINK_FLAGS) append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread ORC_UNITTEST_LINK_FLAGS)
append_list_if(COMPILER_RT_HAS_LIBEXECINFO -lexecinfo ORC_UNITTEST_LINK_FLAGS) append_list_if(COMPILER_RT_HAS_LIBEXECINFO -lexecinfo ORC_UNITTEST_LINK_FLAGS)
endif() endif()
set(ORC_DEPS gtest orc) set(ORC_DEPS llvm_gtest orc)
# ORC uses C++ standard library headers. # ORC uses C++ standard library headers.
if (TARGET cxx-headers OR HAVE_LIBCXX) if (TARGET cxx-headers OR HAVE_LIBCXX)
set(ORC_DEPS cxx-headers) set(ORC_DEPS cxx-headers)
endif() endif()
macro(add_orc_unittest testname) macro(add_orc_unittest testname)
cmake_parse_arguments(TEST "" "" "SOURCES;HEADERS" ${ARGN}) cmake_parse_arguments(TEST "" "" "SOURCES;HEADERS" ${ARGN})
if(UNIX) if(UNIX)
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines

compiler-rt/lib/sanitizer_common/tests/CMakeLists.txt

Show First 20 Lines • Show All 157 Lines • ▼ Show 20 Linesmacro(add_sanitizer_tests_for_arch arch)
get_target_link_flags_for_arch(${arch} TARGET_LINK_FLAGS) get_target_link_flags_for_arch(${arch} TARGET_LINK_FLAGS)
set(SANITIZER_TEST_OBJECTS) set(SANITIZER_TEST_OBJECTS)
generate_compiler_rt_tests(SANITIZER_TEST_OBJECTS SanitizerUnitTests generate_compiler_rt_tests(SANITIZER_TEST_OBJECTS SanitizerUnitTests
"Sanitizer-${arch}-Test" ${arch} "Sanitizer-${arch}-Test" ${arch}
RUNTIME "${SANITIZER_COMMON_LIB}" RUNTIME "${SANITIZER_COMMON_LIB}"
SOURCES ${SANITIZER_UNITTESTS} ${COMPILER_RT_GTEST_SOURCE} ${COMPILER_RT_GMOCK_SOURCE} SOURCES ${SANITIZER_UNITTESTS} ${COMPILER_RT_GTEST_SOURCE} ${COMPILER_RT_GMOCK_SOURCE}
COMPILE_DEPS ${SANITIZER_TEST_HEADERS} COMPILE_DEPS ${SANITIZER_TEST_HEADERS}
DEPS gtest DEPS llvm_gtest
CFLAGS ${SANITIZER_TEST_CFLAGS_COMMON} ${extra_flags} CFLAGS ${SANITIZER_TEST_CFLAGS_COMMON} ${extra_flags}
LINK_FLAGS ${SANITIZER_TEST_LINK_FLAGS_COMMON} ${TARGET_LINK_FLAGS} ${extra_flags}) LINK_FLAGS ${SANITIZER_TEST_LINK_FLAGS_COMMON} ${TARGET_LINK_FLAGS} ${extra_flags})
if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux" AND "${arch}" STREQUAL "x86_64") if("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux" AND "${arch}" STREQUAL "x86_64")
# Test that the libc-independent part of sanitizer_common is indeed # Test that the libc-independent part of sanitizer_common is indeed
# independent of libc, by linking this binary without libc (here) and # independent of libc, by linking this binary without libc (here) and
# executing it (unit test in sanitizer_nolibc_test.cpp). # executing it (unit test in sanitizer_nolibc_test.cpp).
get_target_flags_for_arch(${arch} TARGET_FLAGS) get_target_flags_for_arch(${arch} TARGET_FLAGS)
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines

compiler-rt/lib/scudo/standalone/tests/CMakeLists.txt

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines foreach(arch ${SCUDO_TEST_ARCH})
# Add the static runtime library made of all the runtime objects # Add the static runtime library made of all the runtime objects
set(RUNTIME RT${testname}.${arch}) set(RUNTIME RT${testname}.${arch})
add_library(${RUNTIME} STATIC ${SCUDO_TEST_RTOBJECTS}) add_library(${RUNTIME} STATIC ${SCUDO_TEST_RTOBJECTS})
set(ScudoUnitTestsObjects) set(ScudoUnitTestsObjects)
generate_compiler_rt_tests(ScudoUnitTestsObjects ScudoUnitTests generate_compiler_rt_tests(ScudoUnitTestsObjects ScudoUnitTests
"${testname}-${arch}-Test" ${arch} "${testname}-${arch}-Test" ${arch}
SOURCES ${TEST_SOURCES} ${COMPILER_RT_GTEST_SOURCE} SOURCES ${TEST_SOURCES} ${COMPILER_RT_GTEST_SOURCE}
COMPILE_DEPS ${SCUDO_TEST_HEADERS} COMPILE_DEPS ${SCUDO_TEST_HEADERS}
DEPS gtest scudo_standalone DEPS llvm_gtest scudo_standalone
RUNTIME ${RUNTIME} RUNTIME ${RUNTIME}
CFLAGS ${SCUDO_UNITTEST_CFLAGS} CFLAGS ${SCUDO_UNITTEST_CFLAGS}
LINK_FLAGS ${LINK_FLAGS}) LINK_FLAGS ${LINK_FLAGS})
endforeach() endforeach()
endif() endif()
endmacro() endmacro()
set(SCUDO_UNIT_TEST_SOURCES set(SCUDO_UNIT_TEST_SOURCES
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines

compiler-rt/lib/tsan/tests/CMakeLists.txt

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lineselse()
list(APPEND LINK_FLAGS ${COMPILER_RT_TEST_LIBDISPATCH_CFLAGS}) list(APPEND LINK_FLAGS ${COMPILER_RT_TEST_LIBDISPATCH_CFLAGS})
endif() endif()
set(TSAN_RTL_HEADERS) set(TSAN_RTL_HEADERS)
foreach (header ${TSAN_HEADERS}) foreach (header ${TSAN_HEADERS})
list(APPEND TSAN_RTL_HEADERS ${CMAKE_CURRENT_SOURCE_DIR}/../${header}) list(APPEND TSAN_RTL_HEADERS ${CMAKE_CURRENT_SOURCE_DIR}/../${header})
endforeach() endforeach()
set(TSAN_DEPS gtest tsan) set(TSAN_DEPS llvm_gtest tsan)
# TSan uses C++ standard library headers. # TSan uses C++ standard library headers.
if (TARGET cxx-headers OR HAVE_LIBCXX) if (TARGET cxx-headers OR HAVE_LIBCXX)
set(TSAN_DEPS cxx-headers) set(TSAN_DEPS cxx-headers)
endif() endif()
# add_tsan_unittest(<name> # add_tsan_unittest(<name>
# SOURCES <sources list> # SOURCES <sources list>
# HEADERS <extra headers list>) # HEADERS <extra headers list>)
Show All 21 Lines

compiler-rt/lib/xray/tests/CMakeLists.txt

Show First 20 Lines • Show All 96 Lines • ▼ Show 20 Lines foreach(arch ${XRAY_TEST_ARCH})
# Note that any change in the implementations will cause all the unit # Note that any change in the implementations will cause all the unit
# tests to be re-built. This is by design, but may be cumbersome during # tests to be re-built. This is by design, but may be cumbersome during
# the build/test cycle. # the build/test cycle.
COMPILE_DEPS ${TEST_SOURCES} ${COMPILER_RT_GTEST_SOURCE} COMPILE_DEPS ${TEST_SOURCES} ${COMPILER_RT_GTEST_SOURCE}
${XRAY_HEADERS} ${XRAY_ALL_SOURCE_FILES_ABS_PATHS} ${XRAY_HEADERS} ${XRAY_ALL_SOURCE_FILES_ABS_PATHS}
"test_helpers.h" "test_helpers.h"
RUNTIME "${XRAY_RUNTIME_LIBS}" RUNTIME "${XRAY_RUNTIME_LIBS}"
DEPS gtest xray llvm-xray LLVMXRay LLVMTestingSupport DEPS llvm_gtest xray llvm-xray LLVMXRay LLVMTestingSupport
CFLAGS ${XRAY_UNITTEST_CFLAGS} CFLAGS ${XRAY_UNITTEST_CFLAGS}
LINK_FLAGS ${TARGET_LINK_FLAGS} ${XRAY_UNITTEST_LINK_FLAGS} LINK_FLAGS ${TARGET_LINK_FLAGS} ${XRAY_UNITTEST_LINK_FLAGS}
) )
set_target_properties(XRayUnitTests set_target_properties(XRayUnitTests
PROPERTIES PROPERTIES
RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}) RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
endforeach() endforeach()
endif() endif()
Show All 22 Lines

flang/CMakeLists.txt

Show First 20 Lines • Show All 142 Lines • ▼ Show 20 Linesif (FLANG_STANDALONE_BUILD)
get_errc_messages(LLVM_LIT_ERRC_MESSAGES) get_errc_messages(LLVM_LIT_ERRC_MESSAGES)
#Handle unittests when out-of-tree #Handle unittests when out-of-tree
#LLVM_BUILD_MAIN_SRC_DIR - Path to llvm source when out-of-tree. #LLVM_BUILD_MAIN_SRC_DIR - Path to llvm source when out-of-tree.
set(FLANG_GTEST_AVAIL 0) set(FLANG_GTEST_AVAIL 0)
if (FLANG_INCLUDE_TESTS) if (FLANG_INCLUDE_TESTS)
set(UNITTEST_DIR ${LLVM_BUILD_MAIN_SRC_DIR}/utils/unittest) set(UNITTEST_DIR ${LLVM_BUILD_MAIN_SRC_DIR}/utils/unittest)
if(EXISTS ${UNITTEST_DIR}/googletest/include/gtest/gtest.h) if(EXISTS ${UNITTEST_DIR}/googletest/include/gtest/gtest.h)
if (NOT TARGET gtest) if (NOT TARGET llvm_gtest)
add_library(gtest add_library(llvm_gtest
${UNITTEST_DIR}/googletest/src/gtest-all.cc ${UNITTEST_DIR}/googletest/src/gtest-all.cc
${UNITTEST_DIR}/googlemock/src/gmock-all.cc ${UNITTEST_DIR}/googlemock/src/gmock-all.cc
) )
target_include_directories(gtest target_include_directories(llvm_gtest
PUBLIC PUBLIC
"${UNITTEST_DIR}/googletest/include" "${UNITTEST_DIR}/googletest/include"
"${UNITTEST_DIR}/googlemock/include" "${UNITTEST_DIR}/googlemock/include"
PRIVATE PRIVATE
"${UNITTEST_DIR}/googletest" "${UNITTEST_DIR}/googletest"
"${UNITTEST_DIR}/googlemock" "${UNITTEST_DIR}/googlemock"
) )
find_package(Threads) find_package(Threads)
target_link_libraries(gtest PUBLIC Threads::Threads) target_link_libraries(llvm_gtest PUBLIC Threads::Threads)
add_library(gtest_main ${UNITTEST_DIR}/UnitTestMain/TestMain.cpp) add_library(llvm_gtest_main ${UNITTEST_DIR}/UnitTestMain/TestMain.cpp)
target_link_libraries(gtest_main PUBLIC gtest) target_link_libraries(gtest_main PUBLIC llvm_gtest)
endif() endif()
set(FLANG_GTEST_AVAIL 1) set(FLANG_GTEST_AVAIL 1)
else() else()
message(WARNING message(WARNING
"Unit-tests will be skipped as LLVM install does not include google-test related headers and libraries.") "Unit-tests will be skipped as LLVM install does not include google-test related headers and libraries.")
set(FLANG_GTEST_AVAIL 0) set(FLANG_GTEST_AVAIL 0)
endif() endif()
endif() endif()
▲ Show 20 Lines • Show All 285 Lines • ▼ Show 20 Lines install(DIRECTORY include/flang
FILES_MATCHING FILES_MATCHING
PATTERN "*.def" PATTERN "*.def"
PATTERN "*.h" PATTERN "*.h"
PATTERN "*.inc" PATTERN "*.inc"
PATTERN "*.td" PATTERN "*.td"
PATTERN "config.h" EXCLUDE PATTERN "config.h" EXCLUDE
PATTERN ".git" EXCLUDE PATTERN ".git" EXCLUDE
PATTERN "CMakeFiles" EXCLUDE) PATTERN "CMakeFiles" EXCLUDE)
install(DIRECTORY ${FLANG_INCLUDE_DIR}/flang install(DIRECTORY ${FLANG_INCLUDE_DIR}/flang
DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}" DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}"
COMPONENT flang-headers COMPONENT flang-headers
FILES_MATCHING FILES_MATCHING
PATTERN "*.inc" PATTERN "*.inc"
) )
endif() endif()

libc/benchmarks/CMakeLists.txt

Show All 19 Linesfunction(add_libc_benchmark_unittest target_name)
) )
add_executable(${target_name} add_executable(${target_name}
EXCLUDE_FROM_ALL EXCLUDE_FROM_ALL
${LIBC_BENCHMARKS_UNITTEST_SRCS} ${LIBC_BENCHMARKS_UNITTEST_SRCS}
) )
target_link_libraries(${target_name} target_link_libraries(${target_name}
PRIVATE PRIVATE
gtest_main llvm_gtest_main
gtest llvm_gtest
${LIBC_BENCHMARKS_UNITTEST_DEPENDS} ${LIBC_BENCHMARKS_UNITTEST_DEPENDS}
) )
llvm_update_compile_flags(${target_name}) llvm_update_compile_flags(${target_name})
add_custom_command( add_custom_command(
TARGET ${target_name} TARGET ${target_name}
POST_BUILD POST_BUILD
COMMAND $<TARGET_FILE:${target_name}> COMMAND $<TARGET_FILE:${target_name}>
▲ Show 20 Lines • Show All 131 Lines • Show Last 20 Lines

libc/test/utils/tools/CMakeLists.txt

Show All 10 Linesfunction(add_libc_tool_unittest target_name)
) )
add_executable(${target_name} add_executable(${target_name}
EXCLUDE_FROM_ALL EXCLUDE_FROM_ALL
${LIBC_TOOL_UNITTEST_SRCS} ${LIBC_TOOL_UNITTEST_SRCS}
) )
target_link_libraries(${target_name} target_link_libraries(${target_name}
PRIVATE PRIVATE
gtest_main llvm_gtest_main
gtest llvm_gtest
${LIBC_TOOL_UNITTEST_DEPENDS} ${LIBC_TOOL_UNITTEST_DEPENDS}
) )
add_custom_command( add_custom_command(
TARGET ${target_name} TARGET ${target_name}
POST_BUILD POST_BUILD
COMMAND $<TARGET_FILE:${target_name}> COMMAND $<TARGET_FILE:${target_name}>
${LIBC_TOOL_UNITTEST_ARGS} ${LIBC_TOOL_UNITTEST_ARGS}
) )
add_dependencies(libc-tool-unittests ${target_name}) add_dependencies(libc-tool-unittests ${target_name})
target_compile_options(${target_name} PUBLIC -fno-rtti) target_compile_options(${target_name} PUBLIC -fno-rtti)
target_link_libraries(${target_name} PRIVATE LLVMSupport) target_link_libraries(${target_name} PRIVATE LLVMSupport)
endfunction() endfunction()
add_subdirectory(WrapperGen) add_subdirectory(WrapperGen)

lldb/unittests/CMakeLists.txt

Show All 14 Linesif (MSVC)
list(APPEND LLVM_COMPILE_FLAGS /FI ${LLDB_GTEST_COMMON_INCLUDE}) list(APPEND LLVM_COMPILE_FLAGS /FI ${LLDB_GTEST_COMMON_INCLUDE})
else () else ()
list(APPEND LLVM_COMPILE_FLAGS -include ${LLDB_GTEST_COMMON_INCLUDE}) list(APPEND LLVM_COMPILE_FLAGS -include ${LLDB_GTEST_COMMON_INCLUDE})
endif () endif ()
if (LLDB_BUILT_STANDALONE) if (LLDB_BUILT_STANDALONE)
# Build the gtest library needed for unittests, if we have LLVM sources # Build the gtest library needed for unittests, if we have LLVM sources
# handy. # handy.
if (EXISTS ${LLVM_MAIN_SRC_DIR}/utils/unittest AND NOT TARGET gtest) if (EXISTS ${LLVM_MAIN_SRC_DIR}/utils/unittest AND NOT TARGET llvm_gtest)
add_subdirectory(${LLVM_MAIN_SRC_DIR}/utils/unittest utils/unittest) add_subdirectory(${LLVM_MAIN_SRC_DIR}/utils/unittest utils/unittest)
endif() endif()
# LLVMTestingSupport library is needed for Process/gdb-remote. # LLVMTestingSupport library is needed for Process/gdb-remote.
if (EXISTS ${LLVM_MAIN_SRC_DIR}/lib/Testing/Support if (EXISTS ${LLVM_MAIN_SRC_DIR}/lib/Testing/Support
AND NOT TARGET LLVMTestingSupport) AND NOT TARGET LLVMTestingSupport)
add_subdirectory(${LLVM_MAIN_SRC_DIR}/lib/Testing/Support add_subdirectory(${LLVM_MAIN_SRC_DIR}/lib/Testing/Support
lib/Testing/Support) lib/Testing/Support)
endif() endif()
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines

llvm/cmake/modules/AddLLVM.cmake

Show First 20 Lines • Show All 1,496 Lines • ▼ Show 20 Lines if(LLVM_ENABLE_LTO)
endif() endif()
endif() endif()
set(outdir ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}) set(outdir ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR})
set_output_directory(${test_name} BINARY_DIR ${outdir} LIBRARY_DIR ${outdir}) set_output_directory(${test_name} BINARY_DIR ${outdir} LIBRARY_DIR ${outdir})
# libpthreads overrides some standard library symbols, so main # libpthreads overrides some standard library symbols, so main
# executable must be linked with it in order to provide consistent # executable must be linked with it in order to provide consistent
# API for all shared libaries loaded by this executable. # API for all shared libaries loaded by this executable.
target_link_libraries(${test_name} PRIVATE gtest_main gtest ${LLVM_PTHREAD_LIB}) target_link_libraries(${test_name} PRIVATE llvm_gtest_main llvm_gtest ${LLVM_PTHREAD_LIB})
add_dependencies(${test_suite} ${test_name}) add_dependencies(${test_suite} ${test_name})
get_target_property(test_suite_folder ${test_suite} FOLDER) get_target_property(test_suite_folder ${test_suite} FOLDER)
if (test_suite_folder) if (test_suite_folder)
set_property(TARGET ${test_name} PROPERTY FOLDER "${test_suite_folder}") set_property(TARGET ${test_name} PROPERTY FOLDER "${test_suite_folder}")
endif () endif ()
endfunction() endfunction()
▲ Show 20 Lines • Show All 717 Lines • Show Last 20 Lines

llvm/lib/Testing/Support/CMakeLists.txt

add_llvm_library(LLVMTestingSupport add_llvm_library(LLVMTestingSupport
Annotations.cpp Annotations.cpp
Error.cpp Error.cpp
SupportHelpers.cpp SupportHelpers.cpp
BUILDTREE_ONLY BUILDTREE_ONLY
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${LLVM_MAIN_INCLUDE_DIR}/llvm/Testing/Support ${LLVM_MAIN_INCLUDE_DIR}/llvm/Testing/Support
LINK_COMPONENTS LINK_COMPONENTS
Support Support
) )
target_link_libraries(LLVMTestingSupport PRIVATE gtest) target_link_libraries(LLVMTestingSupport PRIVATE llvm_gtest)
# This is to avoid the error in gtest-death-test-internal.h # This is to avoid the error in gtest-death-test-internal.h
# (150,16): error: 'Create' overrides a member function but # (150,16): error: 'Create' overrides a member function but
# is not marked 'override' [-Werror,-Wsuggest-override] # is not marked 'override' [-Werror,-Wsuggest-override]
# during self-compile on Windows. # during self-compile on Windows.
if (HOST_WINNT AND "${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" ) if (HOST_WINNT AND "${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" )
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-suggest-override") SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-suggest-override")
endif() endif()

llvm/runtimes/CMakeLists.txt

Show First 20 Lines • Show All 474 Lines • ▼ Show 20 Lines set(RUNTIMES_TEST_DEPENDS
count count
llvm-nm llvm-nm
llvm-objdump llvm-objdump
llvm-xray llvm-xray
not not
obj2yaml obj2yaml
sancov sancov
sanstats sanstats
gtest_main llvm_gtest_main
gtest llvm_gtest
) )
foreach(target ${test_targets} ${SUB_CHECK_TARGETS}) foreach(target ${test_targets} ${SUB_CHECK_TARGETS})
add_dependencies(${target} ${RUNTIMES_TEST_DEPENDS}) add_dependencies(${target} ${RUNTIMES_TEST_DEPENDS})
endforeach() endforeach()
endif() endif()
endif() endif()

llvm/unittests/Support/CommandLineInit/CMakeLists.txt

Show All 20 Lines
endif() endif()
list(APPEND LLVM_LINK_COMPONENTS Support) list(APPEND LLVM_LINK_COMPONENTS Support)
add_llvm_executable(${test_name} add_llvm_executable(${test_name}
IGNORE_EXTERNALIZE_DEBUGINFO NO_INSTALL_RPATH IGNORE_EXTERNALIZE_DEBUGINFO NO_INSTALL_RPATH
CommandLineInitTest.cpp) CommandLineInitTest.cpp)
target_link_libraries(${test_name} PRIVATE gtest) target_link_libraries(${test_name} PRIVATE llvm_gtest)
add_dependencies(${test_suite} ${test_name}) add_dependencies(${test_suite} ${test_name})
set(outdir ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}) set(outdir ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR})
set_output_directory(${test_name} BINARY_DIR ${outdir} LIBRARY_DIR ${outdir}) set_output_directory(${test_name} BINARY_DIR ${outdir} LIBRARY_DIR ${outdir})
get_target_property(test_suite_folder ${test_suite} FOLDER) get_target_property(test_suite_folder ${test_suite} FOLDER)
if (test_suite_folder) if (test_suite_folder)
set_property(TARGET ${test_name} PROPERTY FOLDER "${test_suite_folder}") set_property(TARGET ${test_name} PROPERTY FOLDER "${test_suite_folder}")
endif () endif ()

llvm/utils/unittest/CMakeLists.txt

Show All 33 Lines
set(LLVM_REQUIRES_RTTI 1) set(LLVM_REQUIRES_RTTI 1)
add_definitions( -DGTEST_HAS_RTTI=0 ) add_definitions( -DGTEST_HAS_RTTI=0 )
find_library(LLVM_PTHREAD_LIBRARY_PATH pthread) find_library(LLVM_PTHREAD_LIBRARY_PATH pthread)
if (LLVM_PTHREAD_LIBRARY_PATH) if (LLVM_PTHREAD_LIBRARY_PATH)
list(APPEND LIBS pthread) list(APPEND LIBS pthread)
endif() endif()
add_llvm_library(gtest add_llvm_library(llvm_gtest
googletest/src/gtest-all.cc googletest/src/gtest-all.cc
googlemock/src/gmock-all.cc googlemock/src/gmock-all.cc
LINK_LIBS LINK_LIBS
${LIBS} ${LIBS}
LINK_COMPONENTS LINK_COMPONENTS
Support # Depends on llvm::raw_ostream Support # Depends on llvm::raw_ostream
# This is a library meant only for the build tree. # This is a library meant only for the build tree.
BUILDTREE_ONLY BUILDTREE_ONLY
) )
# The googletest and googlemock sources don't presently use the 'override' # The googletest and googlemock sources don't presently use the 'override'
# keyword, which leads to lots of warnings from -Wsuggest-override. Disable # keyword, which leads to lots of warnings from -Wsuggest-override. Disable
# that warning here for any targets that link to gtest. # that warning here for any targets that link to gtest.
if(CXX_SUPPORTS_SUGGEST_OVERRIDE_FLAG) if(CXX_SUPPORTS_SUGGEST_OVERRIDE_FLAG)
add_definitions("-Wno-suggest-override") add_definitions("-Wno-suggest-override")
set_target_properties(gtest PROPERTIES INTERFACE_COMPILE_OPTIONS "-Wno-suggest-override") set_target_properties(llvm_gtest PROPERTIES INTERFACE_COMPILE_OPTIONS "-Wno-suggest-override")
endif() endif()
if (NOT LLVM_ENABLE_THREADS) if (NOT LLVM_ENABLE_THREADS)
target_compile_definitions(gtest PUBLIC GTEST_HAS_PTHREAD=0) target_compile_definitions(llvm_gtest PUBLIC GTEST_HAS_PTHREAD=0)
endif () endif ()
target_include_directories(gtest target_include_directories(llvm_gtest
PUBLIC googletest/include googlemock/include PUBLIC googletest/include googlemock/include
PRIVATE googletest googlemock PRIVATE googletest googlemock
) )
add_subdirectory(UnitTestMain) add_subdirectory(UnitTestMain)
# When LLVM_LINK_LLVM_DYLIB is enabled, libLLVM.so is added to the interface # When LLVM_LINK_LLVM_DYLIB is enabled, libLLVM.so is added to the interface
# link libraries for gtest and gtest_main. This means that any target, like # link libraries for gtest and gtest_main. This means that any target, like
# unittests for example, that links against gtest will be forced to link # unittests for example, that links against gtest will be forced to link
# against libLLVM.so. In some cases we may want to statically unittests if they # against libLLVM.so. In some cases we may want to statically unittests if they
# need access to symbols that are marked private in libLLVM.so. The only # need access to symbols that are marked private in libLLVM.so. The only
# way we can make this work is to remove libLLVM.so from the list of interface # way we can make this work is to remove libLLVM.so from the list of interface
# link libraries for gtest and then make gtest users responsible for explicitly # link libraries for gtest and then make gtest users responsible for explicitly
# adding libLLVM.so to their targets link libraries if they need it. # adding libLLVM.so to their targets link libraries if they need it.
function (gtest_remove_dylib_from_link_interface target) function (gtest_remove_dylib_from_link_interface target)
get_target_property(interface_libs ${target} INTERFACE_LINK_LIBRARIES) get_target_property(interface_libs ${target} INTERFACE_LINK_LIBRARIES)
if (interface_libs) if (interface_libs)
list(REMOVE_ITEM interface_libs LLVM) list(REMOVE_ITEM interface_libs LLVM)
set_target_properties(${target} PROPERTIES INTERFACE_LINK_LIBRARIES "${interface_libs}") set_target_properties(${target} PROPERTIES INTERFACE_LINK_LIBRARIES "${interface_libs}")
endif() endif()
endfunction() endfunction()
gtest_remove_dylib_from_link_interface(gtest) gtest_remove_dylib_from_link_interface(llvm_gtest)
gtest_remove_dylib_from_link_interface(gtest_main) gtest_remove_dylib_from_link_interface(llvm_gtest_main)

llvm/utils/unittest/UnitTestMain/CMakeLists.txt

add_llvm_library(gtest_main add_llvm_library(llvm_gtest_main
TestMain.cpp TestMain.cpp
LINK_LIBS LINK_LIBS
gtest llvm_gtest
LINK_COMPONENTS LINK_COMPONENTS
Support # Depends on llvm::cl Support # Depends on llvm::cl
# This library is not meant to be in the install tree, only the build tree. # This library is not meant to be in the install tree, only the build tree.
BUILDTREE_ONLY BUILDTREE_ONLY
) )