This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][Presburger] Move IdKind specific insert/append
ClosedPublic

Authored by Groverkss on Feb 25 2022, 10:55 AM.

Details

Summary

This patch moves identifier kind specific insert/append functions like
insertDimId, appendSymbolId, etc. from IntegerPolyhedron to
FlatAffineConstraints.

This change allows for a smoother transition to IntegerRelation.

This change is part of a series of patches to introduce Relations in Presburger
library.

Diff Detail

Event Timeline

Groverkss created this revision.Feb 25 2022, 10:55 AM
Groverkss requested review of this revision.Feb 25 2022, 10:55 AM
arjunp added inline comments.Feb 25 2022, 11:05 AM
mlir/include/mlir/Analysis/Presburger/PresburgerSpace.h
28

If this is going to be exposed in presburger directly it may be better to make it an enum class

72–73

Why is this needed?

Groverkss updated this revision to Diff 411602.Feb 26 2022, 5:13 AM
Groverkss marked an inline comment as done.
  • Address Arjun's comments
Groverkss marked an inline comment as done.Feb 26 2022, 5:15 AM
Groverkss added inline comments.
mlir/include/mlir/Analysis/Presburger/PresburgerSpace.h
72–73

This was to allow FlatAffineConstraints and it's derivatives (which are out of presburger namespace) to refer to IdKind directly. Moved this to FlatAffineConstraints.

arjunp accepted this revision.Feb 26 2022, 5:23 AM

LGTM

This revision is now accepted and ready to land.Feb 26 2022, 5:23 AM
This revision was landed with ongoing or failed builds.Feb 26 2022, 5:55 AM
This revision was automatically updated to reflect the committed changes.
Groverkss marked an inline comment as done.