This is an archive of the discontinued LLVM Phabricator instance.

Avoid comparisons between types of different widths in a loop condition to prevent the loop from behaving unexpectedly
ClosedPublic

Authored by aakanksha555 on Feb 22 2022, 1:48 PM.

Details

Summary

This change fixes the code violations flagged in AMD compute CodeQL scan -
Query Description: "Comparisons between types of different widths in a loop condition can cause the loop to behave unexpectedly."

Diff Detail

Event Timeline

aakanksha555 created this revision.Feb 22 2022, 1:48 PM
aakanksha555 requested review of this revision.Feb 22 2022, 1:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 22 2022, 1:48 PM

Patch description is too vague

Please upload a full context diff.

This change fixes the code violations flagged in AMD compute CodeQL scan -

Query Description: "Comparisons between types of different widths in a loop condition can cause the loop to behave unexpectedly."

Update the description to something meaningful. This is also not AMDGPU.

aakanksha555 retitled this revision from [AMDGPU] Code improvements to Avoid comparisons between types of different widths in a loop condition to prevent the loop from behaving unexpectedly.Feb 24 2022, 4:56 PM
aakanksha555 edited the summary of this revision. (Show Details)
arsenm accepted this revision.Feb 25 2022, 7:50 AM
This revision is now accepted and ready to land.Feb 25 2022, 7:50 AM
This revision was landed with ongoing or failed builds.Feb 25 2022, 9:33 AM
This revision was automatically updated to reflect the committed changes.