TODO: merge flat load/stores.
TODO: merge flat with global promoting to flat.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Looks OK to me.
llvm/test/CodeGen/AMDGPU/soft-clause-exceeds-register-budget.ll | ||
---|---|---|
7 | What happened here? Autogenerating the checks for this file might make it clearer what actually changed. |
llvm/test/CodeGen/AMDGPU/soft-clause-exceeds-register-budget.ll | ||
---|---|---|
7 | There is a bunch of global stores at the end of the test. We have combined 2 more of them, which has changed register pressure. The estimate for the last block changed from 40 to 41. Consequentially that has changed the scheduling and a pack of 4 global loads was scheduled lower, while couple of scalar x16 loads was scheduled higher. I actually do not think that generating checks for ~400 instructions is beneficial. We will have to regenerate it often and it will obscure actual clauses. |
llvm/test/CodeGen/AMDGPU/soft-clause-exceeds-register-budget.ll | ||
---|---|---|
7 | Well it's still not clear to me that it's still testing whatever it was supposed to test. But I don't really mind. |
What happened here? Autogenerating the checks for this file might make it clearer what actually changed.