This is an archive of the discontinued LLVM Phabricator instance.

Differential D120249

[objcopy][NFC] Fixing linking issue for libLLVMObjCopy
AbandonedPublic

Authored by kito-cheng on Feb 21 2022, 5:56 AM.

Details

Reviewers
MaskRay
avl
jhenderson
Summary

This issue only appear on -DBUILD_SHARED_LIBS=On
llvm::COFF::encodeSectionName is hold in libLLVMBinaryFormat.

llvm-project/llvm/lib/ObjCopy/COFF/Writer.cpp:138: error: undefined reference to 'llvm::COFF::encodeSectionName(char*, unsigned long)'

Diff Detail

Event Timeline

kito-cheng created this revision.Feb 21 2022, 5:56 AM
Herald added subscribers: abrachet, hiraditya, mgorny. · View Herald TranscriptFeb 21 2022, 5:56 AM
kito-cheng requested review of this revision.Feb 21 2022, 5:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2022, 5:56 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kito-cheng added reviewers: MaskRay, avl, jhenderson.Feb 21 2022, 5:56 AM
jhenderson added a comment.Feb 21 2022, 6:12 AM

I think this has already been fixed. See https://reviews.llvm.org/D118692#3335374.

kito-cheng abandoned this revision.Feb 21 2022, 6:21 AM

Cool, thanks!

Harbormaster completed remote builds in B150684: Diff 410290.Feb 21 2022, 6:38 AM

Revision Contents

PathSize
llvm/
lib/
ObjCopy/
1 line

Diff 410290

llvm/lib/ObjCopy/CMakeLists.txt

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Linesadd_llvm_component_library(LLVMObjCopy
ELF ELF
MachO MachO
wasm wasm
DEPENDS DEPENDS
intrinsics_gen intrinsics_gen
LINK_COMPONENTS LINK_COMPONENTS
BinaryFormat
Object Object
Support Support
MC MC
) )