Remove unused includes

[clemenswasser]

Summary

Remove unused includes, that were identified as being quiet heavy by clang build analyzer, saves compilation time.

[MaskRay]

llvm/include/llvm/MCA/HWEventListener.h

69

ArrayRef is used

80

ArrayRef is used.

[clemenswasser]

llvm/include/llvm/MCA/HWEventListener.h

69

D120208 will forward declare ArrayRef. So this is currently blocked on it.

80

Same as above

[clemenswasser]

llvm/include/llvm/MCA/HWEventListener.h

69

Actually I think ArrayRef is already forward declared somewhere. We are however still blocked on D120208, since it will move some implementations from the header into the corresponding cpp files, which currently cause this build to fail.

[RKSimon]

llvm/include/llvm/MCA/HWEventListener.h

69

We need the full def, not just the forward declaration here though as we're actually instantiating ArrayRef<ResourceUse> in HWInstructionIssuedEvent, not just passing it in an arg.

It looks like you're depending on ArrayRef.h include from one of the remaining headers (well, both actually...), which the style guide allows, but we typically don't tend to rely on that unless we only require the local use of the def because of the other header.

https://llvm.org/docs/CodingStandards.html#include-as-little-as-possible

[clemenswasser]

llvm/include/llvm/MCA/HWEventListener.h

69

Oh, yes, you are totally right. Will remove this change.

[MaskRay]

llvm/include/llvm/IR/Intrinsics.h

18

This is needed.

llvm/lib/IR/Function.cpp

13

This is needed.

llvm/include/llvm/ADT/GenericCycleInfo.h

 /// - In the absence of irreducible control flow, the cycles are
 ///   exactly the natural loops in the program.
 ///
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_ADT_GENERICCYCLEINFO_H
 #define LLVM_ADT_GENERICCYCLEINFO_H
 
-#include "llvm/ADT/ArrayRef.h"
 #include "llvm/ADT/DenseMap.h"
 #include "llvm/ADT/GenericSSAContext.h"
 #include "llvm/ADT/GraphTraits.h"
 #include "llvm/ADT/SmallVector.h"
 #include "llvm/ADT/iterator.h"
 #include "llvm/Support/Debug.h"
 #include "llvm/Support/Printable.h"
 #include "llvm/Support/raw_ostream.h"

llvm/include/llvm/IR/InstVisitor.h

 //===- InstVisitor.h - Instruction visitor templates ------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 
 #ifndef LLVM_IR_INSTVISITOR_H
 #define LLVM_IR_INSTVISITOR_H
 
-#include "llvm/IR/Function.h"
-#include "llvm/IR/Instructions.h"
 #include "llvm/IR/IntrinsicInst.h"
 #include "llvm/IR/Intrinsics.h"
 #include "llvm/IR/Module.h"
 #include "llvm/Support/ErrorHandling.h"
 
 namespace llvm {
 
 // We operate on opaque instruction classes, so forward declare all instruction

llvm/include/llvm/IR/Instructions.h

 #include "llvm/ADT/iterator.h"
 #include "llvm/ADT/iterator_range.h"
 #include "llvm/IR/Attributes.h"
 #include "llvm/IR/BasicBlock.h"
 #include "llvm/IR/CFG.h"
 #include "llvm/IR/Constant.h"
 #include "llvm/IR/DerivedTypes.h"
 #include "llvm/IR/InstrTypes.h"
-#include "llvm/IR/Instruction.h"
 #include "llvm/IR/OperandTraits.h"
 #include "llvm/IR/Type.h"
 #include "llvm/IR/Use.h"
 #include "llvm/IR/User.h"
 #include "llvm/IR/Value.h"
 #include "llvm/Support/AtomicOrdering.h"
 #include "llvm/Support/Casting.h"
 #include "llvm/Support/ErrorHandling.h"

llvm/include/llvm/IR/Intrinsics.h

 // functions.  Values of these enum types are returned by
 // Function::getIntrinsicID.
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_IR_INTRINSICS_H
 #define LLVM_IR_INTRINSICS_H
 
-#include "llvm/ADT/ArrayRef.h"
 #include "llvm/ADT/None.h"
 #include "llvm/ADT/Optional.h"
 #include "llvm/Support/TypeSize.h"
 #include <string>
 
 namespace llvm {
 
 class Type;

llvm/include/llvm/InterfaceStub/IFSStub.h

 //===- IFSStub.h ------------------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===-----------------------------------------------------------------------===/
 ///
 /// \file
 /// This file defines an internal representation of an InterFace Stub.
 ///
 //===-----------------------------------------------------------------------===/
 
 #ifndef LLVM_INTERFACESTUB_IFSSTUB_H
 #define LLVM_INTERFACESTUB_IFSSTUB_H
 
-#include "llvm/Support/Error.h"
 #include "llvm/Support/VersionTuple.h"
 #include <set>
 #include <vector>
 
 namespace llvm {
 namespace ifs {
 
 typedef uint16_t IFSArch;

llvm/include/llvm/MCA/HWEventListener.h

 //===----------------------- HWEventListener.h ------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 /// \file
 ///
 /// This file defines the main interface for hardware event listeners.
 ///
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_MCA_HWEVENTLISTENER_H
 #define LLVM_MCA_HWEVENTLISTENER_H
 
-#include "llvm/ADT/ArrayRef.h"
 #include "llvm/MCA/Instruction.h"
 #include "llvm/MCA/Support.h"
 
 namespace llvm {
 namespace mca {
 
 // An HWInstructionEvent represents state changes of instructions that
 // listeners might be interested in. Listeners can choose to ignore any event

 using ResourceRef = std::pair<uint64_t, uint64_t>;
 using ResourceUse = std::pair<ResourceRef, ResourceCycles>;
 
 class HWInstructionIssuedEvent : public HWInstructionEvent {
 public:
   HWInstructionIssuedEvent(const InstRef &IR, ArrayRef<ResourceUse> UR)
       : HWInstructionEvent(HWInstructionEvent::Issued, IR), UsedResources(UR) {}
 
   ArrayRef<ResourceUse> UsedResources;
 };
 
 class HWInstructionDispatchedEvent : public HWInstructionEvent {
 public:
   HWInstructionDispatchedEvent(const InstRef &IR, ArrayRef<unsigned> Regs,
                                unsigned UOps)
       : HWInstructionEvent(HWInstructionEvent::Dispatched, IR),
         UsedPhysRegs(Regs), MicroOpcodes(UOps) {}
   // Number of physical register allocated for this instruction. There is one
   // entry per register file.
   ArrayRef<unsigned> UsedPhysRegs;
   // Number of micro opcodes dispatched.
   // This field is often set to the total number of micro-opcodes specified by
   // the instruction descriptor of IR.
   // The only exception is when IR declares a number of micro opcodes
   // which exceeds the processor DispatchWidth, and - by construction - it
   // requires multiple cycles to be fully dispatched. In that particular case,
   // the dispatch logic would generate more than one dispatch event (one per
   // cycle), and each event would declare how many micro opcodes are effectively

llvm/include/llvm/MCA/View.h

 /// This file defines the main interface for Views. Each view contributes a
 /// portion of the final report generated by the tool.
 ///
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_MCA_VIEW_H
 #define LLVM_MCA_VIEW_H
 
-#include "llvm/MC/MCInstPrinter.h"
 #include "llvm/MCA/HWEventListener.h"
 #include "llvm/Support/JSON.h"
 #include "llvm/Support/raw_ostream.h"
 
 namespace llvm {
 namespace mca {
 
 class View : public HWEventListener {

llvm/lib/IR/Function.cpp

 //===- Function.cpp - Implement the Global object classes -----------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the Function class for the IR library.
 //
 //===----------------------------------------------------------------------===//
 
-#include "llvm/IR/Function.h"
 #include "SymbolTableListTraitsImpl.h"
 #include "llvm/ADT/ArrayRef.h"
 #include "llvm/ADT/DenseSet.h"
 #include "llvm/ADT/None.h"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/SmallString.h"
 #include "llvm/ADT/SmallVector.h"
 #include "llvm/ADT/StringExtras.h"