Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
But, apparently, some other improvements to other optimizations passes
have also solved the problem, because, as the diff shows, reverting D99249
does not resurface the original problem, since, clearly, the check lines
for the new-pm and -O2/-O3 are not affected.
Do you have any idea what could have caused this? I find it particularly odd that this is solved for the NewPM but not the OldPM (I don't think we added any pipeline divergences recently...)
llvm/test/Other/new-pm-defaults.ll | ||
---|---|---|
169–170 | A bit confused here: Why does this become O23SZ rather than being dropped entirely? | |
llvm/test/Transforms/PhaseOrdering/X86/speculation-vs-tbaa.ll | ||
12 | Not strictly necessary, but it would be preferable if this test showed an actual optimization impact (as alluded in https://github.com/llvm/llvm-project/issues/53794#issuecomment-1037460605) rather than just the fact that TBAA is preserved (which is best-effort). |
A bit confused here: Why does this become O23SZ rather than being dropped entirely?