Refactor the instructions in M68kInstrControl.td to use the VarLenCodeEmitter.
This patch is tested by the existing test cases.
Paths
| Differential D119665
[M68k] Adopt VarLenCodeEmitter for control instructions ClosedPublic Authored by 0x59616e on Feb 13 2022, 7:31 AM.
Details Summary Refactor the instructions in M68kInstrControl.td to use the VarLenCodeEmitter. This patch is tested by the existing test cases.
Diff Detail
Unit TestsFailed Event Timeline0x59616e added a parent revision: D119100: [TableGen] Add a new `encoder` directive into VarLenCodeEmitterGen.Feb 13 2022, 7:32 AM 0x59616e retitled this revision from [WIP][M68k] Adopt VarLenCodeEmitter for control instructions to [M68k] Adopt VarLenCodeEmitter for control instructions.Feb 13 2022, 5:02 PM Comment Actions Thanks for this, I'm really enjoying the new syntax, it's so much easier to follow. I'm a little bit unsure about the test change.
Comment Actions LGTM. Might be worth waiting for @myhsu to review, but I don't think there's anything controversial. Thanks! 😄 This revision is now accepted and ready to land.Feb 15 2022, 5:52 AM Comment Actions Thanks for the patch :-)
This revision now requires changes to proceed.Feb 15 2022, 12:46 PM Comment Actions LGTM
This revision is now accepted and ready to land.Feb 15 2022, 8:28 PM This revision was landed with ongoing or failed builds.Feb 15 2022, 8:54 PM Closed by commit rG9ffd498fcbd9: [M68k] Adopt VarLenCodeEmitter for control instructions (authored by 0x59616e). · Explain Why This revision was automatically updated to reflect the committed changes. 0x59616e added a reverting change: rG69a7d49de6a0: Revert "[M68k] Adopt VarLenCodeEmitter for control instructions".Feb 16 2022, 1:09 AM
Revision Contents
Diff 408833 llvm/lib/Target/M68k/M68kInstrControl.td
llvm/test/MC/M68k/Control/call-pc-rel.s
|
nit: Any reason you've split this up by byte? Generally the manuals I've read have it as one string of bits (I wonder if the bit syntax supports underscores).