This is an archive of the discontinued LLVM Phabricator instance.

Differential D119626

[llvm] Add missind dep on Symbolize to Debuginfod
ClosedPublic

Authored by yannic on Feb 12 2022, 4:32 AM.

Details

Reviewers
echristo
dblaikie
phosek
Group Reviewers
debug-info
Commits
rG6694491affa1: [llvm] Add missind dep on Symbolize to Debuginfod
Summary

llvm/Debuginfod/DIFetcher.h imports llvm/DebugInfo/Symbolize/DIFetcher.h,
so there should be a dependency on Symbolize.

Diff Detail

Unit TestsFailed

TimeTest
60,100 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
60,130 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vloxseg.c
60,140 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vluxseg.c
60,100 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-overloaded::vloxseg.c
60,170 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-overloaded::vluxseg.c

Event Timeline

yannic created this revision.Feb 12 2022, 4:32 AM
Herald added subscribers: hiraditya, mgorny. · View Herald TranscriptFeb 12 2022, 4:32 AM
yannic requested review of this revision.Feb 12 2022, 4:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 12 2022, 4:32 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B149205: Diff 408173.Feb 12 2022, 5:12 AM
dblaikie accepted this revision.Feb 12 2022, 10:31 AM
dblaikie added subscribers: phosek, dblaikie.

@phosek FYI in case this wasn't the intended layering.

This revision is now accepted and ready to land.Feb 12 2022, 10:31 AM
phosek accepted this revision.Feb 12 2022, 10:22 PM

LGTM

yannic added a comment.Feb 13 2022, 8:38 AM

Thanks for your reviews! I don't have commit access to LLVM, could you help me landing this please?

This revision was landed with ongoing or failed builds.Feb 20 2022, 12:35 PM
Closed by commit rG6694491affa1: [llvm] Add missind dep on Symbolize to Debuginfod (authored by yannic, committed by dblaikie). · Explain Why
This revision was automatically updated to reflect the committed changes.
dblaikie added a commit: rG6694491affa1: [llvm] Add missind dep on Symbolize to Debuginfod.

Revision Contents

PathSize
llvm/
lib/
Debuginfod/
1 line

Diff 408173

llvm/lib/Debuginfod/CMakeLists.txt

Show All 12 Linesadd_llvm_library(LLVMDebuginfod
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${LLVM_MAIN_INCLUDE_DIR}/llvm/Debuginfod ${LLVM_MAIN_INCLUDE_DIR}/llvm/Debuginfod
LINK_LIBS LINK_LIBS
${imported_libs} ${imported_libs}
LINK_COMPONENTS LINK_COMPONENTS
Support Support
Symbolize
) )