Details
Details
Diff Detail
Diff Detail
Event Timeline
libc/src/__support/CPP/Utility.h | ||
---|---|---|
22 | Does it work with T that is not int? Doesn't append<> take template parameter of type T? |
libc/src/__support/CPP/Utility.h | ||
---|---|---|
22 | Yes, added a test that it works with long |
libc/test/utils/CPP/integer_sequence_test.cpp | ||
---|---|---|
17 | I would recommend changing long to long long since on some platforms (specifically Windows) a long is 32 bits. The C standard specifies that long long is at least 64 bits, and so it's more portable. |
libc/test/utils/CPP/integer_sequence_test.cpp | ||
---|---|---|
17 | Not clear how the size of the integer type matters. |
Does it work with T that is not int? Doesn't append<> take template parameter of type T?