[libc] Create cpp::IntegerSequence analogous to std::integer_sequence

[lntue]

libc/src/__support/CPP/Utility.h

22

Does it work with T that is not int? Doesn't append<> take template parameter of type T?

[abrachet]

Add test with long, and static_assert that T is integral

[abrachet]

libc/src/__support/CPP/Utility.h

22

Yes, added a test that it works with long

[michaelrj]

libc/test/utils/CPP/integer_sequence_test.cpp

17 ↗

(On Diff #407899)

I would recommend changing long to long long since on some platforms (specifically Windows) a long is 32 bits. The C standard specifies that long long is at least 64 bits, and so it's more portable.

[sivachandra]

libc/test/utils/CPP/integer_sequence_test.cpp

17 ↗

(On Diff #407899)

Not clear how the size of the integer type matters.

[abrachet]

• Rebase
• Add test with unsigned type

libc/src/__support/CPP/CMakeLists.txt

 # TODO(michaelrj): separate the standalone_cpp library into individual targets.
 add_header_library(
   standalone_cpp
   HDRS
     Array.h
     ArrayRef.h
     Bit.h
     Bitset.h
     Functional.h
     Limits.h
     StringView.h
     TypeTraits.h
+    Utility.h
 )
 
 add_header_library(
   vector
   HDRS
     vector.h
   DEPENDS
     libc.include.stdlib
 )

libc/src/__support/CPP/Utility.h

+//===-- Analogous to <utility> ----------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_SUPPORT_CPP_UTILITY_H
+#define LLVM_LIBC_SRC_SUPPORT_CPP_UTILITY_H
+
+#include "src/__support/CPP/TypeTraits.h"
+
+namespace __llvm_libc::cpp {
+
+template <typename T, T... Seq> struct IntegerSequence {
+  static_assert(IsIntegral<T>::Value);
+  template <T Next> using append = IntegerSequence<T, Seq..., Next>;
+};
+
+namespace internal {
+
+template <typename T, int N> struct MakeIntegerSequence {
+  using type = typename MakeIntegerSequence<T, N - 1>::type::template append<N>;
+};
+
+template <typename T> struct MakeIntegerSequence<T, -1> {
+  using type = IntegerSequence<T>;
+};
+
+} // namespace internal
+
+template <typename T, int N>
+using MakeIntegerSequence =
+    typename internal::MakeIntegerSequence<T, N - 1>::type;
+
+} // namespace __llvm_libc::cpp
+
+#endif // LLVM_LIBC_SRC_SUPPORT_CPP_UTILITY_H

libc/test/src/__support/CPP/CMakeLists.txt

add_libc_unittest(
   vector_test
   SUITE
     libc_cpp_utils_unittests
   SRCS
     vector_test.cpp
   DEPENDS
     libc.src.__support.CPP.vector
 )
+
+add_libc_unittest(
+  int_seq_test
+  SUITE
+    libc_cpp_utils_unittests
+  SRCS
+    integer_sequence_test.cpp
+  DEPENDS
+    libc.src.__support.CPP.standalone_cpp
+)

libc/test/src/__support/CPP/integer_sequence_test.cpp

+//===-- Unittests for IntegerSequence -------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/__support/CPP/Utility.h"
+#include "utils/UnitTest/Test.h"
+
+using namespace __llvm_libc::cpp;
+
+TEST(LlvmLibcIntegerSequencetTest, Basic) {
+  EXPECT_TRUE((IsSameV<IntegerSequence<int>, MakeIntegerSequence<int, 0>>));
+  using ISeq = IntegerSequence<int, 0, 1, 2, 3>;
+  EXPECT_TRUE((IsSameV<ISeq, MakeIntegerSequence<int, 4>>));
+  using LSeq = IntegerSequence<long, 0, 1, 2, 3>;
+  EXPECT_TRUE((IsSameV<LSeq, MakeIntegerSequence<long, 4>>));
+  using ULLSeq = IntegerSequence<unsigned long long, 0ull, 1ull, 2ull, 3ull>;
+  EXPECT_TRUE((IsSameV<ULLSeq, MakeIntegerSequence<unsigned long long, 4>>));
+}
+
+template <typename T, T... Ts>
+bool checkArray(IntegerSequence<T, Ts...> seq) {
+  T arr[sizeof...(Ts)]{Ts...};
+
+  for (T i = 0; i < static_cast<T>(sizeof...(Ts)); i++)
+    if (arr[i] != i)
+      return false;
+
+  return true;
+}
+
+TEST(LlvmLibcIntegerSequencetTest, Many) {
+  EXPECT_TRUE(checkArray(MakeIntegerSequence<int, 100>{}));
+}