Fixing surplus assert condition in EvaluateTemporary

[zhouyizhou]

Summary

In LLVM/Clang Debug build, following code will trigger the assert to fire:

typedef bool Var;
bool foobool() {
return (bool().Var::~Var(), false);
}

I think the non record type temporary object should also be allowed here.
Thanks in advance

Zhouyi Zhou
[e-mail]

[efriedma]

I'm not sure this is the right fix. If we were handling the pseudo-destructor correctly, I would expect the following to compile successfully:

typedef bool Var;
constexpr bool foobool() {
	return (bool().Var::~Var(), false); 
}

[zhouyizhou]

In D119493#3403458, @efriedma wrote:

Thank Eli for your comment and guidance and sorry to have carelessly neglected your comment for 7 months!

I'm not sure this is the right fix. If we were handling the pseudo-destructor correctly, I would expect the following to compile successfully:

typedef bool Var;
constexpr bool foobool() {
	return (bool().Var::~Var(), false); 
}

Yes, g++ can compile above code successfully, while we can't.
I am going to try to fix above (I am a beginner who eager to learn ;-)

Cheers
Zhouyi

clang/lib/AST/ExprConstant.cpp

bool VisitLambdaExpr(const LambdaExpr *E) {
     return VisitConstructExpr(E);
   }
 };
 } // end anonymous namespace
 
 /// Evaluate an expression of record type as a temporary.
 static bool EvaluateTemporary(const Expr *E, LValue &Result, EvalInfo &Info) {
   assert(!E->isValueDependent());
-  assert(E->isPRValue() && E->getType()->isRecordType());
+  assert(E->isPRValue());
   return TemporaryExprEvaluator(Info, Result).Visit(E);
 }
 
 //===----------------------------------------------------------------------===//
 // Vector Evaluation
 //===----------------------------------------------------------------------===//
 
 namespace {

clang/test/AST/issue53741.cpp

+// RUN: %clang_cc1 -fsyntax-only %s -verify
+// expected-no-diagnostics 
+typedef bool Var;
+bool foobool() {
+  return (bool().Var::~Var(), false); 
+}
+
+