This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Move constBuidlerCall from to ArrayAttrBase
ClosedPublic

Authored by ftynse on Feb 7 2022, 1:28 AM.

Details

Summary

This makes it applicable to both ArrayAttr and its typed subclasses instead of
only the latter. There is no good reason why ArrayAttr shouldn't be
const-buildable while its typed subclasses are, this was likely just an
omission.

Depends On D119113

Diff Detail

Event Timeline

ftynse created this revision.Feb 7 2022, 1:28 AM
ftynse requested review of this revision.Feb 7 2022, 1:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2022, 1:28 AM
rriddle accepted this revision.Feb 7 2022, 11:27 AM
This revision is now accepted and ready to land.Feb 7 2022, 11:27 AM

nit: Looks like a typo in the commit title.

nicolasvasilache accepted this revision.Feb 7 2022, 11:49 AM
This revision was automatically updated to reflect the committed changes.