[NFC][Analyzer] Use range based for loop.

[junaire]

Summary

Use range base loop loop to improve code readability.

[steakhal]

Hmm, I guess you must take it by mutable reference since you push it to LocalTUDecls.
Thanks for the patch. Do you have push permissions? Otherwise, send me your name <email> to let me commit this on your behalf.

Do you plan to clean up other loops as well?

[junaire]

In D119103#3300037, @steakhal wrote:

Hmm, I guess you must take it by mutable reference since you push it to LocalTUDecls.
Thanks for the patch. Do you have push permissions? Otherwise, send me your name <email> to let me commit this on your behalf.

Thanks for the feedback! I have commit access so I can push it on my own. :^)

Do you plan to clean up other loops as well?

I'm a student and I'm learning clang static analyzer so I may send more patches. (of course including cleaning up work like this one)

clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp

bool AnalysisConsumer::HandleTopLevelDecl(DeclGroupRef DG) {
   return true;
 }
 
 void AnalysisConsumer::HandleTopLevelDeclInObjCContainer(DeclGroupRef DG) {
   storeTopLevelDecls(DG);
 }
 
 void AnalysisConsumer::storeTopLevelDecls(DeclGroupRef DG) {
-  for (DeclGroupRef::iterator I = DG.begin(), E = DG.end(); I != E; ++I) {
+  for (auto &I : DG) {
 
     // Skip ObjCMethodDecl, wait for the objc container to avoid
     // analyzing twice.
-    if (isa<ObjCMethodDecl>(*I))
+    if (isa<ObjCMethodDecl>(I))
       continue;
 
-    LocalTUDecls.push_back(*I);
+    LocalTUDecls.push_back(I);
   }
 }
 
 static bool shouldSkipFunction(const Decl *D,
                                const SetOfConstDecls &Visited,
                                const SetOfConstDecls &VisitedAsTopLevel) {
   if (VisitedAsTopLevel.count(D))
     return true;
void AnalysisConsumer::HandleDeclsCallGraph(const unsigned LocalTUDeclsSize) {
   // analyze parents before the children. Skip the functions inlined into
   // the previously processed functions. Use external Visited set to identify
   // inlined functions. The topological order allows the "do not reanalyze
   // previously inlined function" performance heuristic to be triggered more
   // often.
   SetOfConstDecls Visited;
   SetOfConstDecls VisitedAsTopLevel;
   llvm::ReversePostOrderTraversal<clang::CallGraph*> RPOT(&CG);
-  for (llvm::ReversePostOrderTraversal<clang::CallGraph*>::rpo_iterator
-         I = RPOT.begin(), E = RPOT.end(); I != E; ++I) {
+  for (auto &N : RPOT) {
     NumFunctionTopLevel++;
 
-    CallGraphNode *N = *I;
     Decl *D = N->getDecl();
 
     // Skip the abstract root node.
     if (!D)
       continue;
 
     // Skip the functions which have been processed already or previously
     // inlined.