[libc++] Mark some members private in experimental/functional

[jloser]

Summary

Some members are public but should be private. Nothing requires they are public
right now, so make them private.

[philnik]

Does anybody know why this wasn't private in the first place?

[jloser]

In D119097#3299776, @philnik wrote:

Does anybody know why this wasn't private in the first place?

@mclow.lists may know, but I do not. :)

[ldionne]

If CI is happy, I think this is good to go.

libcxx/include/experimental/functional

make_default_searcher( _ForwardIterator __f, _ForwardIterator __l, _BinaryPredicate __p = _BinaryPredicate ())
     return default_searcher<_ForwardIterator, _BinaryPredicate>(__f, __l, __p);
 }
 
 template<class _Key, class _Value, class _Hash, class _BinaryPredicate, bool /*useArray*/> class _BMSkipTable;
 
 //  General case for BM data searching; use a map
 template<class _Key, typename _Value, class _Hash, class _BinaryPredicate>
 class _BMSkipTable<_Key, _Value, _Hash, _BinaryPredicate, false> {
-public: // TODO private:
     typedef _Value value_type;
     typedef _Key   key_type;
 
     const _Value __default_value_;
     std::unordered_map<_Key, _Value, _Hash, _BinaryPredicate> __table;
 
 public:
     _LIBCPP_INLINE_VISIBILITY
public:
     //  If the pattern is larger than the corpus, we can't find it!
         if ( __pattern_length_ > _VSTD::distance(__f, __l))
             return make_pair(__l, __l);
 
     //  Do the search
         return this->__search(__f, __l);
     }
 
-public: // TODO private:
+private:
     _RandomAccessIterator1               __first_;
     _RandomAccessIterator1               __last_;
     _BinaryPredicate                     __pred_;
     difference_type                      __pattern_length_;
     shared_ptr<skip_table_type>          __skip_;
     shared_ptr<vector<difference_type>>  __suffix_;
 
     template <typename _RandomAccessIterator2>