This is an archive of the discontinued LLVM Phabricator instance.

Differential D119042

[BOLT-UnitTests] Fix shared libraries build
ClosedPublic

Authored by Amir on Feb 4 2022, 3:05 PM.

Details

Reviewers
maksfb
rafauler
yota9
Commits
rGeddf38496556: [BOLT-UnitTests] Fix shared libraries build
Summary

Fix build with -DBUILD_SHARED_LIBS=ON (add explicit deps).

Diff Detail

Event Timeline

Amir created this revision.Feb 4 2022, 3:05 PM
Herald added subscribers: ayermolo, mgorny. · View Herald TranscriptFeb 4 2022, 3:05 PM
Amir requested review of this revision.Feb 4 2022, 3:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2022, 3:05 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
yota9 accepted this revision.Feb 4 2022, 3:10 PM

Thanks! I'm not aware of buildbot infrastructure, but how do you think is it possible to enable shared libs build checker?

This revision is now accepted and ready to land.Feb 4 2022, 3:10 PM
Harbormaster completed remote builds in B147724: Diff 406114.Feb 4 2022, 3:10 PM
Amir added a comment.Feb 4 2022, 3:18 PM
In D119042#3298219, @yota9 wrote:

Thanks! I'm not aware of buildbot infrastructure, but how do you think is it possible to enable shared libs build checker?

This build configuration is enabled on a shadow buildbot: http://157.230.108.44:8011/#/builders/42
It's not tracked on the default buildbot (it's only capable of one build configuration without collapsing requests, plus it builds clang and lld to monitor breakages).

yota9 added a comment.Feb 4 2022, 3:21 PM

@Amir Thanks! I will look over there from time to time :))

This revision was landed with ongoing or failed builds.Feb 4 2022, 6:01 PM
Closed by commit rGeddf38496556: [BOLT-UnitTests] Fix shared libraries build (authored by Amir). · Explain Why
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rGeddf38496556: [BOLT-UnitTests] Fix shared libraries build.

Revision Contents

PathSize
bolt/
unittests/
Core/
14 lines

Diff 406136

bolt/unittests/Core/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
BOLTCore
BOLTRewrite BOLTRewrite
DebugInfoDWARF
Object
${LLVM_TARGETS_TO_BUILD}
) )
add_bolt_unittest(CoreTests add_bolt_unittest(CoreTests
MCPlusBuilder.cpp MCPlusBuilder.cpp
) )
string(FIND "${LLVM_TARGETS_TO_BUILD}" "AArch64" POSITION) if ("AArch64" IN_LIST LLVM_TARGETS_TO_BUILD)
if (NOT ${POSITION} EQUAL -1)
include_directories( include_directories(
${CMAKE_SOURCE_DIR}/lib/Target/AArch64 ${LLVM_MAIN_SRC_DIR}/lib/Target/AArch64
${CMAKE_BINARY_DIR}/lib/Target/AArch64 ${LLVM_BINARY_DIR}/lib/Target/AArch64
) )
target_compile_definitions(CoreTests PRIVATE AARCH64_AVAILABLE) target_compile_definitions(CoreTests PRIVATE AARCH64_AVAILABLE)
endif() endif()
string(FIND "${LLVM_TARGETS_TO_BUILD}" "X86" POSITION) if ("X86" IN_LIST LLVM_TARGETS_TO_BUILD)
if (NOT ${POSITION} EQUAL -1)
include_directories( include_directories(
${LLVM_MAIN_SRC_DIR}/lib/Target/X86 ${LLVM_MAIN_SRC_DIR}/lib/Target/X86
${LLVM_BINARY_DIR}/lib/Target/X86 ${LLVM_BINARY_DIR}/lib/Target/X86
) )
target_compile_definitions(CoreTests PRIVATE X86_AVAILABLE) target_compile_definitions(CoreTests PRIVATE X86_AVAILABLE)
endif() endif()