This is an archive of the discontinued LLVM Phabricator instance.

Differential D118868

[BOLT][TEST] Add heatmap.test
ClosedPublic

Authored by Amir on Feb 2 2022, 5:54 PM.

Details

Reviewers
maksfb
rafauler
yota9
ayermolo
Commits
rG1ab13cc18b23: [BOLT][TEST] Add heatmap.test
Summary

Add a basic test for heatmap mode

Diff Detail

Event Timeline

Amir created this revision.Feb 2 2022, 5:54 PM
Herald added subscribers: ayermolo, mgorny. · View Herald TranscriptFeb 2 2022, 5:54 PM
Amir requested review of this revision.Feb 2 2022, 5:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2022, 5:54 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Amir added a comment.Feb 2 2022, 5:57 PM

Hi @yota9,

D118271 has moved InputFilename from CommandLineOpts.cpp into llvm-bolt.cpp and this broke heatmap mode. I'm adding basic test for this mode (marked as XFAIL). Can you please fix the option and enable the test?

Harbormaster completed remote builds in B147302: Diff 405509.Feb 2 2022, 6:02 PM
maksfb accepted this revision.Feb 2 2022, 6:17 PM
This revision is now accepted and ready to land.Feb 2 2022, 6:17 PM
ayermolo accepted this revision.Feb 2 2022, 6:18 PM
This revision was landed with ongoing or failed builds.Feb 2 2022, 6:56 PM
Closed by commit rG1ab13cc18b23: [BOLT][TEST] Add heatmap.test (authored by Amir). · Explain Why
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rG1ab13cc18b23: [BOLT][TEST] Add heatmap.test.

Revision Contents

PathSize
bolt/
test/
1 line
12 lines
1 line

Diff 405509

bolt/test/CMakeLists.txt

Show All 26 Lineslist(APPEND BOLT_TEST_DEPS
clang clang
count count
FileCheck FileCheck
llc llc
lld lld
llvm-config llvm-config
llvm-bolt llvm-bolt
llvm-boltdiff llvm-boltdiff
llvm-bolt-heatmap
llvm-dwarfdump llvm-dwarfdump
llvm-mc llvm-mc
llvm-nm llvm-nm
llvm-objdump llvm-objdump
llvm-readelf llvm-readelf
llvm-readobj llvm-readobj
llvm-strip llvm-strip
llvm-objcopy llvm-objcopy
Show All 21 Lines

bolt/test/heatmap.test

  • This file was added.
# Verifies basic functioning of heatmap mode
REQUIRES: system-linux
XFAIL: *
RUN: llvm-bolt heatmap --help | FileCheck %s --check-prefix=CHECK-SUBCOMMAND
CHECK-SUBCOMMAND: SUBCOMMAND 'heatmap': generate heatmap
CHECK-SUBCOMMAND: USAGE: llvm-bolt heatmap [options] <executable>
RUN: llvm-bolt-heatmap --help | FileCheck %s --check-prefix=CHECK-STANDALONE
CHECK-STANDALONE: SUBCOMMAND 'heatmap': generate heatmap
CHECK-STANDALONE: USAGE: llvm-bolt-heatmap heatmap [options] <executable>

bolt/test/lit.cfg.py

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines
tool_dirs = [config.llvm_tools_dir, tool_dirs = [config.llvm_tools_dir,
config.test_source_root] config.test_source_root]
tools = [ tools = [
ToolSubst('llc', unresolved='fatal'), ToolSubst('llc', unresolved='fatal'),
ToolSubst('llvm-dwarfdump', unresolved='fatal'), ToolSubst('llvm-dwarfdump', unresolved='fatal'),
ToolSubst('llvm-bolt', unresolved='fatal'), ToolSubst('llvm-bolt', unresolved='fatal'),
ToolSubst('llvm-boltdiff', unresolved='fatal'), ToolSubst('llvm-boltdiff', unresolved='fatal'),
ToolSubst('llvm-bolt-heatmap', unresolved='fatal'),
ToolSubst('perf2bolt', unresolved='fatal'), ToolSubst('perf2bolt', unresolved='fatal'),
ToolSubst('yaml2obj', unresolved='fatal'), ToolSubst('yaml2obj', unresolved='fatal'),
ToolSubst('llvm-mc', unresolved='fatal'), ToolSubst('llvm-mc', unresolved='fatal'),
ToolSubst('llvm-nm', unresolved='fatal'), ToolSubst('llvm-nm', unresolved='fatal'),
ToolSubst('llvm-objdump', unresolved='fatal'), ToolSubst('llvm-objdump', unresolved='fatal'),
ToolSubst('llvm-objcopy', unresolved='fatal'), ToolSubst('llvm-objcopy', unresolved='fatal'),
ToolSubst('llvm-strip', unresolved='fatal'), ToolSubst('llvm-strip', unresolved='fatal'),
ToolSubst('llvm-readelf', unresolved='fatal'), ToolSubst('llvm-readelf', unresolved='fatal'),
Show All 17 Lines