This is an archive of the discontinued LLVM Phabricator instance.

Differential D118580

[BOLT][CMAKE] Add extra BOLT_INCLUDE_TESTS condition for merge-fdata emit-relocs option
ClosedPublic

Authored by Amir on Jan 30 2022, 10:03 PM.

Details

Reviewers
maksfb
rafauler
yota9
Commits
rGc25ba3c79020: [BOLT][CMAKE] Add extra BOLT_INCLUDE_TESTS condition for merge-fdata emit…
Summary

Only enable --emit-relocs linker option for merge-fdata target if tests are enabled.

Diff Detail

Event Timeline

Amir created this revision.Jan 30 2022, 10:03 PM
Herald added subscribers: ayermolo, mgorny. · View Herald TranscriptJan 30 2022, 10:03 PM
Amir requested review of this revision.Jan 30 2022, 10:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 30 2022, 10:03 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B146561: Diff 404424.Jan 30 2022, 10:50 PM
maksfb accepted this revision.Jan 31 2022, 9:08 PM

LGTM

This revision is now accepted and ready to land.Jan 31 2022, 9:08 PM
This revision was landed with ongoing or failed builds.Jan 31 2022, 9:20 PM
Closed by commit rGc25ba3c79020: [BOLT][CMAKE] Add extra BOLT_INCLUDE_TESTS condition for merge-fdata emit… (authored by Amir). · Explain Why
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rGc25ba3c79020: [BOLT][CMAKE] Add extra BOLT_INCLUDE_TESTS condition for merge-fdata emit….

Revision Contents

PathSize
bolt/
tools/
merge-fdata/
2 lines

Diff 404424

bolt/tools/merge-fdata/CMakeLists.txt

set(LLVM_LINK_COMPONENTS Support) set(LLVM_LINK_COMPONENTS Support)
add_llvm_tool(merge-fdata add_llvm_tool(merge-fdata
merge-fdata.cpp merge-fdata.cpp
DEPENDS DEPENDS
intrinsics_gen intrinsics_gen
) )
set_target_properties(merge-fdata PROPERTIES FOLDER "BOLT") set_target_properties(merge-fdata PROPERTIES FOLDER "BOLT")
# Emit relocations for BOLT meta test (bolt/test/runtime/meta-merge-fdata.test) # Emit relocations for BOLT meta test (bolt/test/runtime/meta-merge-fdata.test)
if (UNIX AND NOT APPLE) if (BOLT_INCLUDE_TESTS AND UNIX AND NOT APPLE)
target_link_options(merge-fdata PRIVATE LINKER:--emit-relocs) target_link_options(merge-fdata PRIVATE LINKER:--emit-relocs)
endif() endif()