[polly][unittests] Link DeLICMTests with libLLVMCore

[ro]

Summary

A -DBUILD_SHARED_LIBS=ON build on Solaris/amd64 failed with

Undefined                       first referenced
 symbol                             in file
_ZNK4llvm3cfg6UpdateIPNS_10BasicBlockEE4dumpEv tools/polly/unittests/DeLICM/CMakeFiles/DeLICMTests.dir/DeLICMTest.cpp.o  (symbol belongs to implicit dependency /var/llvm/local-amd64-release-stage2-shared-A/bin/../lib/libLLVMCore.so.14git)
ld: fatal: symbol referencing errors

Solaris ld requires to directly link with dependant libraries, so this patch explicitly adds
libLLVMCore.

Tested on amd64-pc-solaris2.11 and x86_64-pc-linux-gnu.

[Meinersbur]

DeLICMTests, like all the unittests indeed requires LLVMCore, but I would have assumed it is resolved as transitive dependency by cmake, or at least llvm_config inside add_polly_unittest.

On Linux/x86_64, this configuration ist tested by https://lab.llvm.org/buildbot/#/builders/207 which does not show this issue. Are "implicit dependencies" something Solaris-specific?

polly/unittests/DeLICM/CMakeLists.txt

2

Before I accept the patch, could you add a comment saying why this is needed?

[ro]

In D118452#3279208, @Meinersbur wrote:

DeLICMTests, like all the unittests indeed requires LLVMCore, but I would have assumed it is resolved as transitive dependency by cmake, or at least llvm_config inside add_polly_unittest.

On Linux/x86_64, this configuration ist tested by https://lab.llvm.org/buildbot/#/builders/207 which does not show this issue. Are "implicit dependencies" something Solaris-specific?

This only happens on Solaris with -DBUILD_SHARED_LIBS=ON, which is OFF by default. I guess this requirement is Solaris-specific, yes. In a way, it makes sense: imagine the direct dependeny (which currently depends on libLLVMCore) drops that dependency in the future (not likely in this case, but well possible in general). Then the executable would suddenly fail to run, which cannot happen if you make the dependency explicit.

This instance is the only case of this problem in the whole tree (well, the parts I do build on Solaris).

polly/unittests/DeLICM/CMakeLists.txt

2

Sure, will do.

[ro]

Add comment.

[Meinersbur]

LGTM, thank you.

polly/unittests/DeLICM/CMakeLists.txt

+# Solaris ld requires this dependency to be made explicit for shared builds.
+set(LLVM_LINK_COMPONENTS
+  Core
+  )
+
 add_polly_unittest(DeLICMTests
   DeLICMTest.cpp
   )