Page MenuHomePhabricator
Differential D118154

[mlir] Don't emit unused labels
ClosedPublic
Actions

Authored by marbre on Jan 25 2022, 8:24 AM.

Details

Reviewers
benvanik
mehdi_amini
jpienaar
Commits
rG578122c18a2f: [mlir] Don't emit unused labels
Summary

Stop the Cpp target from emitting unused labels. The previosly generated
code generated warning if -Wunused-label is passed to a compiler.

Co-authored-by: Simon Camphausen <simon.camphausen@iml.fraunhofer.de>

Diff Detail

Event Timeline

marbre created this revision.Jan 25 2022, 8:24 AM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 19 others. · View Herald TranscriptJan 25 2022, 8:24 AM
marbre requested review of this revision.Jan 25 2022, 8:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2022, 8:24 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
jpienaar accepted this revision.Jan 25 2022, 8:32 AM
jpienaar added a subscriber: jpienaar.
jpienaar added inline comments.
mlir/lib/Target/Cpp/TranslateToCpp.cpp
634

Could you update this comment?

This revision is now accepted and ready to land.Jan 25 2022, 8:32 AM
marbre updated this revision to Diff 403240.Jan 26 2022, 6:18 AM

Updating D118154: [mlir] Don't emit unused labels

marbre marked an inline comment as done.Jan 26 2022, 6:20 AM
marbre added inline comments.
mlir/lib/Target/Cpp/TranslateToCpp.cpp
634

I've updated the comment and further revised the condition (it is sufficient to just check if the block has predecessors).

This revision was landed with ongoing or failed builds.Jan 26 2022, 11:56 PM
Closed by commit rG578122c18a2f: [mlir] Don't emit unused labels (authored by marbre). · Explain Why
This revision was automatically updated to reflect the committed changes.
marbre marked an inline comment as done.
marbre added a commit: rG578122c18a2f: [mlir] Don't emit unused labels.
Harbormaster completed remote builds in B145732: Diff 403240.Jan 27 2022, 1:49 AM

Revision Contents
Changeset List

PathSize
mlir/
lib/
Target/
Cpp/
4 lines
test/
Target/
Cpp/
3 lines

Diff 403519

View Options

mlir/lib/Target/Cpp/TranslateToCpp.cpp

Loading...
View Options

mlir/test/Target/Cpp/control_flow.mlir

Loading...