Page MenuHomePhabricator

benvanik (Ben Vanik)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 2 2020, 8:36 AM (48 w, 4 h)

Recent Activity

Sun, Nov 8

benvanik accepted D90958: [mlir][Python] Add Windows DLL loader to get python extensions working there..
Sun, Nov 8, 10:24 AM · Restricted Project

Thu, Nov 5

benvanik accepted D90824: [mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so..
Thu, Nov 5, 4:09 PM · Restricted Project
benvanik requested changes to D90824: [mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so..

LGTM besides naming

Thu, Nov 5, 1:05 PM · Restricted Project

Oct 12 2020

benvanik requested review of D89255: [mlir] fixing typo in parseAttribute that was ignoring caller-specified types.
Oct 12 2020, 10:39 AM · Restricted Project

Apr 22 2020

benvanik accepted D78690: [mlir][Standard] Allow select to use an i1 for vector and tensor values.
Apr 22 2020, 8:38 PM · Restricted Project
benvanik accepted D78682: [mlir][Standard] Add a canonicalization to simplify cond_br when the successors are identical.
Apr 22 2020, 6:31 PM · Restricted Project
benvanik accepted D78683: [mlir][Standard] Add support for canonicalizing branches to passthrough blocks.
Apr 22 2020, 6:31 PM · Restricted Project
benvanik accepted D78681: [mlir][Standard] Add canonicalization for collapsing pass through cond_br successors..
Apr 22 2020, 6:31 PM · Restricted Project
benvanik added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 22 2020, 11:58 AM · Restricted Project, Restricted Project

Apr 21 2020

benvanik added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 21 2020, 1:33 PM · Restricted Project, Restricted Project

Apr 7 2020

benvanik accepted D77686: [mlir][AsmFormat] Avoid invalidating the iterator when verifying attributes.
Apr 7 2020, 3:49 PM · Restricted Project

Mar 4 2020

benvanik accepted D75531: [mlir][vulkan-runner] Add basic timing for compute pipeline.
Mar 4 2020, 1:29 PM · Restricted Project
benvanik added inline comments to D75531: [mlir][vulkan-runner] Add basic timing for compute pipeline.
Mar 4 2020, 9:00 AM · Restricted Project

Mar 3 2020

benvanik added inline comments to D75531: [mlir][vulkan-runner] Add basic timing for compute pipeline.
Mar 3 2020, 2:24 PM · Restricted Project

Feb 28 2020

benvanik added inline comments to D74884: Added CallOpSignatureConversion pattern.
Feb 28 2020, 11:51 AM

Feb 16 2020

benvanik accepted D74646: [mlir] Add a TypeRange class that functions similar to ValueRange..

Perfect!

Feb 16 2020, 1:49 PM · Restricted Project

Feb 4 2020

benvanik accepted D73959: [mlir][spirv] Add dialect-specific attribute for target environment.
V_1_3, [], [Shader, GroupNonUniformArithmetic],

Beautiful!

Feb 4 2020, 6:21 PM · Restricted Project

Jan 25 2020

benvanik accepted D73415: [mlir][spirv] Relax verification to allow flexible placement.
Jan 25 2020, 4:08 PM · Restricted Project
benvanik accepted D73349: [mlir][spirv] Add spv.GroupNonUniformElect and spv.GroupNonUniformIAdd.
Jan 25 2020, 4:08 PM · Restricted Project
benvanik accepted D73379: [mlir] Add support for marking 'unknown' operations as dynamically legal..
Jan 25 2020, 4:08 PM · Restricted Project
benvanik accepted D73419: [mlir][spirv] NFC: simplify load/store builder call sites.
Jan 25 2020, 4:08 PM · Restricted Project
benvanik accepted D73421: [mlir][spirv] NFC: expose builtin func op conversion pattern.
Jan 25 2020, 4:08 PM · Restricted Project
benvanik accepted D73416: [mlir][spirv] Create builtin variable in nearest symbol table.
Jan 25 2020, 3:59 PM · Restricted Project

Jan 16 2020

benvanik accepted D72763: [mlir][spirv] Use symbolize functions in enum attribute predicates.

Awesome! I may use that predicate/class in some of my dialects too :)

Jan 16 2020, 7:30 AM · Restricted Project

Jan 15 2020

benvanik requested changes to D72763: [mlir][spirv] Use symbolize functions in enum attribute predicates.

sybmolize is a typo in the description :)

Jan 15 2020, 9:15 AM · Restricted Project
benvanik accepted D72764: [mlir][spirv] Fix SPV_MM_Vulkan extension reqirements.
Jan 15 2020, 9:15 AM · Restricted Project
benvanik accepted D72765: [mlir][spirv] Support implied extensions and capabilities.
Jan 15 2020, 9:15 AM · Restricted Project
benvanik accepted D72760: [mlir][spirv] Add implied capabilities and availability for capabilities.
Jan 15 2020, 9:15 AM · Restricted Project

Jan 14 2020

benvanik accepted D72256: [mlir][spirv] Properly support SPIR-V conversion target.
Jan 14 2020, 1:47 PM · Restricted Project