This is an archive of the discontinued LLVM Phabricator instance.

Differential D118053

[libc] Add bazel definition for hypot/hypotf.
ClosedPublic

Authored by rupprecht on Jan 24 2022, 9:45 AM.

Details

Reviewers
gchatelet
sivachandra
michaelrj
lntue
Commits
rG57eb5033cdff: [libc] Add bazel definition for hypot/hypotf.
Summary

Patch by Clint Caywood.

Diff Detail

Event Timeline

rupprecht created this revision.Jan 24 2022, 9:45 AM
Herald added subscribers: ecnelises, tschuett. · View Herald TranscriptJan 24 2022, 9:45 AM
rupprecht requested review of this revision.Jan 24 2022, 9:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2022, 9:45 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
sivachandra accepted this revision.Jan 24 2022, 9:46 AM
sivachandra added a reviewer: lntue.

LGTM. @lntue is planning to refactor the hypot setup so I have added him to the list of reviewers.

This revision is now accepted and ready to land.Jan 24 2022, 9:47 AM
Harbormaster completed remote builds in B145263: Diff 402573.Jan 24 2022, 9:51 AM
Closed by commit rG57eb5033cdff: [libc] Add bazel definition for hypot/hypotf. (authored by cratonica, committed by rupprecht). · Explain WhyJan 24 2022, 9:55 AM
This revision was automatically updated to reflect the committed changes.
rupprecht added a commit: rG57eb5033cdff: [libc] Add bazel definition for hypot/hypotf..
rupprecht added a comment.Jan 24 2022, 3:23 PM
In D118053#3266716, @sivachandra wrote:

LGTM. @lntue is planning to refactor the hypot setup so I have added him to the list of reviewers.

Sorry, missed that there was an extra reviewer added. @lntue, lemme know if your refactoring hits any snags here.

lntue added a comment.Jan 24 2022, 7:32 PM
In D118053#3267778, @rupprecht wrote:
In D118053#3266716, @sivachandra wrote:

LGTM. @lntue is planning to refactor the hypot setup so I have added him to the list of reviewers.

Sorry, missed that there was an extra reviewer added. @lntue, lemme know if your refactoring hits any snags here.

No problem, it looks good to me.

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
libc/
5 lines

Diff 402573

utils/bazel/llvm-project-overlay/libc/BUILD.bazel

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines
fputil_common_hdrs = [ fputil_common_hdrs = [
"src/__support/FPUtil/BasicOperations.h", "src/__support/FPUtil/BasicOperations.h",
"src/__support/FPUtil/DivisionAndRemainderOperations.h", "src/__support/FPUtil/DivisionAndRemainderOperations.h",
"src/__support/FPUtil/FEnvImpl.h", "src/__support/FPUtil/FEnvImpl.h",
"src/__support/FPUtil/FEnvUtils.h", "src/__support/FPUtil/FEnvUtils.h",
"src/__support/FPUtil/FPBits.h", "src/__support/FPUtil/FPBits.h",
"src/__support/FPUtil/FloatProperties.h", "src/__support/FPUtil/FloatProperties.h",
"src/__support/FPUtil/Hypot.h",
"src/__support/FPUtil/ManipulationFunctions.h", "src/__support/FPUtil/ManipulationFunctions.h",
"src/__support/FPUtil/NearestIntegerOperations.h", "src/__support/FPUtil/NearestIntegerOperations.h",
"src/__support/FPUtil/NormalFloat.h", "src/__support/FPUtil/NormalFloat.h",
"src/__support/FPUtil/PlatformDefs.h", "src/__support/FPUtil/PlatformDefs.h",
"src/__support/FPUtil/Sqrt.h", "src/__support/FPUtil/Sqrt.h",
] ]
fputil_hdrs = selects.with_or({ fputil_hdrs = selects.with_or({
▲ Show 20 Lines • Show All 280 Lines • ▼ Show 20 Lines
libc_math_function(name = "roundl") libc_math_function(name = "roundl")
libc_math_function(name = "frexp") libc_math_function(name = "frexp")
libc_math_function(name = "frexpf") libc_math_function(name = "frexpf")
libc_math_function(name = "frexpl") libc_math_function(name = "frexpl")
libc_math_function(name = "hypot")
libc_math_function(name = "hypotf")
libc_math_function(name = "logb") libc_math_function(name = "logb")
libc_math_function(name = "logbf") libc_math_function(name = "logbf")
libc_math_function(name = "logbl") libc_math_function(name = "logbl")
libc_math_function(name = "modf") libc_math_function(name = "modf")
▲ Show 20 Lines • Show All 505 Lines • Show Last 20 Lines