Signed-off-by: JackAKirk <firstname.lastname@example.org>
LGTM. Should I commit the patch on your behalf?
It appears that we do not actually test for the correct number of registers used in an instruction argument, only for the correct instruction variant itself.
It should've been caught if we were to attempt assembling generated PTX with ptxas.
Thanks I can try to land it myself. I executed arc land and it is asking me to "Land these changes". I am not sure that I have the permissions for this to succeed, but I can try. I have not done this before: is it safe to enter simply "y" with the existing commit message (name/email in the commit are correct)?
If you are not sure if you have commit access, you probably do not. It must be explicitly granted:
As for landing the patch, I do it manually with git. Never tried it with arc, so I can't say much, except that it will not work until you have commit access.