Page MenuHomePhabricator

JackAKirk (Jack Kirk)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 5 2022, 7:14 AM (19 w, 4 d)

Recent Activity

Jan 25 2022

JackAKirk added a comment to D118023: Corrected fragment size for tf32 LD B matrix..

The patch uses a @gmail.com email. Should I change it to JackAKirk <jack.kirk@codeplay.com> to match the sign-off email?

Jan 25 2022, 12:42 AM · Restricted Project

Jan 24 2022

JackAKirk added a comment to D118023: Corrected fragment size for tf32 LD B matrix..

If you are not sure if you have commit access, you probably do not. It must be explicitly granted:
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

As for landing the patch, I do it manually with git. Never tried it with arc, so I can't say much, except that it will not work until you have commit access.

Jan 24 2022, 11:28 AM · Restricted Project
JackAKirk added a comment to D118023: Corrected fragment size for tf32 LD B matrix..

LGTM. Should I commit the patch on your behalf?

Note that the test, llvm/test/CodeGen/NVPTX/wmma.py line 210, had the correct value already but didn't seem to cover the mistake.

It appears that we do not actually test for the correct number of registers used in an instruction argument, only for the correct instruction variant itself.
It should've been caught if we were to attempt assembling generated PTX with ptxas.

Jan 24 2022, 10:55 AM · Restricted Project
JackAKirk added a comment to D118023: Corrected fragment size for tf32 LD B matrix..

Note that the test, llvm/test/CodeGen/NVPTX/wmma.py line 210, had the correct value already but didn't seem to cover the mistake.

Jan 24 2022, 2:35 AM · Restricted Project
JackAKirk requested review of D118023: Corrected fragment size for tf32 LD B matrix..
Jan 24 2022, 2:19 AM · Restricted Project

Jan 14 2022

JackAKirk added a comment to D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions.

I can land the patch on your behalf. Are you OK to use the name/email in this patch or do you prefer to use a different email for the LLVM commit?

Thanks very much. Yes the name/email in the patch is fine.

Note for the future. It would make it easier to land the patch if it was submitted to phabricator as a git patch, according to the instructions here: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Review tracker would then include info about relevant base commit, author, commit message, etc. and it can be easily applied with arc patch to my tree. Using plain diff requires a bit of extra manual work to transfer all of that from the review tracker to the git commit.

Jan 14 2022, 7:42 AM · Restricted Project, Restricted Project

Jan 12 2022

JackAKirk added a comment to D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions.

I can land the patch on your behalf. Are you OK to use the name/email in this patch or do you prefer to use a different email for the LLVM commit?

Thanks very much. Yes the name/email in the patch is fine.

Jan 12 2022, 10:03 AM · Restricted Project, Restricted Project
JackAKirk added a comment to D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions.

I thought I should let you know that I do not have commit access to land the patch. I'm also happy to wait a little longer in case you think other interested parties might still chime in.

Jan 12 2022, 6:15 AM · Restricted Project, Restricted Project

Jan 6 2022

JackAKirk updated the diff for D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions.

Made suggested change to naming convention.

Jan 6 2022, 7:27 AM · Restricted Project, Restricted Project

Jan 5 2022

JackAKirk requested review of D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions.
Jan 5 2022, 9:50 AM · Restricted Project, Restricted Project