This is an archive of the discontinued LLVM Phabricator instance.

[mlir:ArmSVE][NFC] Remove dead code and unnecessary dependencies
ClosedPublic

Authored by rriddle on Jan 23 2022, 2:20 AM.

Diff Detail

Event Timeline

rriddle created this revision.Jan 23 2022, 2:20 AM
rriddle requested review of this revision.Jan 23 2022, 2:20 AM
jsetoain accepted this revision.Jan 23 2022, 5:55 AM

Thanks for this, really appreciated!

This revision is now accepted and ready to land.Jan 23 2022, 5:55 AM
mehdi_amini accepted this revision.Jan 23 2022, 12:49 PM
mehdi_amini added inline comments.
mlir/lib/Dialect/ArmSVE/IR/ArmSVEDialect.cpp
15

Is there a CMake dependency that can be removed here?

rriddle marked an inline comment as done.Jan 23 2022, 12:52 PM
rriddle added inline comments.
mlir/lib/Dialect/ArmSVE/IR/ArmSVEDialect.cpp
15

No, the dependency was never encoded in CMake AFAICT.

rriddle updated this revision to Diff 402582.Jan 24 2022, 10:07 AM
rriddle edited the summary of this revision. (Show Details)
rriddle marked an inline comment as done.
mehdi_amini accepted this revision.Jan 24 2022, 5:41 PM
This revision was landed with ongoing or failed builds.Jan 24 2022, 7:30 PM
This revision was automatically updated to reflect the committed changes.