This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Move linalg::PadTensorOp to tensor::PadOp.
ClosedPublic

Authored by pifon2a on Jan 21 2022, 7:29 AM.

Diff Detail

Event Timeline

pifon2a created this revision.Jan 21 2022, 7:29 AM
pifon2a requested review of this revision.Jan 21 2022, 7:29 AM
nicolasvasilache accepted this revision.Jan 21 2022, 7:32 AM

thanks much!

This revision is now accepted and ready to land.Jan 21 2022, 7:32 AM
pifon2a updated this revision to Diff 401981.Jan 21 2022, 7:34 AM

Fix the wrapped line

This revision was automatically updated to reflect the committed changes.
mehdi_amini added inline comments.Jan 21 2022, 6:02 PM
mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
1533

Have you checked before that:

  1. The block has a terminator op?
  2. The terminator is a yield op?
pifon2a marked an inline comment as done.Jan 22 2022, 2:48 AM
pifon2a added inline comments.
mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
1533
mehdi_amini added inline comments.Jan 25 2022, 11:41 PM
mlir/include/mlir/InitAllDialects.h
90

Similarly to my comment in D115502 ; I have strong concern to this.

The need to modify registerAllDialects to do anything else than registering a dialect does not seem right to me, and also does not have a precedent. We need to consider carefully what would be the right solution for this.

I'd rather find something quickly or revert these changes: I'm afraid that this will get engrained and create a situation that will be hard to get out of.