Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Dialect/Tensor/IR/TensorOps.cpp | ||
---|---|---|
1533 | Have you checked before that:
|
mlir/lib/Dialect/Tensor/IR/TensorOps.cpp | ||
---|---|---|
1533 | added a SingleBlockImplicitTerminator in https://github.com/llvm/llvm-project/commit/4041354b4c12fb4329853b67f61b8617252188d6 |
mlir/include/mlir/InitAllDialects.h | ||
---|---|---|
90 | Similarly to my comment in D115502 ; I have strong concern to this. The need to modify registerAllDialects to do anything else than registering a dialect does not seem right to me, and also does not have a precedent. We need to consider carefully what would be the right solution for this. I'd rather find something quickly or revert these changes: I'm afraid that this will get engrained and create a situation that will be hard to get out of. |
Similarly to my comment in D115502 ; I have strong concern to this.
The need to modify registerAllDialects to do anything else than registering a dialect does not seem right to me, and also does not have a precedent. We need to consider carefully what would be the right solution for this.
I'd rather find something quickly or revert these changes: I'm afraid that this will get engrained and create a situation that will be hard to get out of.