This is superseded by the same method on OpAsmOpInterface, which is
available on the Dialect through the Fallback mechanism,
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I thought these served different purposes in that the latter provides a mechanism for doing some dialect wide (e.g., prefix with "foo_" unconditionally in dialect foo) like the regular dialect fallback hooks (query the op, query the dialect). Is this just unused? Or subsumed by way of being able to do this using dialect fallback hooks? Could you expand the summary?
Comment Actions
If this was the case, it shouldn't take the Operation as operand. I don't think Dialect interfaces should ever take operations, in particular since we support Dialect fallback for op interfaces.
Or subsumed by way of being able to do this using dialect fallback hooks? Could you expand the summary?
Added mention of the Fallback in the summary (I think that's what you meant).
clang-format: please reformat the code