Page MenuHomePhabricator

Remove obsolete `getAsmResultNames` from OpAsmDialectInterface
ClosedPublic

Authored by mehdi_amini on Jan 19 2022, 11:03 PM.

Details

Summary

This is superseded by the same method on OpAsmOpInterface, which is
available on the Dialect through the Fallback mechanism,

Diff Detail

Event Timeline

mehdi_amini created this revision.Jan 19 2022, 11:03 PM
mehdi_amini requested review of this revision.Jan 19 2022, 11:03 PM

I thought these served different purposes in that the latter provides a mechanism for doing some dialect wide (e.g., prefix with "foo_" unconditionally in dialect foo) like the regular dialect fallback hooks (query the op, query the dialect). Is this just unused? Or subsumed by way of being able to do this using dialect fallback hooks? Could you expand the summary?

mehdi_amini edited the summary of this revision. (Show Details)Jan 20 2022, 6:29 PM

I thought these served different purposes in that the latter provides a mechanism for doing some dialect wide (e.g., prefix with "foo_" unconditionally in dialect foo)

If this was the case, it shouldn't take the Operation as operand. I don't think Dialect interfaces should ever take operations, in particular since we support Dialect fallback for op interfaces.

Or subsumed by way of being able to do this using dialect fallback hooks? Could you expand the summary?

Added mention of the Fallback in the summary (I think that's what you meant).

rriddle accepted this revision.Jan 20 2022, 9:45 PM
This revision is now accepted and ready to land.Jan 20 2022, 9:45 PM
This revision was landed with ongoing or failed builds.Jan 20 2022, 9:58 PM
This revision was automatically updated to reflect the committed changes.